From: Heiko Stuebner <heiko@sntech.de>
To: linux-gpio@vger.kernel.org, Luca Ceresoli <luca.ceresoli@bootlin.com>
Cc: Luca Ceresoli <luca.ceresoli@bootlin.com>,
Linus Walleij <linus.walleij@linaro.org>,
Jianqun Xu <jay.xu@rock-chips.com>,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] pinctrl: rockchip: sort the rk3308_mux_recalced_data entries
Date: Wed, 20 Apr 2022 17:05:06 +0200 [thread overview]
Message-ID: <4520799.LvFx2qVVIh@phil> (raw)
In-Reply-To: <20220420142432.248565-2-luca.ceresoli@bootlin.com>
Am Mittwoch, 20. April 2022, 16:24:32 CEST schrieb Luca Ceresoli:
> All the entries are sorted according to num/pin except for two
> entries. Sort them too.
>
> Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
Reviewed-by: Heiko Stuebner <heiko@sntech.de>
> ---
> drivers/pinctrl/pinctrl-rockchip.c | 28 ++++++++++++++--------------
> 1 file changed, 14 insertions(+), 14 deletions(-)
>
> diff --git a/drivers/pinctrl/pinctrl-rockchip.c b/drivers/pinctrl/pinctrl-rockchip.c
> index 65fa305b5f59..2cb79e649fcf 100644
> --- a/drivers/pinctrl/pinctrl-rockchip.c
> +++ b/drivers/pinctrl/pinctrl-rockchip.c
> @@ -512,20 +512,6 @@ static struct rockchip_mux_recalced_data rk3308_mux_recalced_data[] = {
> .reg = 0x34,
> .bit = 8,
> .mask = 0xf
> - }, {
> - /* gpio3b4_sel */
> - .num = 3,
> - .pin = 12,
> - .reg = 0x68,
> - .bit = 8,
> - .mask = 0xf
> - }, {
> - /* gpio3b5_sel */
> - .num = 3,
> - .pin = 13,
> - .reg = 0x68,
> - .bit = 12,
> - .mask = 0xf
> }, {
> /* gpio2a2_sel */
> .num = 2,
> @@ -561,6 +547,20 @@ static struct rockchip_mux_recalced_data rk3308_mux_recalced_data[] = {
> .reg = 0x68,
> .bit = 6,
> .mask = 0x3
> + }, {
> + /* gpio3b4_sel */
> + .num = 3,
> + .pin = 12,
> + .reg = 0x68,
> + .bit = 8,
> + .mask = 0xf
> + }, {
> + /* gpio3b5_sel */
> + .num = 3,
> + .pin = 13,
> + .reg = 0x68,
> + .bit = 12,
> + .mask = 0xf
> },
> };
>
>
next prev parent reply other threads:[~2022-04-20 15:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-20 14:24 [PATCH 1/2] pinctrl: rockchip: fix RK3308 pinmux bits Luca Ceresoli
2022-04-20 14:24 ` [PATCH 2/2] pinctrl: rockchip: sort the rk3308_mux_recalced_data entries Luca Ceresoli
2022-04-20 15:05 ` Heiko Stuebner [this message]
2022-04-20 15:04 ` [PATCH 1/2] pinctrl: rockchip: fix RK3308 pinmux bits Heiko Stuebner
2022-04-22 21:36 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4520799.LvFx2qVVIh@phil \
--to=heiko@sntech.de \
--cc=jay.xu@rock-chips.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=luca.ceresoli@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).