From: Lars Poeschel <poeschel@lemonage.de>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: linux-gpio@vger.kernel.org, Alexandre Courbot <acourbot@nvidia.com>
Subject: Re: [PATCH] gpio: mcp23s08: depend on OF_GPIO
Date: Wed, 22 Jan 2014 16:05:07 +0100 [thread overview]
Message-ID: <4701386.ZaUECGUEut@lem-wkst-02> (raw)
In-Reply-To: <1390205344-15194-1-git-send-email-linus.walleij@linaro.org>
Hi Linus,
I saw some trouble happening as Linus Torvalds pulled my interrupt commit in.
Sorry for causing this mess.
You tried to fix my mistake with this patch. After I read Torvalds mail, I
realized that mcp23s08 driver now depends on OF_GPIO. I wonder if your patch
was the best way to fix this. I think a better way would be to not explicitly
depend on OF_GPIO rather than disabling interrupt functionality if OF_GPIO is
not selected. What I am a bit concerned about is, that we locked out non-OF
users from being able to use this driver from now on.
I seems since Linus Torvalds now pulled our patches and fixed them up, it is a
bit too late, but should we do another patch third patch, that reenables the
non-OF usage of the driver ? What do you think ?
Regards,
Lars
On Wednesday 22 January 2014 09:09:04, Linus Walleij wrote:
> The MCP drivers fails to compile on trial builds due to missing
> Kconfig dependency on OF_GPIO. Fix it.
>
> Cc: Lars Poeschel <poeschel@lemonage.de>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
> drivers/gpio/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
> index 2d49784109b5..d5bd9eece408 100644
> --- a/drivers/gpio/Kconfig
> +++ b/drivers/gpio/Kconfig
> @@ -717,7 +717,7 @@ config GPIO_MAX7301
>
> config GPIO_MCP23S08
> tristate "Microchip MCP23xxx I/O expander"
> - depends on (SPI_MASTER && !I2C) || I2C
> + depends on (SPI_MASTER && !I2C) || I2C && OF_GPIO
> help
> SPI/I2C driver for Microchip MCP23S08/MCP23S17/MCP23008/MCP23017
> I/O expanders.
next prev parent reply other threads:[~2014-01-22 15:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-20 8:09 [PATCH] gpio: mcp23s08: depend on OF_GPIO Linus Walleij
2014-01-22 15:05 ` Lars Poeschel [this message]
2014-01-23 8:30 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4701386.ZaUECGUEut@lem-wkst-02 \
--to=poeschel@lemonage.de \
--cc=acourbot@nvidia.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox