From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5B50DC64E7B for ; Wed, 2 Dec 2020 17:58:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EBE21221FA for ; Wed, 2 Dec 2020 17:58:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728906AbgLBR6n (ORCPT ); Wed, 2 Dec 2020 12:58:43 -0500 Received: from mailoutvs33.siol.net ([185.57.226.224]:33840 "EHLO mail.siol.net" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728896AbgLBR6n (ORCPT ); Wed, 2 Dec 2020 12:58:43 -0500 X-Greylist: delayed 518 seconds by postgrey-1.27 at vger.kernel.org; Wed, 02 Dec 2020 12:58:41 EST Received: from localhost (localhost [127.0.0.1]) by mail.siol.net (Postfix) with ESMTP id C89AA521022; Wed, 2 Dec 2020 18:49:21 +0100 (CET) X-Virus-Scanned: amavisd-new at psrvmta10.zcs-production.pri Received: from mail.siol.net ([127.0.0.1]) by localhost (psrvmta10.zcs-production.pri [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id CNHRojKcScea; Wed, 2 Dec 2020 18:49:21 +0100 (CET) Received: from mail.siol.net (localhost [127.0.0.1]) by mail.siol.net (Postfix) with ESMTPS id 554F752100D; Wed, 2 Dec 2020 18:49:21 +0100 (CET) Received: from kista.localnet (cpe1-5-97.cable.triera.net [213.161.5.97]) (Authenticated sender: jernej.skrabec@siol.net) by mail.siol.net (Postfix) with ESMTPA id C3319521022; Wed, 2 Dec 2020 18:49:20 +0100 (CET) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: Maxime Ripard , Chen-Yu Tsai , Andre Przywara Cc: Icenowy Zheng , linux-arm-kernel@lists.infradead.org, linux-sunxi@googlegroups.com, Linus Walleij , Rob Herring , Yangtao Li , linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, Andre Przywara Subject: Re: [PATCH 3/8] pinctrl: sunxi: Add support for the Allwinner H616-R pin controller Date: Wed, 02 Dec 2020 18:55:32 +0100 Message-ID: <47263727.bh6W02dunB@kista> In-Reply-To: <20201202135409.13683-4-andre.przywara@arm.com> References: <20201202135409.13683-1-andre.przywara@arm.com> <20201202135409.13683-4-andre.przywara@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org Dne sreda, 02. december 2020 ob 14:54:04 CET je Andre Przywara napisal(a): > There are only two pins left now, used to connect to the PMIC via I2C. > > Signed-off-by: Andre Przywara > --- > drivers/pinctrl/sunxi/Kconfig | 5 ++ > drivers/pinctrl/sunxi/Makefile | 1 + > drivers/pinctrl/sunxi/pinctrl-sun50i-h616-r.c | 58 +++++++++++++++++++ > 3 files changed, 64 insertions(+) > create mode 100644 drivers/pinctrl/sunxi/pinctrl-sun50i-h616-r.c > > diff --git a/drivers/pinctrl/sunxi/Kconfig b/drivers/pinctrl/sunxi/Kconfig > index 73e88ce71a48..33751a6a0757 100644 > --- a/drivers/pinctrl/sunxi/Kconfig > +++ b/drivers/pinctrl/sunxi/Kconfig > @@ -124,4 +124,9 @@ config PINCTRL_SUN50I_H616 > default ARM64 && ARCH_SUNXI > select PINCTRL_SUNXI > > +config PINCTRL_SUN50I_H616_R > + bool "Support for the Allwinner H616 R-PIO" > + default ARM64 && ARCH_SUNXI > + select PINCTRL_SUNXI > + > endif > diff --git a/drivers/pinctrl/sunxi/Makefile b/drivers/pinctrl/sunxi/Makefile > index 5359327a3c8f..d3440c42b9d6 100644 > --- a/drivers/pinctrl/sunxi/Makefile > +++ b/drivers/pinctrl/sunxi/Makefile > @@ -24,5 +24,6 @@ obj-$(CONFIG_PINCTRL_SUN50I_H5) += pinctrl-sun50i-h5.o > obj-$(CONFIG_PINCTRL_SUN50I_H6) += pinctrl-sun50i-h6.o > obj-$(CONFIG_PINCTRL_SUN50I_H6_R) += pinctrl-sun50i-h6-r.o > obj-$(CONFIG_PINCTRL_SUN50I_H616) += pinctrl-sun50i-h616.o > +obj-$(CONFIG_PINCTRL_SUN50I_H616_R) += pinctrl-sun50i-h616-r.o > obj-$(CONFIG_PINCTRL_SUN9I_A80) += pinctrl-sun9i-a80.o > obj-$(CONFIG_PINCTRL_SUN9I_A80_R) += pinctrl-sun9i-a80-r.o > diff --git a/drivers/pinctrl/sunxi/pinctrl-sun50i-h616-r.c b/drivers/pinctrl/ sunxi/pinctrl-sun50i-h616-r.c > new file mode 100644 > index 000000000000..eb76c009bf24 > --- /dev/null > +++ b/drivers/pinctrl/sunxi/pinctrl-sun50i-h616-r.c > @@ -0,0 +1,58 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * Allwinner H616 R_PIO pin controller driver > + * > + * Copyright (C) 2020 Arm Ltd. > + * Based on former work, which is: > + * Copyright (C) 2017 Icenowy Zheng > + * Copyright (C) 2014 Boris Brezillon > + * Boris Brezillon > + * Copyright (C) 2014 Maxime Ripard > + * Maxime Ripard > + */ I'm not sure if it makes sense to reference so many previous work for so simple driver... Anyway: Reviewed-by: Jernej Skrabec Best regards, Jernej > + > +#include > +#include > +#include > +#include > +#include > +#include > + > +#include "pinctrl-sunxi.h" > + > +static const struct sunxi_desc_pin sun50i_h616_r_pins[] = { > + SUNXI_PIN(SUNXI_PINCTRL_PIN(L, 0), > + SUNXI_FUNCTION(0x0, "gpio_in"), > + SUNXI_FUNCTION(0x1, "gpio_out"), > + SUNXI_FUNCTION(0x3, "s_i2c")), /* SCK */ > + SUNXI_PIN(SUNXI_PINCTRL_PIN(L, 1), > + SUNXI_FUNCTION(0x0, "gpio_in"), > + SUNXI_FUNCTION(0x1, "gpio_out"), > + SUNXI_FUNCTION(0x3, "s_i2c")), /* SDA */ > +}; > + > +static const struct sunxi_pinctrl_desc sun50i_h616_r_pinctrl_data = { > + .pins = sun50i_h616_r_pins, > + .npins = ARRAY_SIZE(sun50i_h616_r_pins), > + .pin_base = PL_BASE, > +}; > + > +static int sun50i_h616_r_pinctrl_probe(struct platform_device *pdev) > +{ > + return sunxi_pinctrl_init(pdev, > + &sun50i_h616_r_pinctrl_data); > +} > + > +static const struct of_device_id sun50i_h616_r_pinctrl_match[] = { > + { .compatible = "allwinner,sun50i-h616-r-pinctrl", }, > + {} > +}; > + > +static struct platform_driver sun50i_h616_r_pinctrl_driver = { > + .probe = sun50i_h616_r_pinctrl_probe, > + .driver = { > + .name = "sun50i-h616-r-pinctrl", > + .of_match_table = sun50i_h616_r_pinctrl_match, > + }, > +}; > +builtin_platform_driver(sun50i_h616_r_pinctrl_driver); > -- > 2.17.5 > >