[PATCH 0/2] pinctrl: bcm: Constify static ops structs

linux-gpio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed

* [PATCH 0/2] pinctrl: bcm: Constify static ops structs
@ 2021-06-05 18:59 Rikard Falkeborn
  2021-06-05 18:59 ` [PATCH 1/2] pinctrl: bcm: Constify static pinctrl_ops Rikard Falkeborn
                   ` (2 more replies)
  0 siblings, 3 replies; 6+ messages in thread
From: Rikard Falkeborn @ 2021-06-05 18:59 UTC (permalink / raw)
  To: Linus Walleij, Florian Fainelli, Álvaro Fernández Rojas
  Cc: bcm-kernel-feedback-list, linux-gpio, linux-kernel,
	linux-arm-kernel, Rikard Falkeborn

Constify a number of pinctrl_ops and pinmux_ops that are never modified
to allow the compiler to put them in read-only memory.

Rikard Falkeborn (2):
  pinctrl: bcm: Constify static pinctrl_ops
  pinctrl: bcm: Constify static pinmux_ops

 drivers/pinctrl/bcm/pinctrl-bcm6318.c  | 4 ++--
 drivers/pinctrl/bcm/pinctrl-bcm63268.c | 4 ++--
 drivers/pinctrl/bcm/pinctrl-bcm6328.c  | 4 ++--
 drivers/pinctrl/bcm/pinctrl-bcm6358.c  | 4 ++--
 drivers/pinctrl/bcm/pinctrl-bcm6362.c  | 4 ++--
 drivers/pinctrl/bcm/pinctrl-bcm6368.c  | 4 ++--
 drivers/pinctrl/bcm/pinctrl-bcm63xx.h  | 4 ++--
 7 files changed, 14 insertions(+), 14 deletions(-)

-- 
2.31.1


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH 1/2] pinctrl: bcm: Constify static pinctrl_ops
  2021-06-05 18:59 [PATCH 0/2] pinctrl: bcm: Constify static ops structs Rikard Falkeborn
@ 2021-06-05 18:59 ` Rikard Falkeborn
  2021-06-06  3:35   ` Florian Fainelli
  2021-06-05 18:59 ` [PATCH 2/2] pinctrl: bcm: Constify static pinmux_ops Rikard Falkeborn
  2021-06-09  9:18 ` [PATCH 0/2] pinctrl: bcm: Constify static ops structs Linus Walleij
  2 siblings, 1 reply; 6+ messages in thread
From: Rikard Falkeborn @ 2021-06-05 18:59 UTC (permalink / raw)
  To: Linus Walleij, Florian Fainelli, Álvaro Fernández Rojas
  Cc: bcm-kernel-feedback-list, linux-gpio, linux-kernel,
	linux-arm-kernel, Rikard Falkeborn

These are only assigned, either directly or via the bcm63xx_pinctrl_soc
struct, to the pctlops field in the pinctrl_desc struct and never
modified, so make them const to allow the compiler to put them in
read-only memory.

Signed-off-by: Rikard Falkeborn <rikard.falkeborn@gmail.com>
---
 drivers/pinctrl/bcm/pinctrl-bcm6318.c  | 2 +-
 drivers/pinctrl/bcm/pinctrl-bcm63268.c | 2 +-
 drivers/pinctrl/bcm/pinctrl-bcm6328.c  | 2 +-
 drivers/pinctrl/bcm/pinctrl-bcm6358.c  | 2 +-
 drivers/pinctrl/bcm/pinctrl-bcm6362.c  | 2 +-
 drivers/pinctrl/bcm/pinctrl-bcm6368.c  | 2 +-
 drivers/pinctrl/bcm/pinctrl-bcm63xx.h  | 2 +-
 7 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/drivers/pinctrl/bcm/pinctrl-bcm6318.c b/drivers/pinctrl/bcm/pinctrl-bcm6318.c
index 77fd9b58067d..4f96a285c307 100644
--- a/drivers/pinctrl/bcm/pinctrl-bcm6318.c
+++ b/drivers/pinctrl/bcm/pinctrl-bcm6318.c
@@ -452,7 +452,7 @@ static int bcm6318_gpio_request_enable(struct pinctrl_dev *pctldev,
 	return 0;
 }
 
-static struct pinctrl_ops bcm6318_pctl_ops = {
+static const struct pinctrl_ops bcm6318_pctl_ops = {
 	.dt_free_map = pinctrl_utils_free_map,
 	.dt_node_to_map = pinconf_generic_dt_node_to_map_pin,
 	.get_group_name = bcm6318_pinctrl_get_group_name,
diff --git a/drivers/pinctrl/bcm/pinctrl-bcm63268.c b/drivers/pinctrl/bcm/pinctrl-bcm63268.c
index d4c5fad7fb7d..f1dea4e1c63e 100644
--- a/drivers/pinctrl/bcm/pinctrl-bcm63268.c
+++ b/drivers/pinctrl/bcm/pinctrl-bcm63268.c
@@ -597,7 +597,7 @@ static int bcm63268_gpio_request_enable(struct pinctrl_dev *pctldev,
 	return 0;
 }
 
-static struct pinctrl_ops bcm63268_pctl_ops = {
+static const struct pinctrl_ops bcm63268_pctl_ops = {
 	.dt_free_map = pinctrl_utils_free_map,
 	.dt_node_to_map = pinconf_generic_dt_node_to_map_pin,
 	.get_group_name = bcm63268_pinctrl_get_group_name,
diff --git a/drivers/pinctrl/bcm/pinctrl-bcm6328.c b/drivers/pinctrl/bcm/pinctrl-bcm6328.c
index c9efce600550..fc090a1609d1 100644
--- a/drivers/pinctrl/bcm/pinctrl-bcm6328.c
+++ b/drivers/pinctrl/bcm/pinctrl-bcm6328.c
@@ -358,7 +358,7 @@ static int bcm6328_gpio_request_enable(struct pinctrl_dev *pctldev,
 	return 0;
 }
 
-static struct pinctrl_ops bcm6328_pctl_ops = {
+static const struct pinctrl_ops bcm6328_pctl_ops = {
 	.dt_free_map = pinctrl_utils_free_map,
 	.dt_node_to_map = pinconf_generic_dt_node_to_map_pin,
 	.get_group_name = bcm6328_pinctrl_get_group_name,
diff --git a/drivers/pinctrl/bcm/pinctrl-bcm6358.c b/drivers/pinctrl/bcm/pinctrl-bcm6358.c
index d638578727f3..7b316305eada 100644
--- a/drivers/pinctrl/bcm/pinctrl-bcm6358.c
+++ b/drivers/pinctrl/bcm/pinctrl-bcm6358.c
@@ -303,7 +303,7 @@ static int bcm6358_gpio_request_enable(struct pinctrl_dev *pctldev,
 	return regmap_field_update_bits(priv->overlays, mask, 0);
 }
 
-static struct pinctrl_ops bcm6358_pctl_ops = {
+static const struct pinctrl_ops bcm6358_pctl_ops = {
 	.dt_free_map = pinctrl_utils_free_map,
 	.dt_node_to_map = pinconf_generic_dt_node_to_map_pin,
 	.get_group_name = bcm6358_pinctrl_get_group_name,
diff --git a/drivers/pinctrl/bcm/pinctrl-bcm6362.c b/drivers/pinctrl/bcm/pinctrl-bcm6362.c
index 40ef495b6301..a9e8178268ed 100644
--- a/drivers/pinctrl/bcm/pinctrl-bcm6362.c
+++ b/drivers/pinctrl/bcm/pinctrl-bcm6362.c
@@ -571,7 +571,7 @@ static int bcm6362_gpio_request_enable(struct pinctrl_dev *pctldev,
 	return 0;
 }
 
-static struct pinctrl_ops bcm6362_pctl_ops = {
+static const struct pinctrl_ops bcm6362_pctl_ops = {
 	.dt_free_map = pinctrl_utils_free_map,
 	.dt_node_to_map = pinconf_generic_dt_node_to_map_pin,
 	.get_group_name = bcm6362_pinctrl_get_group_name,
diff --git a/drivers/pinctrl/bcm/pinctrl-bcm6368.c b/drivers/pinctrl/bcm/pinctrl-bcm6368.c
index 838095f9e890..e3739e921f5c 100644
--- a/drivers/pinctrl/bcm/pinctrl-bcm6368.c
+++ b/drivers/pinctrl/bcm/pinctrl-bcm6368.c
@@ -457,7 +457,7 @@ static int bcm6368_gpio_request_enable(struct pinctrl_dev *pctldev,
 	return 0;
 }
 
-static struct pinctrl_ops bcm6368_pctl_ops = {
+static const struct pinctrl_ops bcm6368_pctl_ops = {
 	.dt_free_map = pinctrl_utils_free_map,
 	.dt_node_to_map = pinconf_generic_dt_node_to_map_pin,
 	.get_group_name = bcm6368_pinctrl_get_group_name,
diff --git a/drivers/pinctrl/bcm/pinctrl-bcm63xx.h b/drivers/pinctrl/bcm/pinctrl-bcm63xx.h
index 3bdb50021f1b..c135477ec768 100644
--- a/drivers/pinctrl/bcm/pinctrl-bcm63xx.h
+++ b/drivers/pinctrl/bcm/pinctrl-bcm63xx.h
@@ -12,7 +12,7 @@
 #define BCM63XX_BANK_GPIOS 32
 
 struct bcm63xx_pinctrl_soc {
-	struct pinctrl_ops *pctl_ops;
+	const struct pinctrl_ops *pctl_ops;
 	struct pinmux_ops *pmx_ops;
 
 	const struct pinctrl_pin_desc *pins;
-- 
2.31.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH 1/2] pinctrl: bcm: Constify static pinctrl_ops
  2021-06-05 18:59 ` [PATCH 1/2] pinctrl: bcm: Constify static pinctrl_ops Rikard Falkeborn
@ 2021-06-06  3:35   ` Florian Fainelli
  0 siblings, 0 replies; 6+ messages in thread
From: Florian Fainelli @ 2021-06-06  3:35 UTC (permalink / raw)
  To: Rikard Falkeborn, Linus Walleij, Florian Fainelli,
	Álvaro Fernández Rojas
  Cc: bcm-kernel-feedback-list, linux-gpio, linux-kernel,
	linux-arm-kernel



On 6/5/2021 11:59 AM, Rikard Falkeborn wrote:
> These are only assigned, either directly or via the bcm63xx_pinctrl_soc
> struct, to the pctlops field in the pinctrl_desc struct and never
> modified, so make them const to allow the compiler to put them in
> read-only memory.
> 
> Signed-off-by: Rikard Falkeborn <rikard.falkeborn@gmail.com>

Acked-by: Florian Fainelli <f.fainelli@gmail.com>
-- 
Florian

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH 2/2] pinctrl: bcm: Constify static pinmux_ops
  2021-06-05 18:59 [PATCH 0/2] pinctrl: bcm: Constify static ops structs Rikard Falkeborn
  2021-06-05 18:59 ` [PATCH 1/2] pinctrl: bcm: Constify static pinctrl_ops Rikard Falkeborn
@ 2021-06-05 18:59 ` Rikard Falkeborn
  2021-06-06  3:36   ` Florian Fainelli
  2021-06-09  9:18 ` [PATCH 0/2] pinctrl: bcm: Constify static ops structs Linus Walleij
  2 siblings, 1 reply; 6+ messages in thread
From: Rikard Falkeborn @ 2021-06-05 18:59 UTC (permalink / raw)
  To: Linus Walleij, Florian Fainelli, Álvaro Fernández Rojas
  Cc: bcm-kernel-feedback-list, linux-gpio, linux-kernel,
	linux-arm-kernel, Rikard Falkeborn

These are only assigned, either directly or via the bcm63xx_pinctrl_soc
struct, to the pmxops field in the pinctrl_desc struct and never
modified, so make them const to allow the compiler to put them in
read-only memory.

Signed-off-by: Rikard Falkeborn <rikard.falkeborn@gmail.com>
---
 drivers/pinctrl/bcm/pinctrl-bcm6318.c  | 2 +-
 drivers/pinctrl/bcm/pinctrl-bcm63268.c | 2 +-
 drivers/pinctrl/bcm/pinctrl-bcm6328.c  | 2 +-
 drivers/pinctrl/bcm/pinctrl-bcm6358.c  | 2 +-
 drivers/pinctrl/bcm/pinctrl-bcm6362.c  | 2 +-
 drivers/pinctrl/bcm/pinctrl-bcm6368.c  | 2 +-
 drivers/pinctrl/bcm/pinctrl-bcm63xx.h  | 2 +-
 7 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/drivers/pinctrl/bcm/pinctrl-bcm6318.c b/drivers/pinctrl/bcm/pinctrl-bcm6318.c
index 4f96a285c307..9311220fb6cb 100644
--- a/drivers/pinctrl/bcm/pinctrl-bcm6318.c
+++ b/drivers/pinctrl/bcm/pinctrl-bcm6318.c
@@ -460,7 +460,7 @@ static const struct pinctrl_ops bcm6318_pctl_ops = {
 	.get_groups_count = bcm6318_pinctrl_get_group_count,
 };
 
-static struct pinmux_ops bcm6318_pmx_ops = {
+static const struct pinmux_ops bcm6318_pmx_ops = {
 	.get_function_groups = bcm6318_pinctrl_get_groups,
 	.get_function_name = bcm6318_pinctrl_get_func_name,
 	.get_functions_count = bcm6318_pinctrl_get_func_count,
diff --git a/drivers/pinctrl/bcm/pinctrl-bcm63268.c b/drivers/pinctrl/bcm/pinctrl-bcm63268.c
index f1dea4e1c63e..1c1060a39597 100644
--- a/drivers/pinctrl/bcm/pinctrl-bcm63268.c
+++ b/drivers/pinctrl/bcm/pinctrl-bcm63268.c
@@ -605,7 +605,7 @@ static const struct pinctrl_ops bcm63268_pctl_ops = {
 	.get_groups_count = bcm63268_pinctrl_get_group_count,
 };
 
-static struct pinmux_ops bcm63268_pmx_ops = {
+static const struct pinmux_ops bcm63268_pmx_ops = {
 	.get_function_groups = bcm63268_pinctrl_get_groups,
 	.get_function_name = bcm63268_pinctrl_get_func_name,
 	.get_functions_count = bcm63268_pinctrl_get_func_count,
diff --git a/drivers/pinctrl/bcm/pinctrl-bcm6328.c b/drivers/pinctrl/bcm/pinctrl-bcm6328.c
index fc090a1609d1..ffa8864abab6 100644
--- a/drivers/pinctrl/bcm/pinctrl-bcm6328.c
+++ b/drivers/pinctrl/bcm/pinctrl-bcm6328.c
@@ -366,7 +366,7 @@ static const struct pinctrl_ops bcm6328_pctl_ops = {
 	.get_groups_count = bcm6328_pinctrl_get_group_count,
 };
 
-static struct pinmux_ops bcm6328_pmx_ops = {
+static const struct pinmux_ops bcm6328_pmx_ops = {
 	.get_function_groups = bcm6328_pinctrl_get_groups,
 	.get_function_name = bcm6328_pinctrl_get_func_name,
 	.get_functions_count = bcm6328_pinctrl_get_func_count,
diff --git a/drivers/pinctrl/bcm/pinctrl-bcm6358.c b/drivers/pinctrl/bcm/pinctrl-bcm6358.c
index 7b316305eada..9f6cd7447887 100644
--- a/drivers/pinctrl/bcm/pinctrl-bcm6358.c
+++ b/drivers/pinctrl/bcm/pinctrl-bcm6358.c
@@ -311,7 +311,7 @@ static const struct pinctrl_ops bcm6358_pctl_ops = {
 	.get_groups_count = bcm6358_pinctrl_get_group_count,
 };
 
-static struct pinmux_ops bcm6358_pmx_ops = {
+static const struct pinmux_ops bcm6358_pmx_ops = {
 	.get_function_groups = bcm6358_pinctrl_get_groups,
 	.get_function_name = bcm6358_pinctrl_get_func_name,
 	.get_functions_count = bcm6358_pinctrl_get_func_count,
diff --git a/drivers/pinctrl/bcm/pinctrl-bcm6362.c b/drivers/pinctrl/bcm/pinctrl-bcm6362.c
index a9e8178268ed..13c7230949b2 100644
--- a/drivers/pinctrl/bcm/pinctrl-bcm6362.c
+++ b/drivers/pinctrl/bcm/pinctrl-bcm6362.c
@@ -579,7 +579,7 @@ static const struct pinctrl_ops bcm6362_pctl_ops = {
 	.get_groups_count = bcm6362_pinctrl_get_group_count,
 };
 
-static struct pinmux_ops bcm6362_pmx_ops = {
+static const struct pinmux_ops bcm6362_pmx_ops = {
 	.get_function_groups = bcm6362_pinctrl_get_groups,
 	.get_function_name = bcm6362_pinctrl_get_func_name,
 	.get_functions_count = bcm6362_pinctrl_get_func_count,
diff --git a/drivers/pinctrl/bcm/pinctrl-bcm6368.c b/drivers/pinctrl/bcm/pinctrl-bcm6368.c
index e3739e921f5c..b33a74aec82b 100644
--- a/drivers/pinctrl/bcm/pinctrl-bcm6368.c
+++ b/drivers/pinctrl/bcm/pinctrl-bcm6368.c
@@ -465,7 +465,7 @@ static const struct pinctrl_ops bcm6368_pctl_ops = {
 	.get_groups_count = bcm6368_pinctrl_get_group_count,
 };
 
-static struct pinmux_ops bcm6368_pmx_ops = {
+static const struct pinmux_ops bcm6368_pmx_ops = {
 	.get_function_groups = bcm6368_pinctrl_get_groups,
 	.get_function_name = bcm6368_pinctrl_get_func_name,
 	.get_functions_count = bcm6368_pinctrl_get_func_count,
diff --git a/drivers/pinctrl/bcm/pinctrl-bcm63xx.h b/drivers/pinctrl/bcm/pinctrl-bcm63xx.h
index c135477ec768..d58c8cd5b6b8 100644
--- a/drivers/pinctrl/bcm/pinctrl-bcm63xx.h
+++ b/drivers/pinctrl/bcm/pinctrl-bcm63xx.h
@@ -13,7 +13,7 @@
 
 struct bcm63xx_pinctrl_soc {
 	const struct pinctrl_ops *pctl_ops;
-	struct pinmux_ops *pmx_ops;
+	const struct pinmux_ops *pmx_ops;
 
 	const struct pinctrl_pin_desc *pins;
 	unsigned npins;
-- 
2.31.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH 2/2] pinctrl: bcm: Constify static pinmux_ops
  2021-06-05 18:59 ` [PATCH 2/2] pinctrl: bcm: Constify static pinmux_ops Rikard Falkeborn
@ 2021-06-06  3:36   ` Florian Fainelli
  0 siblings, 0 replies; 6+ messages in thread
From: Florian Fainelli @ 2021-06-06  3:36 UTC (permalink / raw)
  To: Rikard Falkeborn, Linus Walleij, Florian Fainelli,
	Álvaro Fernández Rojas
  Cc: bcm-kernel-feedback-list, linux-gpio, linux-kernel,
	linux-arm-kernel



On 6/5/2021 11:59 AM, Rikard Falkeborn wrote:
> These are only assigned, either directly or via the bcm63xx_pinctrl_soc
> struct, to the pmxops field in the pinctrl_desc struct and never
> modified, so make them const to allow the compiler to put them in
> read-only memory.
> 
> Signed-off-by: Rikard Falkeborn <rikard.falkeborn@gmail.com>

Acked-by: Florian Fainelli <f.fainelli@gmail.com>
-- 
Florian

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 0/2] pinctrl: bcm: Constify static ops structs
  2021-06-05 18:59 [PATCH 0/2] pinctrl: bcm: Constify static ops structs Rikard Falkeborn
  2021-06-05 18:59 ` [PATCH 1/2] pinctrl: bcm: Constify static pinctrl_ops Rikard Falkeborn
  2021-06-05 18:59 ` [PATCH 2/2] pinctrl: bcm: Constify static pinmux_ops Rikard Falkeborn
@ 2021-06-09  9:18 ` Linus Walleij
  2 siblings, 0 replies; 6+ messages in thread
From: Linus Walleij @ 2021-06-09  9:18 UTC (permalink / raw)
  To: Rikard Falkeborn
  Cc: Florian Fainelli, Álvaro Fernández Rojas,
	bcm-kernel-feedback-list, open list:GPIO SUBSYSTEM, linux-kernel,
	Linux ARM

On Sat, Jun 5, 2021 at 8:59 PM Rikard Falkeborn
<rikard.falkeborn@gmail.com> wrote:

> Constify a number of pinctrl_ops and pinmux_ops that are never modified
> to allow the compiler to put them in read-only memory.

Patches applied!

Yours,
Linus Walleij

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2021-06-09  9:19 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-06-05 18:59 [PATCH 0/2] pinctrl: bcm: Constify static ops structs Rikard Falkeborn
2021-06-05 18:59 ` [PATCH 1/2] pinctrl: bcm: Constify static pinctrl_ops Rikard Falkeborn
2021-06-06  3:35   ` Florian Fainelli
2021-06-05 18:59 ` [PATCH 2/2] pinctrl: bcm: Constify static pinmux_ops Rikard Falkeborn
2021-06-06  3:36   ` Florian Fainelli
2021-06-09  9:18 ` [PATCH 0/2] pinctrl: bcm: Constify static ops structs Linus Walleij

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).