* [PATCH] pinctrl: sh-pfc: use a saner Kconfig symbol
@ 2014-08-29 12:51 Linus Walleij
2014-08-31 17:22 ` Laurent Pinchart
0 siblings, 1 reply; 2+ messages in thread
From: Linus Walleij @ 2014-08-29 12:51 UTC (permalink / raw)
To: Laurent Pinchart, linux-kernel, linux-arm-kernel
Cc: linux-gpio, Linus Walleij, Laurent Pinchart
There is currently a kludge to get the Makefile to move down
to sh-pfc:s drivers: the arch definitions are used twice to
get it done. However we can very well use the Kconfig symbol
for the SH PFC pin control feature itself: it doesn't matter
that it comes from a lower leaf in the Kconfig hierarchy which
is completely orthogonal.
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
drivers/pinctrl/Makefile | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/pinctrl/Makefile b/drivers/pinctrl/Makefile
index 7ebb3c5a9c30..0ffe1f608c67 100644
--- a/drivers/pinctrl/Makefile
+++ b/drivers/pinctrl/Makefile
@@ -60,8 +60,7 @@ obj-$(CONFIG_PLAT_ORION) += mvebu/
obj-y += nomadik/
obj-$(CONFIG_ARCH_QCOM) += qcom/
obj-$(CONFIG_PINCTRL_SAMSUNG) += samsung/
-obj-$(CONFIG_ARCH_SHMOBILE) += sh-pfc/
-obj-$(CONFIG_SUPERH) += sh-pfc/
+obj-$(CONFIG_PINCTRL_SH_PFC) += sh-pfc/
obj-$(CONFIG_PLAT_SPEAR) += spear/
obj-$(CONFIG_ARCH_SUNXI) += sunxi/
obj-$(CONFIG_ARCH_VT8500) += vt8500/
--
1.9.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] pinctrl: sh-pfc: use a saner Kconfig symbol
2014-08-29 12:51 [PATCH] pinctrl: sh-pfc: use a saner Kconfig symbol Linus Walleij
@ 2014-08-31 17:22 ` Laurent Pinchart
0 siblings, 0 replies; 2+ messages in thread
From: Laurent Pinchart @ 2014-08-31 17:22 UTC (permalink / raw)
To: Linus Walleij; +Cc: linux-kernel, linux-arm-kernel, linux-gpio
Hi Linus,
Thank you for the patch.
On Friday 29 August 2014 14:51:59 Linus Walleij wrote:
> There is currently a kludge to get the Makefile to move down
> to sh-pfc:s drivers: the arch definitions are used twice to
> get it done. However we can very well use the Kconfig symbol
> for the SH PFC pin control feature itself: it doesn't matter
> that it comes from a lower leaf in the Kconfig hierarchy which
> is completely orthogonal.
>
> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> drivers/pinctrl/Makefile | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/pinctrl/Makefile b/drivers/pinctrl/Makefile
> index 7ebb3c5a9c30..0ffe1f608c67 100644
> --- a/drivers/pinctrl/Makefile
> +++ b/drivers/pinctrl/Makefile
> @@ -60,8 +60,7 @@ obj-$(CONFIG_PLAT_ORION) += mvebu/
> obj-y += nomadik/
> obj-$(CONFIG_ARCH_QCOM) += qcom/
> obj-$(CONFIG_PINCTRL_SAMSUNG) += samsung/
> -obj-$(CONFIG_ARCH_SHMOBILE) += sh-pfc/
> -obj-$(CONFIG_SUPERH) += sh-pfc/
> +obj-$(CONFIG_PINCTRL_SH_PFC) += sh-pfc/
> obj-$(CONFIG_PLAT_SPEAR) += spear/
> obj-$(CONFIG_ARCH_SUNXI) += sunxi/
> obj-$(CONFIG_ARCH_VT8500) += vt8500/
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-08-31 18:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-08-29 12:51 [PATCH] pinctrl: sh-pfc: use a saner Kconfig symbol Linus Walleij
2014-08-31 17:22 ` Laurent Pinchart
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).