From: Heiko Stuebner <heiko@sntech.de>
To: "Linus Walleij" <linus.walleij@linaro.org>,
"Bartosz Golaszewski" <brgl@bgdev.pl>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Andy Shevchenko <andy@kernel.org>,
linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 16/23] gpio: rockchip: Convert to platform remove callback returning void
Date: Mon, 02 Oct 2023 00:45:50 +0200 [thread overview]
Message-ID: <4863315.31r3eYUQgx@phil> (raw)
In-Reply-To: <20230928070706.2290137-17-u.kleine-koenig@pengutronix.de>
Am Donnerstag, 28. September 2023, 09:06:59 CEST schrieb Uwe Kleine-König:
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is ignored (apart
> from emitting a warning) and this typically results in resource leaks.
>
> To improve here there is a quest to make the remove callback return
> void. In the first step of this quest all drivers are converted to
> .remove_new(), which already returns void. Eventually after all drivers
> are converted, .remove_new() will be renamed to .remove().
>
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: Heiko Stuebner <heiko@sntech.de>
next prev parent reply other threads:[~2023-10-01 22:45 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-28 7:06 [PATCH 00/23] gpio: Convert to platform remove callback returning void Uwe Kleine-König
2023-09-28 7:06 ` [PATCH 01/23] gpio: altera: " Uwe Kleine-König
2023-09-28 7:06 ` [PATCH 02/23] gpio: amdpt: " Uwe Kleine-König
2023-09-28 7:06 ` [PATCH 03/23] gpio: brcmstb: " Uwe Kleine-König
2023-09-28 21:22 ` Florian Fainelli
2023-09-28 7:06 ` [PATCH 04/23] gpio: cadence: " Uwe Kleine-König
2023-09-28 7:06 ` [PATCH 05/23] gpio: dln2: " Uwe Kleine-König
2023-09-28 7:06 ` [PATCH 06/23] gpio: ftgpio010: " Uwe Kleine-König
2023-09-28 7:06 ` [PATCH 07/23] gpio: grgpio: " Uwe Kleine-König
2023-09-28 7:06 ` [PATCH 08/23] gpio: ljca: " Uwe Kleine-König
2023-09-28 7:06 ` [PATCH 09/23] gpio: lpc18xx: " Uwe Kleine-König
2023-09-28 7:06 ` [PATCH 10/23] gpio: mb86s7x: " Uwe Kleine-König
2023-09-28 7:06 ` [PATCH 11/23] gpio: mm-lantiq: " Uwe Kleine-König
2023-09-28 7:06 ` [PATCH 12/23] gpio: mpc5200: " Uwe Kleine-König
2023-09-28 7:06 ` [PATCH 13/23] gpio: mpc8xxx: " Uwe Kleine-König
2023-09-28 7:06 ` [PATCH 14/23] gpio: omap: " Uwe Kleine-König
2023-09-28 7:06 ` [PATCH 15/23] gpio: rcar: " Uwe Kleine-König
2023-09-28 7:06 ` [PATCH 16/23] gpio: rockchip: " Uwe Kleine-König
2023-10-01 22:45 ` Heiko Stuebner [this message]
2023-09-28 7:07 ` [PATCH 17/23] gpio: tb10x: " Uwe Kleine-König
2023-09-28 7:07 ` [PATCH 18/23] gpio: ts5500: " Uwe Kleine-König
2023-09-28 7:07 ` [PATCH 19/23] gpio: uniphier: " Uwe Kleine-König
2023-09-28 7:07 ` [PATCH 20/23] gpio: xgene-sb: " Uwe Kleine-König
2023-09-28 7:07 ` [PATCH 21/23] gpio: xgs-iproc: " Uwe Kleine-König
2023-09-28 21:22 ` Florian Fainelli
2023-09-28 7:07 ` [PATCH 22/23] gpio: xilinx: " Uwe Kleine-König
2023-09-28 8:32 ` Datta, Shubhrajyoti
2023-09-28 7:07 ` [PATCH 23/23] gpio: zynq: " Uwe Kleine-König
2023-09-28 21:54 ` [PATCH 00/23] gpio: " Linus Walleij
2023-10-02 6:52 ` Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4863315.31r3eYUQgx@phil \
--to=heiko@sntech.de \
--cc=andy@kernel.org \
--cc=brgl@bgdev.pl \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).