From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 10D8CC7EE23 for ; Sun, 4 Jun 2023 17:09:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231355AbjFDRJT (ORCPT ); Sun, 4 Jun 2023 13:09:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55602 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229788AbjFDRJS (ORCPT ); Sun, 4 Jun 2023 13:09:18 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 18BC2B7 for ; Sun, 4 Jun 2023 10:08:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1685898516; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PdD6fLCgV2aQnBd7dmmJ3kgTXzpNFEeCf0r/5R17D2M=; b=GcigC972vpXjsLcfGwjKVD955u9F0ZdS5VI8wK4E45bTslZ2/RMSAyg4JZEB2losNQUPfs jhU8sv27pZCBcEp7N59FZQiOmHReH1GgA7dHarH4XwwJxBg0tzrhG1l2W+GInLWCTZUpRQ AnLW9T34xOLWyU5Y3yBUmLepNnsRcYo= Received: from mail-ej1-f72.google.com (mail-ej1-f72.google.com [209.85.218.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-622-VpZReZ_IMjCqsyVhzuaRAA-1; Sun, 04 Jun 2023 13:08:35 -0400 X-MC-Unique: VpZReZ_IMjCqsyVhzuaRAA-1 Received: by mail-ej1-f72.google.com with SMTP id a640c23a62f3a-94a35b0d4ceso283320466b.3 for ; Sun, 04 Jun 2023 10:08:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685898514; x=1688490514; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=PdD6fLCgV2aQnBd7dmmJ3kgTXzpNFEeCf0r/5R17D2M=; b=WY5TmV3oufz4nbKRlpfus6dM32vxmvKC2lVLVXGpcb3tIqdJqxp7QRi3aK24D4NCVn MjLaXf1eV+1o1C9GxHy+Y9PEs8pIMoLdVyrYlb2B5yOMCNIy4DL8z8EFQGUTaB0SmAry inMLhugUuUzkhoGzVQG499035frXoW830WtrT4+PWdYOzYcHWfSflLvYHLy309u+vAr6 oN7aHAbMU+lrvqKPK77lFXnwB1jJnTEHeEY5xybLW5DOKwdY995KtB4/34gmodg4BQB3 pTBgDxA4B65i8zvMEWXdIT/E9B1kMe7B+n26pDX4WY2oMeH/Su8CyQ3ZEuyrbqstrIls Z32Q== X-Gm-Message-State: AC+VfDx+AXkCMwYiL8GL2mrkGF9YZEorWTjRP5rH9FsKjiSvPBngqBCZ kskATx8yBkve0Qfv2uFI4H6LYSGEogV5TJ7KPMmlj+uracH9w+iOa4fqcZOlshG3r4seQlAOM5S xWb2AwBCVljxfDK2mUM5pJw== X-Received: by 2002:a17:907:168a:b0:967:21:5887 with SMTP id hc10-20020a170907168a00b0096700215887mr4095491ejc.40.1685898513855; Sun, 04 Jun 2023 10:08:33 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4TPZilX3j01WIYfIYhahPcl8kTB8RkUD2ANGHMSpVRbwGGQb9vu22ijVQ0bzecqOBy+9DBTQ== X-Received: by 2002:a17:907:168a:b0:967:21:5887 with SMTP id hc10-20020a170907168a00b0096700215887mr4095470ejc.40.1685898513516; Sun, 04 Jun 2023 10:08:33 -0700 (PDT) Received: from ?IPV6:2001:1c00:c32:7800:5bfa:a036:83f0:f9ec? (2001-1c00-0c32-7800-5bfa-a036-83f0-f9ec.cable.dynamic.v6.ziggo.nl. [2001:1c00:c32:7800:5bfa:a036:83f0:f9ec]) by smtp.gmail.com with ESMTPSA id j24-20020a170906095800b009659fa6eeddsm3269450ejd.196.2023.06.04.10.08.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 04 Jun 2023 10:08:32 -0700 (PDT) Message-ID: <48a267c4-15c5-4ab6-7704-f7ee41e2fb90@redhat.com> Date: Sun, 4 Jun 2023 19:08:31 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH v4 4/4] platform/x86/amd: pmc: Use pm_pr_dbg() for suspend related messages To: Mario Limonciello , Rafael Wysocki , linus.walleij@linaro.org Cc: linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org, linux-gpio@vger.kernel.org, linux-pm@vger.kernel.org, Basavaraj.Natikar@amd.com, Shyam-sundar.S-k@amd.com References: <20230602073025.22884-1-mario.limonciello@amd.com> <20230602073025.22884-4-mario.limonciello@amd.com> Content-Language: en-US, nl From: Hans de Goede In-Reply-To: <20230602073025.22884-4-mario.limonciello@amd.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org Hi, On 6/2/23 09:30, Mario Limonciello wrote: > Using pm_pr_dbg() allows users to toggle `/sys/power/pm_debug_messages` > as a single knob to turn on messages that amd-pmc can emit to aid in > any s2idle debugging. > > Signed-off-by: Mario Limonciello Thanks, patch looks good to me. Here is my ack for merging this through the linux-pm tree: Acked-by: Hans de Goede Regards, Hans > --- > drivers/platform/x86/amd/pmc.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/platform/x86/amd/pmc.c b/drivers/platform/x86/amd/pmc.c > index 427905714f79..1304cd6f13f6 100644 > --- a/drivers/platform/x86/amd/pmc.c > +++ b/drivers/platform/x86/amd/pmc.c > @@ -543,7 +543,7 @@ static int amd_pmc_idlemask_read(struct amd_pmc_dev *pdev, struct device *dev, > } > > if (dev) > - dev_dbg(pdev->dev, "SMU idlemask s0i3: 0x%x\n", val); > + pm_pr_dbg("SMU idlemask s0i3: 0x%x\n", val); > > if (s) > seq_printf(s, "SMU idlemask : 0x%x\n", val); > @@ -769,7 +769,7 @@ static int amd_pmc_verify_czn_rtc(struct amd_pmc_dev *pdev, u32 *arg) > > *arg |= (duration << 16); > rc = rtc_alarm_irq_enable(rtc_device, 0); > - dev_dbg(pdev->dev, "wakeup timer programmed for %lld seconds\n", duration); > + pm_pr_dbg("wakeup timer programmed for %lld seconds\n", duration); > > return rc; > }