From: Sean Anderson <seanga2@gmail.com>
To: Damien Le Moal <damien.lemoal@opensource.wdc.com>,
Linus Walleij <linus.walleij@linaro.org>,
linux-gpio@vger.kernel.org
Cc: linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org,
Dan Carpenter <dan.carpenter@oracle.com>
Subject: Re: [PATCH] pinctrl: k210: Fix bias-pull-up
Date: Wed, 9 Feb 2022 18:52:11 -0500 [thread overview]
Message-ID: <4911f3a7-fe4b-8eb0-f504-667ee5ea1294@gmail.com> (raw)
In-Reply-To: <fb3e9786-87e9-6346-cf84-2617adfa5b8d@opensource.wdc.com>
On 2/9/22 6:34 PM, Damien Le Moal wrote:
> On 2/10/22 03:28, Sean Anderson wrote:
>> Using bias-pull-up would actually cause the pin to have its pull-down
>> enabled. Fix this.
>>
>> Signed-off-by: Sean Anderson <seanga2@gmail.com>
>> ---
>>
>> drivers/pinctrl/pinctrl-k210.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/pinctrl/pinctrl-k210.c b/drivers/pinctrl/pinctrl-k210.c
>> index 49e32684dbb2..1ad61b32ec88 100644
>> --- a/drivers/pinctrl/pinctrl-k210.c
>> +++ b/drivers/pinctrl/pinctrl-k210.c
>> @@ -527,7 +527,7 @@ static int k210_pinconf_set_param(struct pinctrl_dev *pctldev,
>> case PIN_CONFIG_BIAS_PULL_UP:
>> if (!arg)
>> return -EINVAL;
>> - val |= K210_PC_PD;
>> + val |= K210_PC_PU;
>> break;
>> case PIN_CONFIG_DRIVE_STRENGTH:
>> arg *= 1000;
>
> Ooops... My bad :)
(This is in U-Boot as well, so it looks like it's my bad)
next prev parent reply other threads:[~2022-02-10 1:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-09 18:28 [PATCH] pinctrl: k210: Fix bias-pull-up Sean Anderson
2022-02-09 18:29 ` Sean Anderson
2022-02-09 23:34 ` Damien Le Moal
2022-02-09 23:52 ` Sean Anderson [this message]
2022-02-09 23:59 ` Damien Le Moal
2022-02-11 1:20 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4911f3a7-fe4b-8eb0-f504-667ee5ea1294@gmail.com \
--to=seanga2@gmail.com \
--cc=damien.lemoal@opensource.wdc.com \
--cc=dan.carpenter@oracle.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).