From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-io1-f49.google.com (mail-io1-f49.google.com [209.85.166.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D74B319ABD8 for ; Tue, 25 Mar 2025 21:19:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742937585; cv=none; b=eqEg9ZCkK7Kw3cYZkJKxrSj9EhjkcjwNGMaaFXghfHY2iqHMgTl0WwbK5evR+gtBn6hr6GDBvCdShsqeDRrYJpZ/bY5qRUerwWg3l6Ads3w6+uQ5lxffQBcKwNfsS3zWc3jLHfQWMRoDzUoFEakDWt0KGSCfQevZIfI6DNmolwI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742937585; c=relaxed/simple; bh=NQnbD776Zb8ERF4HsMHcXnwkS/TO5s/52zWgVm5NNQs=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=WGn4eBOB4PD9zuxtvcrZWP0t2mG7HJbjiCfyKHOanarS/h6KcWSbOSH4FXbhO7xH8UfDUujUwlupYJgiVV+n5oRV/X4811Q0PVkWukOE49ZVyrEQPQ0MkaiF+jRWheV+XnIZTyHWBdzu7zY01peuXM7UwTlUpRjWoTGkKkMky7Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=sifive.com; spf=pass smtp.mailfrom=sifive.com; dkim=pass (2048-bit key) header.d=sifive.com header.i=@sifive.com header.b=ghwJKhCT; arc=none smtp.client-ip=209.85.166.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=sifive.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sifive.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=sifive.com header.i=@sifive.com header.b="ghwJKhCT" Received: by mail-io1-f49.google.com with SMTP id ca18e2360f4ac-85e73f7ba09so45951139f.3 for ; Tue, 25 Mar 2025 14:19:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; t=1742937583; x=1743542383; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=mKG8KtS1PtfoFoAQY05FHNouuuEBpDMQ8ANK42hHsEk=; b=ghwJKhCTXyRH2muFJhSV27I5BgoFf4RiIMZmSRLr7Q1Xk3yBt8SJTfVibbuC32YsRU Z38S6RKL2eyxecuGDU372y3mEXSNog5lZwWpM2rS3gmtdyZYUgMZa3/CSPNbRRR0+Ove 75mRkDkaGLUO4KPgNZVNUvBGRL+dGmFPxz2pQWf5K4HalCB7cdq766NfbOw+NnK/BE97 AcDJ1KnuH13PxiWU/4zY24bCOdvKE6tr/hZaz4tE+QKfDZuaJHNXNxcH2Y+qXZJo2vSh mVBdJdW3Bg6FV2zoAsxTcNtC7Qh3vY1D8TadKDERNVuq+14LYaVdTFnnptuR/odiFST6 /F5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742937583; x=1743542383; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=mKG8KtS1PtfoFoAQY05FHNouuuEBpDMQ8ANK42hHsEk=; b=PDUndR93+W6EdjfD5dOo3su93VfvB+jCLx6/7bXG/M3Z7CWtIVCvdNpLK1MixEAoq4 CDJnNhd+v/Rl0RZfzNTfdNjzd9mTZkqsnCe4VXHj16G8lPnStmq6EycCDnPO3sbeq11W SYYgRguUvfMqrS91vaWZXKviNcccI2aB7Wee+TVmsi1ruhY4YVgSlf5KNU0FVhDmkUXD EThXPJti5jNLeyY0hI72dCFe8EaUS8onMAbFm5LjNo2eTp3CLcvywrpulLI826dIjDJ8 gA8faSzIndwv1b1iYk3WSmh5G+P3ie4vIOeSAzFmfW/lQitrjGLtdEYfTIhRQpGA3AyU u/8Q== X-Forwarded-Encrypted: i=1; AJvYcCXCzkWB1yqz3b7on2CCEOx8iHC9GfhHeS7QC7k9fdQVZirl8SLoWQ8KvXlDNrwwRGbCYFYTdlMrfcyW@vger.kernel.org X-Gm-Message-State: AOJu0Yzcqpb5+FvAhA50LdCyyCU14yNoaLjphGlnIDl5RxLeupv1p568 +TL/2px0eQ4kR6IEfM7h+CA4x5sHtqzyLc3QWdeD6BSGJUQs/9nkUplHggY6HWY= X-Gm-Gg: ASbGncsWkmykrIbf5yGnWbvLvqw3C1n3qLCm1SPfsMwkk91Vvc/Kc/9F5xQ40qkWPym JTfNFFRsyXzaKf7frltwUwUHZivbr5nHeqPlVoAZTsKiMVL+S+z1KlZL8ZrBrDR6aOV0W8fraDR 1MzCTogkXz5Pnjq44g752mQrB5Or1EC8YELzJSc+HVS82JHVGtLeybaHs43Gj64fkmGTdIApnJU 4rxkVGJeaLHcGq0Wf0FrtzPy6/+t3pCY2prZsXxAzeSpWeDzdGnEKUmt9vFgGVKVJVb3dTlLN7d sqbKoUHjgM1nMaZ+n2HwBDg6y2LUnjjeQm4f5LByXRvevbug5AwVgSragcy2+w== X-Google-Smtp-Source: AGHT+IFJ9ei+dbxpqumX89NY7ke1+osmRH5g+C2Bjhwac4EqYyI6bFrpBXPDDYMUEUIaTXB7SW5t8w== X-Received: by 2002:a6b:6806:0:b0:85e:2e53:ed27 with SMTP id ca18e2360f4ac-85e2e53f5e9mr1462507639f.3.1742937582760; Tue, 25 Mar 2025 14:19:42 -0700 (PDT) Received: from [100.64.0.1] ([170.85.6.166]) by smtp.gmail.com with ESMTPSA id 8926c6da1cb9f-4f2cbed215asm2531270173.136.2025.03.25.14.19.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 25 Mar 2025 14:19:42 -0700 (PDT) Message-ID: <4a45df45-b2b1-4da9-b829-c5310cf32b5f@sifive.com> Date: Tue, 25 Mar 2025 16:19:40 -0500 Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH 0/4] ESWIN EIC7700 pinctrl driver To: Emil Renner Berthing , Pinkesh Vaghela , Pritesh Patel , Min Lin Cc: Linus Walleij , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Paul Walmsley , Palmer Dabbelt , Alexandre Ghiti , Bartosz Golaszewski , linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, =?UTF-8?B?6bKB546J5p6X?= , =?UTF-8?B?5a6B5a6H?= , Lin Feng References: <20250325141311.758787-1-emil.renner.berthing@canonical.com> From: Samuel Holland Content-Language: en-US In-Reply-To: <20250325141311.758787-1-emil.renner.berthing@canonical.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi Emil, On 2025-03-25 9:13 AM, Emil Renner Berthing wrote: > Hi Pinkesh et. al > > It's great to see you've begun upstreaming support for the EIC7700. I > read some of the data sheet for the SoC and noticed the pinctrl is quite > simple and could benefit from using the same model as the TH1520 pinctrl > driver. This version should do the same as the vendor driver, but in > less than 2/3 the code. > > I hope you'll consider switching to this version once the basic > support[1] lands. This patchset also depends on that series. Thanks for your efforts here. We are working with ESWIN (CCed) to simplify and prepare their driver for upstreaming, and we have ended up with something similar to what you include here. We were hoping to send out a first version of the driver soon. There are still some differences between the two drivers, so ideally we can coordinate on which series to move forward with. Regards, Samuel > [1]: https://lore.kernel.org/all/20250320105449.2094192-1-pinkesh.vaghela@einfochips.com/ > > Emil Renner Berthing (4): > dt-bindings: pinctrl: Add eswin,eic7700-pinctrl binding > pinctrl: Add driver for the ESWIN EIC7700 RISC-V SoC > riscv: dts: Add EIC7700 pin controller node > riscv: dts: eswin: Add HiFive Premier UART pin control > > .../pinctrl/eswin,eic7700-pinctrl.yaml | 141 +++ > .../dts/eswin/eic7700-hifive-premier-p550.dts | 46 + > arch/riscv/boot/dts/eswin/eic7700.dtsi | 17 + > drivers/pinctrl/Kconfig | 14 + > drivers/pinctrl/Makefile | 1 + > drivers/pinctrl/pinctrl-eic7700.c | 802 ++++++++++++++++++ > 6 files changed, 1021 insertions(+) > create mode 100644 Documentation/devicetree/bindings/pinctrl/eswin,eic7700-pinctrl.yaml > create mode 100644 drivers/pinctrl/pinctrl-eic7700.c > > > base-commit: 38fec10eb60d687e30c8c6b5420d86e8149f7557 > prerequisite-patch-id: 2e5cc67f66a8cfe463ec73b98cd17130d4094a86 > prerequisite-patch-id: e39d6867f89c605fd1e3621937c8c91a6cfbe7c8 > prerequisite-patch-id: 5d2232bb3ce3d7d4e23477c2ad3db30424fee33c > prerequisite-patch-id: 946719f43a0cc23ffe82e996e076de2221dcd8db > prerequisite-patch-id: c2c2bc1b676b1e15165e107515b380318e9ca941 > prerequisite-patch-id: aa4a955dd99d0796973fedb78bea269ebab73b6b > prerequisite-patch-id: 1cd27ddae721cc1e6c52723f8b360b09b5e712c7 > prerequisite-patch-id: 237813218e54e0c7cbed8d72e30eb649ffd9ecd4 > prerequisite-patch-id: 8e687755e898e71c80b0294b90deac71fe05c421 > prerequisite-patch-id: 05622d10a27ba9cba36b3d194e51a2d8d7b7b783