* [PATCH] gpio: gpio-vf610: do not touch other bits when set the target bit
@ 2022-05-07 10:54 haibo.chen
2022-05-10 9:02 ` Peng Fan (OSS)
0 siblings, 1 reply; 2+ messages in thread
From: haibo.chen @ 2022-05-07 10:54 UTC (permalink / raw)
To: linus.walleij, brgl; +Cc: linux-gpio, linux-kernel, linux-imx, haibo.chen
From: Haibo Chen <haibo.chen@nxp.com>
For gpio controller contain register PDDR, when set one target bit,
current logic will clear all other bits, this is wrong. Use operator
'|=' to fix it.
Signed-off-by: Haibo Chen <haibo.chen@nxp.com>
---
drivers/gpio/gpio-vf610.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/gpio/gpio-vf610.c b/drivers/gpio/gpio-vf610.c
index 20780c35da1b..23cddb265a0d 100644
--- a/drivers/gpio/gpio-vf610.c
+++ b/drivers/gpio/gpio-vf610.c
@@ -125,9 +125,13 @@ static int vf610_gpio_direction_output(struct gpio_chip *chip, unsigned gpio,
{
struct vf610_gpio_port *port = gpiochip_get_data(chip);
unsigned long mask = BIT(gpio);
+ u32 val;
- if (port->sdata && port->sdata->have_paddr)
- vf610_gpio_writel(mask, port->gpio_base + GPIO_PDDR);
+ if (port->sdata && port->sdata->have_paddr) {
+ val = vf610_gpio_readl(port->gpio_base + GPIO_PDDR);
+ val |= mask;
+ vf610_gpio_writel(val, port->gpio_base + GPIO_PDDR);
+ }
vf610_gpio_set(chip, gpio, value);
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] gpio: gpio-vf610: do not touch other bits when set the target bit
2022-05-07 10:54 [PATCH] gpio: gpio-vf610: do not touch other bits when set the target bit haibo.chen
@ 2022-05-10 9:02 ` Peng Fan (OSS)
0 siblings, 0 replies; 2+ messages in thread
From: Peng Fan (OSS) @ 2022-05-10 9:02 UTC (permalink / raw)
To: haibo.chen, linus.walleij, brgl; +Cc: linux-gpio, linux-kernel, linux-imx
On 2022/5/7 18:54, haibo.chen@nxp.com wrote:
> From: Haibo Chen <haibo.chen@nxp.com>
>
> For gpio controller contain register PDDR, when set one target bit,
> current logic will clear all other bits, this is wrong. Use operator
> '|=' to fix it.
>
A fixes tag required, since this is a fix. With fixes tag added:
Reviewed-by: Peng Fan <peng.fan@nxp.com>
Regards,
Peng.
> Signed-off-by: Haibo Chen <haibo.chen@nxp.com>
> ---
> drivers/gpio/gpio-vf610.c | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpio/gpio-vf610.c b/drivers/gpio/gpio-vf610.c
> index 20780c35da1b..23cddb265a0d 100644
> --- a/drivers/gpio/gpio-vf610.c
> +++ b/drivers/gpio/gpio-vf610.c
> @@ -125,9 +125,13 @@ static int vf610_gpio_direction_output(struct gpio_chip *chip, unsigned gpio,
> {
> struct vf610_gpio_port *port = gpiochip_get_data(chip);
> unsigned long mask = BIT(gpio);
> + u32 val;
>
> - if (port->sdata && port->sdata->have_paddr)
> - vf610_gpio_writel(mask, port->gpio_base + GPIO_PDDR);
> + if (port->sdata && port->sdata->have_paddr) {
> + val = vf610_gpio_readl(port->gpio_base + GPIO_PDDR);
> + val |= mask;
> + vf610_gpio_writel(val, port->gpio_base + GPIO_PDDR);
> + }
>
> vf610_gpio_set(chip, gpio, value);
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-05-10 9:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-05-07 10:54 [PATCH] gpio: gpio-vf610: do not touch other bits when set the target bit haibo.chen
2022-05-10 9:02 ` Peng Fan (OSS)
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).