From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Jacky Huang <ychuang570808@gmail.com>,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
conor+dt@kernel.org, p.zabel@pengutronix.de,
j.neuschaefer@gmx.net, linux-arm-kernel@lists.infradead.org,
linux-gpio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, schung@nuvoton.com,
Jacky Huang <ychuang3@nuvoton.com>
Subject: Re: [PATCH 2/4] dt-bindings: pinctrl: Document nuvoton ma35d1 pin control
Date: Wed, 18 Oct 2023 11:53:50 +0200 [thread overview]
Message-ID: <4ca28f03-eb05-4cd7-ace5-8cbc0d108b6c@linaro.org> (raw)
In-Reply-To: <CACRpkdaiihOex19SavWwC+S8o5qp=F=XMNm9+UXh=q2nVbOFkA@mail.gmail.com>
On 18/10/2023 10:18, Linus Walleij wrote:
> On Mon, Oct 16, 2023 at 9:52 PM Krzysztof Kozlowski
> <krzysztof.kozlowski@linaro.org> wrote:
>
>>> I noticed that 'xlnx,zynq-pinctrl.yaml' and 'xlnx,zynq-pinctrl.yaml' use
>>> 'power source' to specify the output voltage. Should I follow their
>>> approach or define a vendor-specific one?
>>
>> Maybe Rob or Linus have here some recommendation, but I would suggest to
>> go either with rtd1319d-pinctrl.yaml approach or add a generic property
>> to pincfg-node expressed in real units like "io-microvolt".
>>
>> Rob, Linus, any ideas for generic property replacing register-specific
>> power-source?
>
> The existing power-source is generally used to select between (usually
> two) different chip-internal power rails, such as 1.8V and 3.3V.
> The format is a driver-specific enumerator.
>
> We *could* just patch the documentation for power-source to
> say that microvolts is the preferred format but legacy users may
> be using a custom enumerator.
>
> io-microvolt seems like a more long-term viable option if a wider
> range of voltages are to be supported so I'm happy with that if the
> DT folks think it's nicer. However notice that the power-source
> property is already being hard-coded into things such as SCMI
> and ACPI so it's not like it will ever be replaced by io-microvolt
> and phased out as far as Linux is concerned. Not the next 50
> years at least.
This I understand.
I think It is better in general if generic properties use units (e.g.
drive-strength-microamp, output-impedance-ohms), so it could be here
"io-microvolt". At least for the new bindings.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-10-18 9:53 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-11 9:05 [PATCH 0/4] Add support for nuvoton ma35d1 pin control Jacky Huang
2023-10-11 9:05 ` [PATCH 1/4] dt-bindings: reset: Add syscon to nuvoton ma35d1 system-management node Jacky Huang
2023-10-12 19:30 ` Krzysztof Kozlowski
2023-10-13 6:34 ` Jacky Huang
2023-10-12 20:39 ` Rob Herring
2023-10-13 6:40 ` Jacky Huang
2023-10-11 9:05 ` [PATCH 2/4] dt-bindings: pinctrl: Document nuvoton ma35d1 pin control Jacky Huang
2023-10-12 19:41 ` Krzysztof Kozlowski
2023-10-16 4:32 ` Jacky Huang
2023-10-16 19:52 ` Krzysztof Kozlowski
2023-10-18 3:26 ` Jacky Huang
2023-10-18 5:58 ` Krzysztof Kozlowski
2023-10-18 7:01 ` Jacky Huang
2023-10-18 8:18 ` Linus Walleij
2023-10-18 9:53 ` Krzysztof Kozlowski [this message]
2023-10-18 11:41 ` Linus Walleij
2023-10-11 9:05 ` [PATCH 3/4] arm64: dts: nuvoton: Add pinctrl support for ma35d1 Jacky Huang
2023-10-12 19:46 ` Krzysztof Kozlowski
2023-10-13 6:52 ` Jacky Huang
2023-10-13 7:06 ` Krzysztof Kozlowski
2023-10-13 7:44 ` Jacky Huang
2023-10-11 9:05 ` [PATCH 4/4] pinctrl: nuvoton: Add ma35d1 pinctrl and GPIO driver Jacky Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ca28f03-eb05-4cd7-ace5-8cbc0d108b6c@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=j.neuschaefer@gmx.net \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=robh+dt@kernel.org \
--cc=schung@nuvoton.com \
--cc=ychuang3@nuvoton.com \
--cc=ychuang570808@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).