Re: [PATCH v2 2/9] dt-bindings: pincfg-node: Add property "skew-delay-direction"

[Antonio Borneo <antonio.borneo@foss.st.com>]

On Tue, 2025-09-30 at 14:23 +0200, Linus Walleij wrote:
> Hi Antonio,
> 
> thanks for your patch!
> 
> And sorry that it takes so long for me to review it! :(

Hi Linus,

no problem, thanks for your review!

> 
> On Fri, Sep 5, 2025 at 3:56 PM Antonio Borneo
> <antonio.borneo@foss.st.com> wrote:
> 
> > Add the property "skew-delay-direction" to specify on which pin's
> > direction (either input, output or both) the value of the generic
> > property 'skew-delay' applies.
> > For backward compatibility, 'skew-delay' applies on both input and
> > output directions when the new property is not present or has
> > value '0'.
> > 
> > Signed-off-by: Antonio Borneo <antonio.borneo@foss.st.com>
> (...)
> > +  skew-delay-direction:
> > +    $ref: /schemas/types.yaml#/definitions/uint32
> > +    enum: [0, 1, 2]
> > +    default: 0
> > +    description: |
> > +      0: skew-delay applies to both input and output directions
> > +      1: skew-delay applies only to the output direction
> > +      2: skew-delay applies only to the input direction
> 
> Unfortunately I don't think this will work, because skew-delay
> has a value, and with this scheme we can only specify that we
> want this value to affect both in/out, only in or only out.
> 
> What happens when someone want to configure different
> skew delay for input and output?

It makes sense!

I will address it in V3.

> I think it is better to add:
> 
> skew-delay-input = <u32>;
> skew-delay-output = <u32>;
> 
> So the drivers that need this explicitly specified will need
> to just define one of these instead.
> 
> If you want to be very determined, make the schema
> not accept skew-delay if either skew-delay-input
> or skew-delay-output is specified.

Sure, I will add the proper test.

Regards,
Antonio