From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f179.google.com (mail-lj1-f179.google.com [209.85.208.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0055D20264D for ; Wed, 6 Nov 2024 15:17:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730906252; cv=none; b=QqAdUg+fgceEyLPb4iI3utYyKkxvz/WdZw5VLz+zOzho4VMIeRN/4I7BLWW7t0rjnzAN0ASeAvftMuzk8DRgMmAwrAorwASTitvY+ZIac12j1ZecnZJhyYhZ9XDJ2WqAKGQzI+EHssPIm/ikywFk0SuSENJ5Fr1v6oLWdvwHid8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730906252; c=relaxed/simple; bh=uKlUi9Sg140f0IdPzaKYU2GXQ6NZXSS0fvyz8qo/uPc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=dHILp5MFJgu5bSiwzvpxwyfV1KEYopQBkG416/tj4POZO69jp/WxwUIwpOlZn/8fWmwVsRXJlys4YS99YFJoKMzjiBA6TeamG6QqGhCtVJTmAGTafiBva+DOB2tK72vCHAKiP8JM2z8Ao28NWZkm+o4l94rnhhq+eJ6hF5jKfhU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev; spf=pass smtp.mailfrom=tuxon.dev; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b=pL+UeLyI; arc=none smtp.client-ip=209.85.208.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b="pL+UeLyI" Received: by mail-lj1-f179.google.com with SMTP id 38308e7fff4ca-2fb559b0b00so55896051fa.0 for ; Wed, 06 Nov 2024 07:17:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tuxon.dev; s=google; t=1730906248; x=1731511048; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=4MsTq/WJqlO5g9jEiiWLZqf/MRDx8MkbY/RBJULejSE=; b=pL+UeLyIg4maDpaK21NrO4Hya8+56wocLDvNRoWSGJ6fKpRJiyvmJPwxmW4Tj4IjHQ TfBQb7PtNcule4MZ+h4wmJfcgs2rWol6miZLACzsMMV/yBc87uRBM+KU0OKkEVq8vkkK Cp/oOIpjJB4se6BvZPVdigqEMdvS7e/uOksh71Vuy0LAmwog45XRJLqgZWv+Z5NSEAiq vvE4b6R3jBnev4tGq3uJmuxEmRuxgw6ZQROY7eioFnwg82ynV+5myCoyZfkN4mBtuAPg 94NEPkQ0Bz8NotKdcl8HNOuu6FSAUtuA2HhXXf98jIcE9Plq6U5LzloZLGqn2TpufMRZ lZhQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730906248; x=1731511048; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=4MsTq/WJqlO5g9jEiiWLZqf/MRDx8MkbY/RBJULejSE=; b=FScTIh9Z4RmyQF7Xw05LOaTrtt/4SE07Hn9EADL4JfhE1q1imxqt+qSWNby0klK5MK EgGyGtKVCVVid56nnDRrxeJWiHszuJoFpKK/YggJMgQH//UlrsHzY2eJGLM3A/pMA+Pv quQbBhHK4VbgXvm6KLcEfOoRSQtxvYc/XfH6qME44vAIZifBOQMLg6G8tyLJxJmB7g5N oNX38FMdkDyf6xOmEIayoLDH8vm8s1xxwuLQtmKGDHEKzS1TCEojavGzu1needWOlQ8F G+47oJ/Q8M8BsRwKJNSL/zGEhjiccRr/KrVNMTDGnmKc04QAsCpYKYPgg/uDzfurtRcv IIEw== X-Forwarded-Encrypted: i=1; AJvYcCWDL0k4I/Ht7f9oIXj8B/BKCA0Gsqcw+4I8YKVmmHD4gEHpfUCuvbwtk9UoOJBwIKA2PbuRRuFbcxaH@vger.kernel.org X-Gm-Message-State: AOJu0Ywwzipv3chKpsr51zF1sayr9WP6k89Ps+mUgcwhNncQA7kFO0il sDL9YuGp8Th7+qPWZBlpDdtwpiXeU5d2+sFpKMGfgBw1XPDIrba3B9vLe2gJtVg= X-Google-Smtp-Source: AGHT+IGnJcBdTdgjK/B0z/HelObGqjcm5AB5nzH8x/DxvLNK2CcgfKasW11Fsyv2wiAlGSAOaH7rtw== X-Received: by 2002:a2e:be0d:0:b0:2fb:8774:440c with SMTP id 38308e7fff4ca-2fedb7a2a10mr97785331fa.10.1730906248023; Wed, 06 Nov 2024 07:17:28 -0800 (PST) Received: from [192.168.50.4] ([82.78.167.28]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5cee6a9a41bsm2855950a12.14.2024.11.06.07.17.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 06 Nov 2024 07:17:27 -0800 (PST) Message-ID: <4e233ebe-b0e1-4b37-9063-bdbeb5980b13@tuxon.dev> Date: Wed, 6 Nov 2024 17:17:22 +0200 Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 12/31] ASoC: sh: rz-ssi: Use a proper bitmask for clear bits Content-Language: en-US To: Geert Uytterhoeven Cc: mturquette@baylibre.com, sboyd@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, biju.das.jz@bp.renesas.com, prabhakar.mahadev-lad.rj@bp.renesas.com, lgirdwood@gmail.com, broonie@kernel.org, magnus.damm@gmail.com, linus.walleij@linaro.org, support.opensource@diasemi.com, perex@perex.cz, tiwai@suse.com, p.zabel@pengutronix.de, Adam.Thomson.Opensource@diasemi.com, linux-renesas-soc@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-sound@vger.kernel.org, linux-gpio@vger.kernel.org, Claudiu Beznea References: <20241106081826.1211088-1-claudiu.beznea.uj@bp.renesas.com> <20241106081826.1211088-13-claudiu.beznea.uj@bp.renesas.com> From: Claudiu Beznea In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Hi, Geert, On 06.11.2024 16:56, Geert Uytterhoeven wrote: > Hi Claudiu, > > On Wed, Nov 6, 2024 at 9:19 AM Claudiu wrote: >> From: Claudiu Beznea >> >> While it is still correct to pass zero as the bit-clear mask it may be >> confusing. For this, use a proper bitmask for clear bits. >> >> Signed-off-by: Claudiu Beznea > > Thanks for your patch! > >> --- a/sound/soc/renesas/rz-ssi.c >> +++ b/sound/soc/renesas/rz-ssi.c >> @@ -331,7 +331,7 @@ static void rz_ssi_set_idle(struct rz_ssi_priv *ssi) >> dev_info(ssi->dev, "timeout waiting for SSI idle\n"); >> >> /* Hold FIFOs in reset */ >> - rz_ssi_reg_mask_setl(ssi, SSIFCR, 0, SSIFCR_FIFO_RST); >> + rz_ssi_reg_mask_setl(ssi, SSIFCR, SSIFCR_FIFO_RST, SSIFCR_FIFO_RST); > > But you're not clearing SSIFCR_FIFO_RST, you're setting it? The bits should be set to reset the FIFOs. By "Use a proper bitmask for clear bits" phrase in the patch title or description I was referring at the 3rd argument of the rz_ssi_reg_mask_setl() function, which has the following prototype: static void rz_ssi_reg_mask_setl(struct rz_ssi_priv *priv, uint reg, u32 bclr, u32 bset) Would you prefer to rephrase it in the next version? Thank you, Claudiu Beznea > >> } >> >> static int rz_ssi_start(struct rz_ssi_priv *ssi, struct rz_ssi_stream *strm) > > Gr{oetje,eeting}s, > > Geert >