From: Alex Elder <elder@ieee.org>
To: Geert Uytterhoeven <geert+renesas@glider.be>,
Linus Walleij <linus.walleij@linaro.org>,
Yixun Lan <dlan@gentoo.org>,
Conor Dooley <conor.dooley@microchip.com>,
Javier Martinez Canillas <javierm@redhat.com>
Cc: linux-gpio@vger.kernel.org, linux-riscv@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] pinctrl: spacemit: PINCTRL_SPACEMIT_K1 should not default to y unconditionally
Date: Mon, 17 Mar 2025 07:24:06 -0500 [thread overview]
Message-ID: <4e4b85b1-bb4b-4de2-8780-a22fae6c1b8c@ieee.org> (raw)
In-Reply-To: <6881b8d1ad74ac780af8a974e604b5ef3f5d4aad.1742198691.git.geert+renesas@glider.be>
On 3/17/25 3:06 AM, Geert Uytterhoeven wrote:
> Merely enabling compile-testing should not enable additional
> functionality.
>
> Fixes: 7ff4faba63571c51 ("pinctrl: spacemit: enable config option")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
This (now) makes sense to me. Looks good. I'll look for other
cases like this from now on.
Tested-by: Alex Elder <elder@riscstar.com>
And if you like:
Reviewed-by: Alex Elder <elder@riscstar.com>
> ---
> drivers/pinctrl/spacemit/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pinctrl/spacemit/Kconfig b/drivers/pinctrl/spacemit/Kconfig
> index a2f98b3f8a75580d..d6f6017fd097d326 100644
> --- a/drivers/pinctrl/spacemit/Kconfig
> +++ b/drivers/pinctrl/spacemit/Kconfig
> @@ -7,7 +7,7 @@ config PINCTRL_SPACEMIT_K1
> bool "SpacemiT K1 SoC Pinctrl driver"
> depends on ARCH_SPACEMIT || COMPILE_TEST
> depends on OF
> - default y
> + default ARCH_SPACEMIT
> select GENERIC_PINCTRL_GROUPS
> select GENERIC_PINMUX_FUNCTIONS
> select GENERIC_PINCONF
next prev parent reply other threads:[~2025-03-17 12:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-17 8:06 [PATCH] pinctrl: spacemit: PINCTRL_SPACEMIT_K1 should not default to y unconditionally Geert Uytterhoeven
2025-03-17 12:24 ` Alex Elder [this message]
2025-03-17 12:56 ` Javier Martinez Canillas
2025-03-17 13:23 ` Yixun Lan
2025-03-18 13:12 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4e4b85b1-bb4b-4de2-8780-a22fae6c1b8c@ieee.org \
--to=elder@ieee.org \
--cc=conor.dooley@microchip.com \
--cc=dlan@gentoo.org \
--cc=geert+renesas@glider.be \
--cc=javierm@redhat.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox