From: Andrew Jeffery <andrew@codeconstruct.com.au>
To: Billy Tsai <billy_tsai@aspeedtech.com>,
linus.walleij@linaro.org, brgl@bgdev.pl, robh@kernel.org,
krzk+dt@kernel.org, conor+dt@kernel.org, joel@jms.id.au,
linux-gpio@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org,
BMC-SW@aspeedtech.com, Peter.Yin@quantatw.com,
Jay_Zhang@wiwynn.com
Subject: Re: [PATCH v6 5/7] gpio: aspeed: Change the macro to support deferred probe
Date: Mon, 30 Sep 2024 14:07:39 +0930 [thread overview]
Message-ID: <506c41f97dc0243ed156f1775006ef30fe4a3f54.camel@codeconstruct.com.au> (raw)
In-Reply-To: <20240927111744.3511373-6-billy_tsai@aspeedtech.com>
On Fri, 2024-09-27 at 19:17 +0800, Billy Tsai wrote:
> Use module_platform_driver() to replace module_platform_driver_probe().
> The former utilizes platform_driver_register(), which allows the driver to
> defer probing when it doesn't acquire the necessary resources due to probe
> order. In contrast, the latter uses __platform_driver_probe(), which
> includes the comment "Note that this is incompatible with deferred
> probing." Since our GPIO driver requires access to the clock resource, the
> former is more suitable.
>
> Signed-off-by: Billy Tsai <billy_tsai@aspeedtech.com>
Seems okay to make it less of a deviant, though maybe we should fix the
sgpio drive as well? Anyway:
Reviewed-by: Andrew Jeffery <andrew@codeconstruct.com.au>
Andrew
next prev parent reply other threads:[~2024-09-30 4:37 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-27 11:17 [PATCH v6 0/7] Add Aspeed G7 gpio support Billy Tsai
2024-09-27 11:17 ` [PATCH v6 1/7] dt-bindings: gpio: aspeed,ast2400-gpio: Support ast2700 Billy Tsai
2024-09-27 11:17 ` [PATCH v6 2/7] gpio: aspeed: Remove the name for bank array Billy Tsai
2024-09-27 11:17 ` [PATCH v6 3/7] gpio: aspeed: Create llops to handle hardware access Billy Tsai
2024-09-30 4:00 ` Andrew Jeffery
2024-09-27 11:17 ` [PATCH v6 4/7] gpio: aspeed: Support G7 Aspeed gpio controller Billy Tsai
2024-09-30 4:04 ` Andrew Jeffery
2024-09-27 11:17 ` [PATCH v6 5/7] gpio: aspeed: Change the macro to support deferred probe Billy Tsai
2024-09-30 4:37 ` Andrew Jeffery [this message]
2024-09-27 11:17 ` [PATCH v6 6/7] gpio: aspeed: Add the flush write to ensure the write complete Billy Tsai
2024-09-30 4:38 ` Andrew Jeffery
2024-09-27 11:17 ` [PATCH v6 7/7] gpio: aspeed: Use devm_clk api to manage clock source Billy Tsai
2024-09-30 4:42 ` Andrew Jeffery
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=506c41f97dc0243ed156f1775006ef30fe4a3f54.camel@codeconstruct.com.au \
--to=andrew@codeconstruct.com.au \
--cc=BMC-SW@aspeedtech.com \
--cc=Jay_Zhang@wiwynn.com \
--cc=Peter.Yin@quantatw.com \
--cc=billy_tsai@aspeedtech.com \
--cc=brgl@bgdev.pl \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=joel@jms.id.au \
--cc=krzk+dt@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).