From: Stefan Wahren <wahrenst@gmx.net>
To: haibo.chen@nxp.com, linus.walleij@linaro.org, brgl@bgdev.pl
Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
imx@lists.linux.dev
Subject: Re: [PATCH v2 2/2] gpio: vf610: add get_direction() support
Date: Fri, 2 Aug 2024 15:22:03 +0200 [thread overview]
Message-ID: <50b97539-cef2-4a75-a750-96adc2467f67@gmx.net> (raw)
In-Reply-To: <20240801093028.732338-3-haibo.chen@nxp.com>
Hi Haibo,
Am 01.08.24 um 11:30 schrieb haibo.chen@nxp.com:
> From: Haibo Chen <haibo.chen@nxp.com>
>
> For IP which do not contain PDDR, currently use the pinmux API
> pinctrl_gpio_direction_input() to config the output/input, pinmux
> currently do not support get_direction(). So here add the GPIO
> get_direction() support only for the IP which has Port Data
> Direction Register (PDDR).
just a question about how things work:
fsl,imx7ulp-gpio and i.MX93 have PDDR, so GPIO get_direction is handled
in gpio-vf610 driver
fsl,vf610-gpio doesn't have PDDR, so all GPIO direction stuff is handled
in pinctrl-vf610 driver
Is this correct?
Best regards
next prev parent reply other threads:[~2024-08-02 13:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-01 9:30 [PATCH v2 0/2] few small change for gpio-vf610 haibo.chen
2024-08-01 9:30 ` [PATCH v2 1/2] gpio: gpio-vf610: use u32 mask to handle 32 number gpios haibo.chen
2024-08-02 13:22 ` Stefan Wahren
2024-08-05 4:38 ` Stefan Wahren
2024-08-01 9:30 ` [PATCH v2 2/2] gpio: vf610: add get_direction() support haibo.chen
2024-08-02 13:22 ` Stefan Wahren [this message]
2024-08-05 2:08 ` Bough Chen
2024-08-05 9:51 ` [PATCH v2 0/2] few small change for gpio-vf610 Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50b97539-cef2-4a75-a750-96adc2467f67@gmx.net \
--to=wahrenst@gmx.net \
--cc=brgl@bgdev.pl \
--cc=haibo.chen@nxp.com \
--cc=imx@lists.linux.dev \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox