From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D051C6FA86 for ; Fri, 23 Sep 2022 09:21:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230116AbiIWJVg (ORCPT ); Fri, 23 Sep 2022 05:21:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57202 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230488AbiIWJVf (ORCPT ); Fri, 23 Sep 2022 05:21:35 -0400 Received: from mail-lj1-x22f.google.com (mail-lj1-x22f.google.com [IPv6:2a00:1450:4864:20::22f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B7F3413070F for ; Fri, 23 Sep 2022 02:21:33 -0700 (PDT) Received: by mail-lj1-x22f.google.com with SMTP id h3so13984244lja.1 for ; Fri, 23 Sep 2022 02:21:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=7slKNQh60cH75T6cRpc524ASdPemcdJLGtdMzrxSYyU=; b=HyrSz8jTScQZTYUsbOu1g5FDL7oZOyf1s0Lc0HZQi9P6adutQjNUM+Un9WYFhsVEij Ba6Sl/mUaV0geS0UFA+BSP9uuLEa+6W1+/fDWvK73NB397lq6UusDD+bx2PVpvf87VP/ AcpC/5nFqDzljfIkvAzdfFYnkLHeG4CoNhH8mJ52uLQP8trylJMZf9IOMThEFmnHqNmK H3p/jhzsCjrnf6KC3xTQ6esGIio110B+EIL54O3dOvQPs+Kfp+/37S6OTRQK2V/LzRfB BA6aJSe5MqtuDBAGaKYEmKU2bcM2gUMdgvfHg45t7ZIepj8APZObWmjdzoilEos+qpp1 MqoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=7slKNQh60cH75T6cRpc524ASdPemcdJLGtdMzrxSYyU=; b=RZ/iE0cWVhltbG5sfz72mVT4EQ5JgfF70zB8CPQiB8JQJuAy71qBFwCGbynbOcPgOM UKDlT7EpEFr0tmAtV4e0pxbyRWYtO94eDvRDbFAluq9wdPUeII3yG0WT849rF41uTO7D OnlA6pMYK02HQ7e6YWFKKymfFeyk8/e47QKiWVdd9+i0waW0XQ+B1aXD3uuCLnaHPAGe kO7FsC4Jpu1xDBAuMofU2Id8/BRhi7G7bLTr0bLVjNa9vHxms+yCQIqcV8NGcR1p6BAB wQHIC+kO9ZdGE4CLORv1tpF73J+iztoqObxWL1FsfF9gVu9kExnx5+NjyDmKwvDXPNqk iAdg== X-Gm-Message-State: ACrzQf0YPFH2A5Yh34N8sr9nkhNboH1QiUVR8CAdf8XleZUrHDJbxUsy +lvRPEmm8L89fjSBL2OGAaQzNQ== X-Google-Smtp-Source: AMsMyM74Lo3/SJUxoYla08JLCU/g5bhtWWnSLD+31ZWhtxJwgkE+9Vc+9/OUSstjZkqFaNSdWOVI5w== X-Received: by 2002:a2e:bc11:0:b0:26c:565:12f6 with SMTP id b17-20020a2ebc11000000b0026c056512f6mr2423362ljf.91.1663924891762; Fri, 23 Sep 2022 02:21:31 -0700 (PDT) Received: from [192.168.0.21] (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id bg33-20020a05651c0ba100b00261beb471d1sm1284238ljb.121.2022.09.23.02.21.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 23 Sep 2022 02:21:31 -0700 (PDT) Message-ID: <5145d4db-65bf-971d-84cd-73c222311cd3@linaro.org> Date: Fri, 23 Sep 2022 11:21:30 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH] dt-bindings: pinctrl: stm32: add missing entries for gpio subnodes Content-Language: en-US To: Alexandre TORGUE , Linus Walleij , Rob Herring , Krzysztof Kozlowski Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, Fabien Dessenne References: <20220913074639.31932-1-alexandre.torgue@foss.st.com> <9b711a9e-9e63-b69e-fabf-e05c11f145a6@linaro.org> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On 23/09/2022 10:29, Alexandre TORGUE wrote: > Hi Krzysztof > > On 9/19/22 13:32, Krzysztof Kozlowski wrote: >> On 13/09/2022 09:46, Alexandre Torgue wrote: >>> Add "interrupt-controller" and gpio-line-names to gpio subnodes in order to >>> fix dtb validation. >> >> Rebase your patch on recent Linux kernel and use get_maintainers.pl. > > I did it on 6.0-rc5 but yes I used your kernel.org address instead of > linaro ones. Sorry. > >> >>> >>> Signed-off-by: Alexandre Torgue >>> >>> diff --git a/Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.yaml >>> index d35dcc4f0242..92582cccbb1b 100644 >>> --- a/Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.yaml >>> +++ b/Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.yaml >>> @@ -65,6 +65,10 @@ patternProperties: >>> '#gpio-cells': >>> const: 2 >>> >>> + interrupt-controller: true >>> + '#interrupt-cells': >>> + const: 2 >>> + >>> reg: >>> maxItems: 1 >>> clocks: >>> @@ -80,6 +84,8 @@ patternProperties: >>> minimum: 1 >>> maximum: 16 >>> >>> + gpio-line-names: true >> >> maxItems? > > Generic question, Is it mandatory to add maxItems information for all > entries ? It's not mandatory for all. For some it is recommended, for some it does not make sense. Here it's quite easy to add and it will validate the entry. Any reason not to add it? Best regards, Krzysztof