* [PATCH] dt-bindings: pinctrl: stm32: add missing entries for gpio subnodes
@ 2022-09-13 7:46 Alexandre Torgue
2022-09-13 15:55 ` Rob Herring
2022-09-19 11:32 ` Krzysztof Kozlowski
0 siblings, 2 replies; 6+ messages in thread
From: Alexandre Torgue @ 2022-09-13 7:46 UTC (permalink / raw)
To: Linus Walleij, Rob Herring, Krzysztof Kozlowski
Cc: linux-arm-kernel, devicetree, linux-kernel, linux-gpio,
linux-stm32, Alexandre Torgue, Fabien Dessenne
Add "interrupt-controller" and gpio-line-names to gpio subnodes in order to
fix dtb validation.
Signed-off-by: Alexandre Torgue <alexandre.torgue@foss.st.com>
diff --git a/Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.yaml
index d35dcc4f0242..92582cccbb1b 100644
--- a/Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.yaml
@@ -65,6 +65,10 @@ patternProperties:
'#gpio-cells':
const: 2
+ interrupt-controller: true
+ '#interrupt-cells':
+ const: 2
+
reg:
maxItems: 1
clocks:
@@ -80,6 +84,8 @@ patternProperties:
minimum: 1
maximum: 16
+ gpio-line-names: true
+
st,bank-name:
description:
Should be a name string for this bank as specified in the datasheet.
--
2.17.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] dt-bindings: pinctrl: stm32: add missing entries for gpio subnodes
2022-09-13 7:46 [PATCH] dt-bindings: pinctrl: stm32: add missing entries for gpio subnodes Alexandre Torgue
@ 2022-09-13 15:55 ` Rob Herring
2022-09-19 11:32 ` Krzysztof Kozlowski
1 sibling, 0 replies; 6+ messages in thread
From: Rob Herring @ 2022-09-13 15:55 UTC (permalink / raw)
To: Alexandre Torgue
Cc: Linus Walleij, devicetree, linux-stm32, linux-gpio, Rob Herring,
linux-kernel, Krzysztof Kozlowski, linux-arm-kernel,
Fabien Dessenne
On Tue, 13 Sep 2022 09:46:39 +0200, Alexandre Torgue wrote:
> Add "interrupt-controller" and gpio-line-names to gpio subnodes in order to
> fix dtb validation.
>
> Signed-off-by: Alexandre Torgue <alexandre.torgue@foss.st.com>
>
Acked-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] dt-bindings: pinctrl: stm32: add missing entries for gpio subnodes
2022-09-13 7:46 [PATCH] dt-bindings: pinctrl: stm32: add missing entries for gpio subnodes Alexandre Torgue
2022-09-13 15:55 ` Rob Herring
@ 2022-09-19 11:32 ` Krzysztof Kozlowski
2022-09-23 8:29 ` Alexandre TORGUE
1 sibling, 1 reply; 6+ messages in thread
From: Krzysztof Kozlowski @ 2022-09-19 11:32 UTC (permalink / raw)
To: Alexandre Torgue, Linus Walleij, Rob Herring, Krzysztof Kozlowski
Cc: linux-arm-kernel, devicetree, linux-kernel, linux-gpio,
linux-stm32, Fabien Dessenne
On 13/09/2022 09:46, Alexandre Torgue wrote:
> Add "interrupt-controller" and gpio-line-names to gpio subnodes in order to
> fix dtb validation.
Rebase your patch on recent Linux kernel and use get_maintainers.pl.
>
> Signed-off-by: Alexandre Torgue <alexandre.torgue@foss.st.com>
>
> diff --git a/Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.yaml
> index d35dcc4f0242..92582cccbb1b 100644
> --- a/Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.yaml
> +++ b/Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.yaml
> @@ -65,6 +65,10 @@ patternProperties:
> '#gpio-cells':
> const: 2
>
> + interrupt-controller: true
> + '#interrupt-cells':
> + const: 2
> +
> reg:
> maxItems: 1
> clocks:
> @@ -80,6 +84,8 @@ patternProperties:
> minimum: 1
> maximum: 16
>
> + gpio-line-names: true
maxItems?
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] dt-bindings: pinctrl: stm32: add missing entries for gpio subnodes
2022-09-19 11:32 ` Krzysztof Kozlowski
@ 2022-09-23 8:29 ` Alexandre TORGUE
2022-09-23 9:21 ` Krzysztof Kozlowski
0 siblings, 1 reply; 6+ messages in thread
From: Alexandre TORGUE @ 2022-09-23 8:29 UTC (permalink / raw)
To: Krzysztof Kozlowski, Linus Walleij, Rob Herring,
Krzysztof Kozlowski
Cc: linux-arm-kernel, devicetree, linux-kernel, linux-gpio,
linux-stm32, Fabien Dessenne
Hi Krzysztof
On 9/19/22 13:32, Krzysztof Kozlowski wrote:
> On 13/09/2022 09:46, Alexandre Torgue wrote:
>> Add "interrupt-controller" and gpio-line-names to gpio subnodes in order to
>> fix dtb validation.
>
> Rebase your patch on recent Linux kernel and use get_maintainers.pl.
I did it on 6.0-rc5 but yes I used your kernel.org address instead of
linaro ones. Sorry.
>
>>
>> Signed-off-by: Alexandre Torgue <alexandre.torgue@foss.st.com>
>>
>> diff --git a/Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.yaml
>> index d35dcc4f0242..92582cccbb1b 100644
>> --- a/Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.yaml
>> +++ b/Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.yaml
>> @@ -65,6 +65,10 @@ patternProperties:
>> '#gpio-cells':
>> const: 2
>>
>> + interrupt-controller: true
>> + '#interrupt-cells':
>> + const: 2
>> +
>> reg:
>> maxItems: 1
>> clocks:
>> @@ -80,6 +84,8 @@ patternProperties:
>> minimum: 1
>> maximum: 16
>>
>> + gpio-line-names: true
>
> maxItems?
Generic question, Is it mandatory to add maxItems information for all
entries ?
For sure I'll send a v2 with it.
Alex
>
>
> Best regards,
> Krzysztof
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] dt-bindings: pinctrl: stm32: add missing entries for gpio subnodes
2022-09-23 8:29 ` Alexandre TORGUE
@ 2022-09-23 9:21 ` Krzysztof Kozlowski
2022-09-26 10:32 ` Alexandre TORGUE
0 siblings, 1 reply; 6+ messages in thread
From: Krzysztof Kozlowski @ 2022-09-23 9:21 UTC (permalink / raw)
To: Alexandre TORGUE, Linus Walleij, Rob Herring, Krzysztof Kozlowski
Cc: linux-arm-kernel, devicetree, linux-kernel, linux-gpio,
linux-stm32, Fabien Dessenne
On 23/09/2022 10:29, Alexandre TORGUE wrote:
> Hi Krzysztof
>
> On 9/19/22 13:32, Krzysztof Kozlowski wrote:
>> On 13/09/2022 09:46, Alexandre Torgue wrote:
>>> Add "interrupt-controller" and gpio-line-names to gpio subnodes in order to
>>> fix dtb validation.
>>
>> Rebase your patch on recent Linux kernel and use get_maintainers.pl.
>
> I did it on 6.0-rc5 but yes I used your kernel.org address instead of
> linaro ones. Sorry.
>
>>
>>>
>>> Signed-off-by: Alexandre Torgue <alexandre.torgue@foss.st.com>
>>>
>>> diff --git a/Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.yaml
>>> index d35dcc4f0242..92582cccbb1b 100644
>>> --- a/Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.yaml
>>> +++ b/Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.yaml
>>> @@ -65,6 +65,10 @@ patternProperties:
>>> '#gpio-cells':
>>> const: 2
>>>
>>> + interrupt-controller: true
>>> + '#interrupt-cells':
>>> + const: 2
>>> +
>>> reg:
>>> maxItems: 1
>>> clocks:
>>> @@ -80,6 +84,8 @@ patternProperties:
>>> minimum: 1
>>> maximum: 16
>>>
>>> + gpio-line-names: true
>>
>> maxItems?
>
> Generic question, Is it mandatory to add maxItems information for all
> entries ?
It's not mandatory for all. For some it is recommended, for some it does
not make sense. Here it's quite easy to add and it will validate the
entry. Any reason not to add it?
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] dt-bindings: pinctrl: stm32: add missing entries for gpio subnodes
2022-09-23 9:21 ` Krzysztof Kozlowski
@ 2022-09-26 10:32 ` Alexandre TORGUE
0 siblings, 0 replies; 6+ messages in thread
From: Alexandre TORGUE @ 2022-09-26 10:32 UTC (permalink / raw)
To: Krzysztof Kozlowski, Linus Walleij, Rob Herring,
Krzysztof Kozlowski
Cc: linux-arm-kernel, devicetree, linux-kernel, linux-gpio,
linux-stm32, Fabien Dessenne
On 9/23/22 11:21, Krzysztof Kozlowski wrote:
> On 23/09/2022 10:29, Alexandre TORGUE wrote:
>> Hi Krzysztof
>>
>> On 9/19/22 13:32, Krzysztof Kozlowski wrote:
>>> On 13/09/2022 09:46, Alexandre Torgue wrote:
>>>> Add "interrupt-controller" and gpio-line-names to gpio subnodes in order to
>>>> fix dtb validation.
>>>
>>> Rebase your patch on recent Linux kernel and use get_maintainers.pl.
>>
>> I did it on 6.0-rc5 but yes I used your kernel.org address instead of
>> linaro ones. Sorry.
>>
>>>
>>>>
>>>> Signed-off-by: Alexandre Torgue <alexandre.torgue@foss.st.com>
>>>>
>>>> diff --git a/Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.yaml
>>>> index d35dcc4f0242..92582cccbb1b 100644
>>>> --- a/Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.yaml
>>>> +++ b/Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.yaml
>>>> @@ -65,6 +65,10 @@ patternProperties:
>>>> '#gpio-cells':
>>>> const: 2
>>>>
>>>> + interrupt-controller: true
>>>> + '#interrupt-cells':
>>>> + const: 2
>>>> +
>>>> reg:
>>>> maxItems: 1
>>>> clocks:
>>>> @@ -80,6 +84,8 @@ patternProperties:
>>>> minimum: 1
>>>> maximum: 16
>>>>
>>>> + gpio-line-names: true
>>>
>>> maxItems?
>>
>> Generic question, Is it mandatory to add maxItems information for all
>> entries ?
>
> It's not mandatory for all. For some it is recommended, for some it does
> not make sense. Here it's quite easy to add and it will validate the
> entry. Any reason not to add it?
Ok understood. To be honest, no reasons to not add it.
cheers
alex
>
> Best regards,
> Krzysztof
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-09-26 14:08 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-09-13 7:46 [PATCH] dt-bindings: pinctrl: stm32: add missing entries for gpio subnodes Alexandre Torgue
2022-09-13 15:55 ` Rob Herring
2022-09-19 11:32 ` Krzysztof Kozlowski
2022-09-23 8:29 ` Alexandre TORGUE
2022-09-23 9:21 ` Krzysztof Kozlowski
2022-09-26 10:32 ` Alexandre TORGUE
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).