* [PATCH v2 1/3] dt-bindings: pinctrl: renesas,rzg2l-pinctrl: Allow schmitt and open drain properties
2024-10-04 12:36 [PATCH v2 0/3] pinctrl: renesas: rzg2l: Add support to configure open-drain and schmitt-trigger properties Prabhakar
@ 2024-10-04 12:36 ` Prabhakar
2024-10-04 13:04 ` Geert Uytterhoeven
2024-10-05 18:45 ` Rob Herring (Arm)
2024-10-04 12:36 ` [PATCH v2 2/3] pinctrl: renesas: rzg2l: Add support for enabling/disabling open-drain outputs Prabhakar
2024-10-04 12:36 ` [PATCH v2 3/3] pinctrl: renesas: rzg2l: Add support for configuring schmitt-trigger Prabhakar
2 siblings, 2 replies; 10+ messages in thread
From: Prabhakar @ 2024-10-04 12:36 UTC (permalink / raw)
To: Geert Uytterhoeven, Linus Walleij, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Magnus Damm
Cc: devicetree, linux-gpio, linux-kernel, linux-renesas-soc,
Prabhakar, Biju Das, Fabrizio Castro, Lad Prabhakar
From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
On the RZ/V2H(P) SoC we can configure the 'input-schmitt-{enable,disable}'
, 'drive-open-drain' and 'drive-push-pull' of multiplexed pins. Update the
binding documentation to include these properties.
Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
---
Hi Rob,
I have dropped your Ack from v1 as I have updated the commit message and
included `drive-push-pull` property in v2.
Cheers, Prabhakar
v1->v2
- Added `drive-push-pull` property
---
.../devicetree/bindings/pinctrl/renesas,rzg2l-pinctrl.yaml | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/Documentation/devicetree/bindings/pinctrl/renesas,rzg2l-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/renesas,rzg2l-pinctrl.yaml
index 56d90c8e1fa3..a1805b6e3f63 100644
--- a/Documentation/devicetree/bindings/pinctrl/renesas,rzg2l-pinctrl.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/renesas,rzg2l-pinctrl.yaml
@@ -119,6 +119,10 @@ additionalProperties:
bias-disable: true
bias-pull-down: true
bias-pull-up: true
+ input-schmitt-enable: true
+ input-schmitt-disable: true
+ drive-open-drain: true
+ drive-push-pull: true
renesas,output-impedance:
description:
Output impedance for pins on the RZ/V2H(P) SoC. The value provided by this
--
2.43.0
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: [PATCH v2 1/3] dt-bindings: pinctrl: renesas,rzg2l-pinctrl: Allow schmitt and open drain properties
2024-10-04 12:36 ` [PATCH v2 1/3] dt-bindings: pinctrl: renesas,rzg2l-pinctrl: Allow schmitt and open drain properties Prabhakar
@ 2024-10-04 13:04 ` Geert Uytterhoeven
2024-10-05 18:45 ` Rob Herring (Arm)
1 sibling, 0 replies; 10+ messages in thread
From: Geert Uytterhoeven @ 2024-10-04 13:04 UTC (permalink / raw)
To: Prabhakar
Cc: Linus Walleij, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Magnus Damm, devicetree, linux-gpio, linux-kernel,
linux-renesas-soc, Biju Das, Fabrizio Castro, Lad Prabhakar
On Fri, Oct 4, 2024 at 2:37 PM Prabhakar <prabhakar.csengg@gmail.com> wrote:
> From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
>
> On the RZ/V2H(P) SoC we can configure the 'input-schmitt-{enable,disable}'
> , 'drive-open-drain' and 'drive-push-pull' of multiplexed pins. Update the
> binding documentation to include these properties.
>
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> ---
> Hi Rob,
> I have dropped your Ack from v1 as I have updated the commit message and
> included `drive-push-pull` property in v2.
>
> Cheers, Prabhakar
>
> v1->v2
> - Added `drive-push-pull` property
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
i.e. will queue in renesas-pinctrl for v6.13.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH v2 1/3] dt-bindings: pinctrl: renesas,rzg2l-pinctrl: Allow schmitt and open drain properties
2024-10-04 12:36 ` [PATCH v2 1/3] dt-bindings: pinctrl: renesas,rzg2l-pinctrl: Allow schmitt and open drain properties Prabhakar
2024-10-04 13:04 ` Geert Uytterhoeven
@ 2024-10-05 18:45 ` Rob Herring (Arm)
1 sibling, 0 replies; 10+ messages in thread
From: Rob Herring (Arm) @ 2024-10-05 18:45 UTC (permalink / raw)
To: Prabhakar
Cc: Fabrizio Castro, Krzysztof Kozlowski, devicetree,
linux-renesas-soc, Conor Dooley, Magnus Damm, Geert Uytterhoeven,
Linus Walleij, Biju Das, linux-kernel, Lad Prabhakar, linux-gpio
On Fri, 04 Oct 2024 13:36:56 +0100, Prabhakar wrote:
> From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
>
> On the RZ/V2H(P) SoC we can configure the 'input-schmitt-{enable,disable}'
> , 'drive-open-drain' and 'drive-push-pull' of multiplexed pins. Update the
> binding documentation to include these properties.
>
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> ---
> Hi Rob,
> I have dropped your Ack from v1 as I have updated the commit message and
> included `drive-push-pull` property in v2.
>
> Cheers, Prabhakar
>
> v1->v2
> - Added `drive-push-pull` property
> ---
> .../devicetree/bindings/pinctrl/renesas,rzg2l-pinctrl.yaml | 4 ++++
> 1 file changed, 4 insertions(+)
>
Acked-by: Rob Herring (Arm) <robh@kernel.org>
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH v2 2/3] pinctrl: renesas: rzg2l: Add support for enabling/disabling open-drain outputs
2024-10-04 12:36 [PATCH v2 0/3] pinctrl: renesas: rzg2l: Add support to configure open-drain and schmitt-trigger properties Prabhakar
2024-10-04 12:36 ` [PATCH v2 1/3] dt-bindings: pinctrl: renesas,rzg2l-pinctrl: Allow schmitt and open drain properties Prabhakar
@ 2024-10-04 12:36 ` Prabhakar
2024-10-04 13:05 ` Geert Uytterhoeven
2024-10-09 7:53 ` claudiu beznea
2024-10-04 12:36 ` [PATCH v2 3/3] pinctrl: renesas: rzg2l: Add support for configuring schmitt-trigger Prabhakar
2 siblings, 2 replies; 10+ messages in thread
From: Prabhakar @ 2024-10-04 12:36 UTC (permalink / raw)
To: Geert Uytterhoeven, Linus Walleij, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Magnus Damm
Cc: devicetree, linux-gpio, linux-kernel, linux-renesas-soc,
Prabhakar, Biju Das, Fabrizio Castro, Lad Prabhakar
From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Add support for enabling and disabling open-drain outputs.
Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
---
v1->v2
- Implemented PIN_CONFIG_DRIVE_OPEN_DRAIN to disable open drain
---
drivers/pinctrl/renesas/pinctrl-rzg2l.c | 23 +++++++++++++++++++++++
1 file changed, 23 insertions(+)
diff --git a/drivers/pinctrl/renesas/pinctrl-rzg2l.c b/drivers/pinctrl/renesas/pinctrl-rzg2l.c
index b2d309f742af..8d576cc74003 100644
--- a/drivers/pinctrl/renesas/pinctrl-rzg2l.c
+++ b/drivers/pinctrl/renesas/pinctrl-rzg2l.c
@@ -139,6 +139,7 @@
#define IEN(off) (0x1800 + (off) * 8)
#define PUPD(off) (0x1C00 + (off) * 8)
#define ISEL(off) (0x2C00 + (off) * 8)
+#define NOD(off) (0x3000 + (off) * 8)
#define SD_CH(off, ch) ((off) + (ch) * 4)
#define ETH_POC(off, ch) ((off) + (ch) * 4)
#define QSPI (0x3008)
@@ -160,6 +161,7 @@
#define IOLH_MASK 0x03
#define SR_MASK 0x01
#define PUPD_MASK 0x03
+#define NOD_MASK 0x01
#define PM_INPUT 0x1
#define PM_OUTPUT 0x2
@@ -1337,6 +1339,18 @@ static int rzg2l_pinctrl_pinconf_get(struct pinctrl_dev *pctldev,
break;
}
+ case PIN_CONFIG_DRIVE_OPEN_DRAIN:
+ case PIN_CONFIG_DRIVE_PUSH_PULL:
+ if (!(cfg & PIN_CFG_NOD))
+ return -EINVAL;
+
+ arg = rzg2l_read_pin_config(pctrl, NOD(off), bit, NOD_MASK);
+ if (!arg && param != PIN_CONFIG_DRIVE_PUSH_PULL)
+ return -EINVAL;
+ if (arg && param != PIN_CONFIG_DRIVE_OPEN_DRAIN)
+ return -EINVAL;
+ break;
+
case RENESAS_RZV2H_PIN_CONFIG_OUTPUT_IMPEDANCE:
if (!(cfg & PIN_CFG_IOLH_RZV2H))
return -EINVAL;
@@ -1466,6 +1480,15 @@ static int rzg2l_pinctrl_pinconf_set(struct pinctrl_dev *pctldev,
rzg2l_rmw_pin_config(pctrl, IOLH(off), bit, IOLH_MASK, index);
break;
+ case PIN_CONFIG_DRIVE_OPEN_DRAIN:
+ case PIN_CONFIG_DRIVE_PUSH_PULL:
+ if (!(cfg & PIN_CFG_NOD))
+ return -EINVAL;
+
+ rzg2l_rmw_pin_config(pctrl, NOD(off), bit, NOD_MASK,
+ param == PIN_CONFIG_DRIVE_OPEN_DRAIN ? 1 : 0);
+ break;
+
case RENESAS_RZV2H_PIN_CONFIG_OUTPUT_IMPEDANCE:
if (!(cfg & PIN_CFG_IOLH_RZV2H))
return -EINVAL;
--
2.43.0
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH v2 2/3] pinctrl: renesas: rzg2l: Add support for enabling/disabling open-drain outputs
2024-10-04 12:36 ` [PATCH v2 2/3] pinctrl: renesas: rzg2l: Add support for enabling/disabling open-drain outputs Prabhakar
@ 2024-10-04 13:05 ` Geert Uytterhoeven
2024-10-09 7:53 ` claudiu beznea
1 sibling, 0 replies; 10+ messages in thread
From: Geert Uytterhoeven @ 2024-10-04 13:05 UTC (permalink / raw)
To: Prabhakar
Cc: Linus Walleij, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Magnus Damm, devicetree, linux-gpio, linux-kernel,
linux-renesas-soc, Biju Das, Fabrizio Castro, Lad Prabhakar
On Fri, Oct 4, 2024 at 2:37 PM Prabhakar <prabhakar.csengg@gmail.com> wrote:
> From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
>
> Add support for enabling and disabling open-drain outputs.
>
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> ---
> v1->v2
> - Implemented PIN_CONFIG_DRIVE_OPEN_DRAIN to disable open drain
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
i.e. will queue in renesas-pinctrl for v6.13.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH v2 2/3] pinctrl: renesas: rzg2l: Add support for enabling/disabling open-drain outputs
2024-10-04 12:36 ` [PATCH v2 2/3] pinctrl: renesas: rzg2l: Add support for enabling/disabling open-drain outputs Prabhakar
2024-10-04 13:05 ` Geert Uytterhoeven
@ 2024-10-09 7:53 ` claudiu beznea
1 sibling, 0 replies; 10+ messages in thread
From: claudiu beznea @ 2024-10-09 7:53 UTC (permalink / raw)
To: Prabhakar, Geert Uytterhoeven, Linus Walleij, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Magnus Damm
Cc: devicetree, linux-gpio, linux-kernel, linux-renesas-soc, Biju Das,
Fabrizio Castro, Lad Prabhakar
On 04.10.2024 15:36, Prabhakar wrote:
> From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
>
> Add support for enabling and disabling open-drain outputs.
>
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
I gave it a simple try on RZ/G3S. All good. You can add:
Tested-by: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
> ---
> v1->v2
> - Implemented PIN_CONFIG_DRIVE_OPEN_DRAIN to disable open drain
> ---
> drivers/pinctrl/renesas/pinctrl-rzg2l.c | 23 +++++++++++++++++++++++
> 1 file changed, 23 insertions(+)
>
> diff --git a/drivers/pinctrl/renesas/pinctrl-rzg2l.c b/drivers/pinctrl/renesas/pinctrl-rzg2l.c
> index b2d309f742af..8d576cc74003 100644
> --- a/drivers/pinctrl/renesas/pinctrl-rzg2l.c
> +++ b/drivers/pinctrl/renesas/pinctrl-rzg2l.c
> @@ -139,6 +139,7 @@
> #define IEN(off) (0x1800 + (off) * 8)
> #define PUPD(off) (0x1C00 + (off) * 8)
> #define ISEL(off) (0x2C00 + (off) * 8)
> +#define NOD(off) (0x3000 + (off) * 8)
> #define SD_CH(off, ch) ((off) + (ch) * 4)
> #define ETH_POC(off, ch) ((off) + (ch) * 4)
> #define QSPI (0x3008)
> @@ -160,6 +161,7 @@
> #define IOLH_MASK 0x03
> #define SR_MASK 0x01
> #define PUPD_MASK 0x03
> +#define NOD_MASK 0x01
>
> #define PM_INPUT 0x1
> #define PM_OUTPUT 0x2
> @@ -1337,6 +1339,18 @@ static int rzg2l_pinctrl_pinconf_get(struct pinctrl_dev *pctldev,
> break;
> }
>
> + case PIN_CONFIG_DRIVE_OPEN_DRAIN:
> + case PIN_CONFIG_DRIVE_PUSH_PULL:
> + if (!(cfg & PIN_CFG_NOD))
> + return -EINVAL;
> +
> + arg = rzg2l_read_pin_config(pctrl, NOD(off), bit, NOD_MASK);
> + if (!arg && param != PIN_CONFIG_DRIVE_PUSH_PULL)
> + return -EINVAL;
> + if (arg && param != PIN_CONFIG_DRIVE_OPEN_DRAIN)
> + return -EINVAL;
> + break;
> +
> case RENESAS_RZV2H_PIN_CONFIG_OUTPUT_IMPEDANCE:
> if (!(cfg & PIN_CFG_IOLH_RZV2H))
> return -EINVAL;
> @@ -1466,6 +1480,15 @@ static int rzg2l_pinctrl_pinconf_set(struct pinctrl_dev *pctldev,
> rzg2l_rmw_pin_config(pctrl, IOLH(off), bit, IOLH_MASK, index);
> break;
>
> + case PIN_CONFIG_DRIVE_OPEN_DRAIN:
> + case PIN_CONFIG_DRIVE_PUSH_PULL:
> + if (!(cfg & PIN_CFG_NOD))
> + return -EINVAL;
> +
> + rzg2l_rmw_pin_config(pctrl, NOD(off), bit, NOD_MASK,
> + param == PIN_CONFIG_DRIVE_OPEN_DRAIN ? 1 : 0);
> + break;
> +
> case RENESAS_RZV2H_PIN_CONFIG_OUTPUT_IMPEDANCE:
> if (!(cfg & PIN_CFG_IOLH_RZV2H))
> return -EINVAL;
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH v2 3/3] pinctrl: renesas: rzg2l: Add support for configuring schmitt-trigger
2024-10-04 12:36 [PATCH v2 0/3] pinctrl: renesas: rzg2l: Add support to configure open-drain and schmitt-trigger properties Prabhakar
2024-10-04 12:36 ` [PATCH v2 1/3] dt-bindings: pinctrl: renesas,rzg2l-pinctrl: Allow schmitt and open drain properties Prabhakar
2024-10-04 12:36 ` [PATCH v2 2/3] pinctrl: renesas: rzg2l: Add support for enabling/disabling open-drain outputs Prabhakar
@ 2024-10-04 12:36 ` Prabhakar
2024-10-04 13:06 ` Geert Uytterhoeven
2024-10-09 7:53 ` claudiu beznea
2 siblings, 2 replies; 10+ messages in thread
From: Prabhakar @ 2024-10-04 12:36 UTC (permalink / raw)
To: Geert Uytterhoeven, Linus Walleij, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Magnus Damm
Cc: devicetree, linux-gpio, linux-kernel, linux-renesas-soc,
Prabhakar, Biju Das, Fabrizio Castro, Lad Prabhakar
From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Add support for configuring the multiplexed pins as schmitt-trigger
inputs.
Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
v1->v2
- Included RB tag
---
drivers/pinctrl/renesas/pinctrl-rzg2l.c | 18 ++++++++++++++++++
1 file changed, 18 insertions(+)
diff --git a/drivers/pinctrl/renesas/pinctrl-rzg2l.c b/drivers/pinctrl/renesas/pinctrl-rzg2l.c
index 8d576cc74003..13708c71f938 100644
--- a/drivers/pinctrl/renesas/pinctrl-rzg2l.c
+++ b/drivers/pinctrl/renesas/pinctrl-rzg2l.c
@@ -140,6 +140,7 @@
#define PUPD(off) (0x1C00 + (off) * 8)
#define ISEL(off) (0x2C00 + (off) * 8)
#define NOD(off) (0x3000 + (off) * 8)
+#define SMT(off) (0x3400 + (off) * 8)
#define SD_CH(off, ch) ((off) + (ch) * 4)
#define ETH_POC(off, ch) ((off) + (ch) * 4)
#define QSPI (0x3008)
@@ -162,6 +163,7 @@
#define SR_MASK 0x01
#define PUPD_MASK 0x03
#define NOD_MASK 0x01
+#define SMT_MASK 0x01
#define PM_INPUT 0x1
#define PM_OUTPUT 0x2
@@ -1351,6 +1353,15 @@ static int rzg2l_pinctrl_pinconf_get(struct pinctrl_dev *pctldev,
return -EINVAL;
break;
+ case PIN_CONFIG_INPUT_SCHMITT_ENABLE:
+ if (!(cfg & PIN_CFG_SMT))
+ return -EINVAL;
+
+ arg = rzg2l_read_pin_config(pctrl, SMT(off), bit, SMT_MASK);
+ if (!arg)
+ return -EINVAL;
+ break;
+
case RENESAS_RZV2H_PIN_CONFIG_OUTPUT_IMPEDANCE:
if (!(cfg & PIN_CFG_IOLH_RZV2H))
return -EINVAL;
@@ -1489,6 +1500,13 @@ static int rzg2l_pinctrl_pinconf_set(struct pinctrl_dev *pctldev,
param == PIN_CONFIG_DRIVE_OPEN_DRAIN ? 1 : 0);
break;
+ case PIN_CONFIG_INPUT_SCHMITT_ENABLE:
+ if (!(cfg & PIN_CFG_SMT))
+ return -EINVAL;
+
+ rzg2l_rmw_pin_config(pctrl, SMT(off), bit, SMT_MASK, arg);
+ break;
+
case RENESAS_RZV2H_PIN_CONFIG_OUTPUT_IMPEDANCE:
if (!(cfg & PIN_CFG_IOLH_RZV2H))
return -EINVAL;
--
2.43.0
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH v2 3/3] pinctrl: renesas: rzg2l: Add support for configuring schmitt-trigger
2024-10-04 12:36 ` [PATCH v2 3/3] pinctrl: renesas: rzg2l: Add support for configuring schmitt-trigger Prabhakar
@ 2024-10-04 13:06 ` Geert Uytterhoeven
2024-10-09 7:53 ` claudiu beznea
1 sibling, 0 replies; 10+ messages in thread
From: Geert Uytterhoeven @ 2024-10-04 13:06 UTC (permalink / raw)
To: Prabhakar
Cc: Linus Walleij, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Magnus Damm, devicetree, linux-gpio, linux-kernel,
linux-renesas-soc, Biju Das, Fabrizio Castro, Lad Prabhakar
On Fri, Oct 4, 2024 at 2:37 PM Prabhakar <prabhakar.csengg@gmail.com> wrote:
> From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
>
> Add support for configuring the multiplexed pins as schmitt-trigger
> inputs.
>
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> v1->v2
> - Included RB tag
Thanks, will queue in renesas-pinctrl for v6.13.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH v2 3/3] pinctrl: renesas: rzg2l: Add support for configuring schmitt-trigger
2024-10-04 12:36 ` [PATCH v2 3/3] pinctrl: renesas: rzg2l: Add support for configuring schmitt-trigger Prabhakar
2024-10-04 13:06 ` Geert Uytterhoeven
@ 2024-10-09 7:53 ` claudiu beznea
1 sibling, 0 replies; 10+ messages in thread
From: claudiu beznea @ 2024-10-09 7:53 UTC (permalink / raw)
To: Prabhakar, Geert Uytterhoeven, Linus Walleij, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Magnus Damm
Cc: devicetree, linux-gpio, linux-kernel, linux-renesas-soc, Biju Das,
Fabrizio Castro, Lad Prabhakar
On 04.10.2024 15:36, Prabhakar wrote:
> From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
>
> Add support for configuring the multiplexed pins as schmitt-trigger
> inputs.
>
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Same here:
Tested-by: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
> ---
v1->v2
> - Included RB tag
> ---
> drivers/pinctrl/renesas/pinctrl-rzg2l.c | 18 ++++++++++++++++++
> 1 file changed, 18 insertions(+)
>
> diff --git a/drivers/pinctrl/renesas/pinctrl-rzg2l.c b/drivers/pinctrl/renesas/pinctrl-rzg2l.c
> index 8d576cc74003..13708c71f938 100644
> --- a/drivers/pinctrl/renesas/pinctrl-rzg2l.c
> +++ b/drivers/pinctrl/renesas/pinctrl-rzg2l.c
> @@ -140,6 +140,7 @@
> #define PUPD(off) (0x1C00 + (off) * 8)
> #define ISEL(off) (0x2C00 + (off) * 8)
> #define NOD(off) (0x3000 + (off) * 8)
> +#define SMT(off) (0x3400 + (off) * 8)
> #define SD_CH(off, ch) ((off) + (ch) * 4)
> #define ETH_POC(off, ch) ((off) + (ch) * 4)
> #define QSPI (0x3008)
> @@ -162,6 +163,7 @@
> #define SR_MASK 0x01
> #define PUPD_MASK 0x03
> #define NOD_MASK 0x01
> +#define SMT_MASK 0x01
>
> #define PM_INPUT 0x1
> #define PM_OUTPUT 0x2
> @@ -1351,6 +1353,15 @@ static int rzg2l_pinctrl_pinconf_get(struct pinctrl_dev *pctldev,
> return -EINVAL;
> break;
>
> + case PIN_CONFIG_INPUT_SCHMITT_ENABLE:
> + if (!(cfg & PIN_CFG_SMT))
> + return -EINVAL;
> +
> + arg = rzg2l_read_pin_config(pctrl, SMT(off), bit, SMT_MASK);
> + if (!arg)
> + return -EINVAL;
> + break;
> +
> case RENESAS_RZV2H_PIN_CONFIG_OUTPUT_IMPEDANCE:
> if (!(cfg & PIN_CFG_IOLH_RZV2H))
> return -EINVAL;
> @@ -1489,6 +1500,13 @@ static int rzg2l_pinctrl_pinconf_set(struct pinctrl_dev *pctldev,
> param == PIN_CONFIG_DRIVE_OPEN_DRAIN ? 1 : 0);
> break;
>
> + case PIN_CONFIG_INPUT_SCHMITT_ENABLE:
> + if (!(cfg & PIN_CFG_SMT))
> + return -EINVAL;
> +
> + rzg2l_rmw_pin_config(pctrl, SMT(off), bit, SMT_MASK, arg);
> + break;
> +
> case RENESAS_RZV2H_PIN_CONFIG_OUTPUT_IMPEDANCE:
> if (!(cfg & PIN_CFG_IOLH_RZV2H))
> return -EINVAL;
^ permalink raw reply [flat|nested] 10+ messages in thread