From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Subject: Re: [PATCH v2] gpio: interrupt consistency check for OF GPIO IRQs Date: Thu, 22 Aug 2013 14:53:09 -0600 Message-ID: <52167A35.2010109@wwwdotorg.org> References: <1377092334-770-1-git-send-email-larsi@wh2.tu-dresden.de> <1507189.CRWvzVJqTV@flatron> <521548E3.6010703@wwwdotorg.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: Received: from avon.wwwdotorg.org ([70.85.31.133]:49022 "EHLO avon.wwwdotorg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752926Ab3HVUxP (ORCPT ); Thu, 22 Aug 2013 16:53:15 -0400 In-Reply-To: Sender: linux-gpio-owner@vger.kernel.org List-Id: linux-gpio@vger.kernel.org To: Linus Walleij Cc: Tomasz Figa , Lars Poeschel , Lars Poeschel , Grant Likely , "linux-gpio@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" , Mark Rutland , Ian Campbell , galak@codeaurora.org, Pawel Moll , Javier Martinez Canillas , Enric Balletbo i Serra , Jean-Christophe PLAGNIOL-VILLARD , Santosh Shilimkar , Kevin Hilman , Balaji T K , Tony Lindgren , Jon Hunter On 08/21/2013 05:27 PM, Linus Walleij wrote: > On Thu, Aug 22, 2013 at 1:10 AM, Stephen Warren wrote: >>> On Wednesday 21 of August 2013 15:38:54 Lars Poeschel wrote: > >>>> To solve this dilemma, perform an interrupt consistency check >>>> when adding a GPIO chip: if the chip is both gpio-controller and >>>> interrupt-controller, walk all children of the device tree, >> >> It seems a little odd to solve this only for DT. What about the non-DT case? > > DT is the hardware configuration system that lets you request > the same resource in two ways, i.e. it allows one and the same > node to be both gpio-controller and interrupt-controller, and > start handing out the same line as both GPIO and IRQ > independently. Huh? What stops systems using board files and platform data from having this issue?