From: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Kevin Hilman <khilman@linaro.org>,
Santosh Shilimkar <santosh.shilimkar@ti.com>,
Stephen Warren <swarren@wwwdotorg.org>,
Lars Poeschel <larsi@wh2.tu-dresden.de>,
Grant Likely <grant.likely@linaro.org>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ian.campbell@citrix.com>,
Kumar Gala <galak@codeaurora.org>,
Pawel Moll <pawel.moll@arm.com>,
Tomasz Figa <tomasz.figa@gmail.com>,
Enric Balletbo i Serra <eballetbo@gmail.com>,
Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>,
Balaji T K <balajitk@ti.com>, Tony Lindgren <tony@atomide.com>,
Jon Hunter <jgchunter@gmail.com>,
linux-gpio@vger.kernel.org, linux-omap@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
r.sricharan@ti.com, holler@ahsoftware.de
Subject: Re: [PATCH 1/2] gpio/omap: maintain GPIO and IRQ usage separately
Date: Tue, 01 Oct 2013 09:34:24 +0200 [thread overview]
Message-ID: <524A7B00.4010001@collabora.co.uk> (raw)
In-Reply-To: <87r4cajfx0.fsf@linaro.org>
On 09/27/2013 08:08 PM, Kevin Hilman wrote:
> Javier Martinez Canillas <javier.martinez@collabora.co.uk> writes:
>
>> The GPIO OMAP controller pins can be used as IRQ and GPIO
>> independently so is necessary to keep track GPIO pins and
>> IRQ lines usage separately to make sure that the bank will
>> always be enabled while being used.
>>
>> Also move gpio_is_input() definition in preparation for the
>> next patch that setups the controller's irq_chip driver when
>> a caller requests an interrupt line.
>>
>> Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
>
> I'm fine with this appproach. For both patches:
>
> Reviewed-by: Kevin Hilman <khilman@linaro.org>
>
> Also, I gave it a spin across a handful of OMAP boards using v3.12-rc2 +
> these 2 patches.
>
> Boot tested successfully with DT boot:
>
> omap3530/beagle
> omap3730/beagle-xm
> omap3530/overo (Tobi w/GPIO IRQ networking)
> omap3730/overo STORM (w/GPIO IRQ for networking)
> am335x/beaglebone
> am335x/beaglebone black
> omap4430/panda
> omap4460/panda-es
> omap5912/OSK (omap1)
>
> I also verified non-DT boot on the OMAP3 platforms that still support
> legacy boot.
>
> So feel free to also add
>
> Tested-by: Kevin Hilman <khilman@linaro.org>
>
> Thanks for your persistence in getting a fix for this upstream.
>
> Kevin
>
Thanks a lot Kevin for testing on so many boards.
Linus,
Since this patch-set doesn't cause any regression and fix a long standing issue
on OMAP, do you think that it would be possible to include on the -rc series as
a bugfix or do you prefer to wait until 3.13?
Thanks a lot and best regards,
Javier
next prev parent reply other threads:[~2013-10-01 7:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-25 0:36 [PATCH 1/2] gpio/omap: maintain GPIO and IRQ usage separately Javier Martinez Canillas
2013-09-25 0:36 ` [PATCH 2/2] gpio/omap: auto-setup a GPIO when used as an IRQ Javier Martinez Canillas
2013-09-25 0:36 ` Javier Martinez Canillas
[not found] ` <1380069414-2922-1-git-send-email-javier.martinez-ZGY8ohtN/8pPYcu2f3hruQ@public.gmane.org>
2013-09-27 14:31 ` [PATCH 1/2] gpio/omap: maintain GPIO and IRQ usage separately Lars Poeschel
2013-09-27 18:08 ` Kevin Hilman
2013-10-01 7:34 ` Javier Martinez Canillas [this message]
[not found] ` <524A7B00.4010001-ZGY8ohtN/8pPYcu2f3hruQ@public.gmane.org>
2013-10-01 11:14 ` Linus Walleij
2013-09-27 19:31 ` Santosh Shilimkar
2013-09-27 21:01 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=524A7B00.4010001@collabora.co.uk \
--to=javier.martinez@collabora.co.uk \
--cc=balajitk@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=eballetbo@gmail.com \
--cc=galak@codeaurora.org \
--cc=grant.likely@linaro.org \
--cc=holler@ahsoftware.de \
--cc=ian.campbell@citrix.com \
--cc=jgchunter@gmail.com \
--cc=khilman@linaro.org \
--cc=larsi@wh2.tu-dresden.de \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=plagnioj@jcrosoft.com \
--cc=r.sricharan@ti.com \
--cc=santosh.shilimkar@ti.com \
--cc=swarren@wwwdotorg.org \
--cc=tomasz.figa@gmail.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).