From: David Cohen <david.a.cohen@linux.intel.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: linux-gpio@vger.kernel.org, Alexandre Courbot <acourbot@nvidia.com>
Subject: Re: [PATCH] gpio: intel-mid: drop references to "virtual" IRQ
Date: Fri, 11 Oct 2013 13:00:46 -0700 [thread overview]
Message-ID: <525858EE.3070002@linux.intel.com> (raw)
In-Reply-To: <1381512495-6917-1-git-send-email-linus.walleij@linaro.org>
Hi Linus,
On 10/11/2013 10:28 AM, Linus Walleij wrote:
> Rename the argument "virq" to just "irq", this IRQ isn't any
> more "virtual" than any other Linux IRQ number, we use "hwirq"
> for the actual hw-numbers, "virq" is just bogus.
Sounds a good change. Thanks.
>
> Cc: David Cohen <david.a.cohen@linux.intel.com>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Acked-by: David Cohen <david.a.cohen@linux.intel.com>
> ---
> drivers/gpio/gpio-intel-mid.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/gpio/gpio-intel-mid.c b/drivers/gpio/gpio-intel-mid.c
> index 612b54d..be803af 100644
> --- a/drivers/gpio/gpio-intel-mid.c
> +++ b/drivers/gpio/gpio-intel-mid.c
> @@ -353,15 +353,15 @@ static void intel_mid_irq_init_hw(struct intel_mid_gpio *priv)
> }
> }
>
> -static int intel_gpio_irq_map(struct irq_domain *d, unsigned int virq,
> - irq_hw_number_t hw)
> +static int intel_gpio_irq_map(struct irq_domain *d, unsigned int irq,
> + irq_hw_number_t hwirq)
> {
> struct intel_mid_gpio *priv = d->host_data;
>
> - irq_set_chip_and_handler_name(virq, &intel_mid_irqchip,
> + irq_set_chip_and_handler_name(irq, &intel_mid_irqchip,
> handle_simple_irq, "demux");
> - irq_set_chip_data(virq, priv);
> - irq_set_irq_type(virq, IRQ_TYPE_NONE);
> + irq_set_chip_data(irq, priv);
> + irq_set_irq_type(irq, IRQ_TYPE_NONE);
>
> return 0;
> }
>
prev parent reply other threads:[~2013-10-11 20:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-11 17:28 [PATCH] gpio: intel-mid: drop references to "virtual" IRQ Linus Walleij
2013-10-11 20:00 ` David Cohen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=525858EE.3070002@linux.intel.com \
--to=david.a.cohen@linux.intel.com \
--cc=acourbot@nvidia.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).