* [PATCH] gpio: intel-mid: drop references to "virtual" IRQ
@ 2013-10-11 17:28 Linus Walleij
2013-10-11 20:00 ` David Cohen
0 siblings, 1 reply; 2+ messages in thread
From: Linus Walleij @ 2013-10-11 17:28 UTC (permalink / raw)
To: linux-gpio; +Cc: Alexandre Courbot, Linus Walleij, David Cohen
Rename the argument "virq" to just "irq", this IRQ isn't any
more "virtual" than any other Linux IRQ number, we use "hwirq"
for the actual hw-numbers, "virq" is just bogus.
Cc: David Cohen <david.a.cohen@linux.intel.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
drivers/gpio/gpio-intel-mid.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/gpio/gpio-intel-mid.c b/drivers/gpio/gpio-intel-mid.c
index 612b54d..be803af 100644
--- a/drivers/gpio/gpio-intel-mid.c
+++ b/drivers/gpio/gpio-intel-mid.c
@@ -353,15 +353,15 @@ static void intel_mid_irq_init_hw(struct intel_mid_gpio *priv)
}
}
-static int intel_gpio_irq_map(struct irq_domain *d, unsigned int virq,
- irq_hw_number_t hw)
+static int intel_gpio_irq_map(struct irq_domain *d, unsigned int irq,
+ irq_hw_number_t hwirq)
{
struct intel_mid_gpio *priv = d->host_data;
- irq_set_chip_and_handler_name(virq, &intel_mid_irqchip,
+ irq_set_chip_and_handler_name(irq, &intel_mid_irqchip,
handle_simple_irq, "demux");
- irq_set_chip_data(virq, priv);
- irq_set_irq_type(virq, IRQ_TYPE_NONE);
+ irq_set_chip_data(irq, priv);
+ irq_set_irq_type(irq, IRQ_TYPE_NONE);
return 0;
}
--
1.8.3.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] gpio: intel-mid: drop references to "virtual" IRQ
2013-10-11 17:28 [PATCH] gpio: intel-mid: drop references to "virtual" IRQ Linus Walleij
@ 2013-10-11 20:00 ` David Cohen
0 siblings, 0 replies; 2+ messages in thread
From: David Cohen @ 2013-10-11 20:00 UTC (permalink / raw)
To: Linus Walleij; +Cc: linux-gpio, Alexandre Courbot
Hi Linus,
On 10/11/2013 10:28 AM, Linus Walleij wrote:
> Rename the argument "virq" to just "irq", this IRQ isn't any
> more "virtual" than any other Linux IRQ number, we use "hwirq"
> for the actual hw-numbers, "virq" is just bogus.
Sounds a good change. Thanks.
>
> Cc: David Cohen <david.a.cohen@linux.intel.com>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Acked-by: David Cohen <david.a.cohen@linux.intel.com>
> ---
> drivers/gpio/gpio-intel-mid.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/gpio/gpio-intel-mid.c b/drivers/gpio/gpio-intel-mid.c
> index 612b54d..be803af 100644
> --- a/drivers/gpio/gpio-intel-mid.c
> +++ b/drivers/gpio/gpio-intel-mid.c
> @@ -353,15 +353,15 @@ static void intel_mid_irq_init_hw(struct intel_mid_gpio *priv)
> }
> }
>
> -static int intel_gpio_irq_map(struct irq_domain *d, unsigned int virq,
> - irq_hw_number_t hw)
> +static int intel_gpio_irq_map(struct irq_domain *d, unsigned int irq,
> + irq_hw_number_t hwirq)
> {
> struct intel_mid_gpio *priv = d->host_data;
>
> - irq_set_chip_and_handler_name(virq, &intel_mid_irqchip,
> + irq_set_chip_and_handler_name(irq, &intel_mid_irqchip,
> handle_simple_irq, "demux");
> - irq_set_chip_data(virq, priv);
> - irq_set_irq_type(virq, IRQ_TYPE_NONE);
> + irq_set_chip_data(irq, priv);
> + irq_set_irq_type(irq, IRQ_TYPE_NONE);
>
> return 0;
> }
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-10-11 20:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-10-11 17:28 [PATCH] gpio: intel-mid: drop references to "virtual" IRQ Linus Walleij
2013-10-11 20:00 ` David Cohen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).