* [PATCH 2/4] ALSA: atmel: remove dependency on <mach/gpio.h>
@ 2013-11-05 9:29 Linus Walleij
2013-11-05 9:48 ` Nicolas Ferre
2013-11-05 12:44 ` Takashi Iwai
0 siblings, 2 replies; 3+ messages in thread
From: Linus Walleij @ 2013-11-05 9:29 UTC (permalink / raw)
To: linux-gpio, Andrew Victor, Nicolas Ferre,
Jean-Christophe Plagniol-Villard, Liam Girdwood, Mark Brown
Cc: Alexandre Courbot, linux-arm-kernel, Linus Walleij,
Jaroslav Kysela, Takashi Iwai
This include is completely unused since the AT91 sound driver
actually uses gpiolib properly.
Cc: Liam Girdwood <lgirdwood@gmail.com>
Cc: Mark Brown <broonie@kernel.org>
Cc: Jaroslav Kysela <perex@perex.cz>
Cc: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
ALSA SoC folks: please apply this as a fix if you wish, else
I'd like an ACK so I can merge it in front of the dependent
patches in the next (v3.14) merge cycle.
---
sound/atmel/ac97c.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/sound/atmel/ac97c.c b/sound/atmel/ac97c.c
index ae63d22c0f88..c5f0ddd729b3 100644
--- a/sound/atmel/ac97c.c
+++ b/sound/atmel/ac97c.c
@@ -34,7 +34,6 @@
#include <linux/dw_dmac.h>
#include <mach/cpu.h>
-#include <mach/gpio.h>
#ifdef CONFIG_ARCH_AT91
#include <mach/hardware.h>
--
1.8.3.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 2/4] ALSA: atmel: remove dependency on <mach/gpio.h>
2013-11-05 9:29 [PATCH 2/4] ALSA: atmel: remove dependency on <mach/gpio.h> Linus Walleij
@ 2013-11-05 9:48 ` Nicolas Ferre
2013-11-05 12:44 ` Takashi Iwai
1 sibling, 0 replies; 3+ messages in thread
From: Nicolas Ferre @ 2013-11-05 9:48 UTC (permalink / raw)
To: Linus Walleij, linux-gpio, Andrew Victor,
Jean-Christophe Plagniol-Villard, Liam Girdwood, Mark Brown
Cc: Alexandre Courbot, linux-arm-kernel, Jaroslav Kysela,
Takashi Iwai
On 05/11/2013 10:29, Linus Walleij :
> This include is completely unused since the AT91 sound driver
> actually uses gpiolib properly.
Absolutely:
Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>
Thanks Linus.
> Cc: Liam Girdwood <lgirdwood@gmail.com>
> Cc: Mark Brown <broonie@kernel.org>
> Cc: Jaroslav Kysela <perex@perex.cz>
> Cc: Takashi Iwai <tiwai@suse.de>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
> ALSA SoC folks: please apply this as a fix if you wish, else
> I'd like an ACK so I can merge it in front of the dependent
> patches in the next (v3.14) merge cycle.
> ---
> sound/atmel/ac97c.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/sound/atmel/ac97c.c b/sound/atmel/ac97c.c
> index ae63d22c0f88..c5f0ddd729b3 100644
> --- a/sound/atmel/ac97c.c
> +++ b/sound/atmel/ac97c.c
> @@ -34,7 +34,6 @@
> #include <linux/dw_dmac.h>
>
> #include <mach/cpu.h>
> -#include <mach/gpio.h>
>
> #ifdef CONFIG_ARCH_AT91
> #include <mach/hardware.h>
>
--
Nicolas Ferre
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 2/4] ALSA: atmel: remove dependency on <mach/gpio.h>
2013-11-05 9:29 [PATCH 2/4] ALSA: atmel: remove dependency on <mach/gpio.h> Linus Walleij
2013-11-05 9:48 ` Nicolas Ferre
@ 2013-11-05 12:44 ` Takashi Iwai
1 sibling, 0 replies; 3+ messages in thread
From: Takashi Iwai @ 2013-11-05 12:44 UTC (permalink / raw)
To: Linus Walleij
Cc: linux-gpio, Andrew Victor, Nicolas Ferre,
Jean-Christophe Plagniol-Villard, Liam Girdwood, Mark Brown,
Alexandre Courbot, linux-arm-kernel, Jaroslav Kysela
At Tue, 5 Nov 2013 10:29:49 +0100,
Linus Walleij wrote:
>
> This include is completely unused since the AT91 sound driver
> actually uses gpiolib properly.
>
> Cc: Liam Girdwood <lgirdwood@gmail.com>
> Cc: Mark Brown <broonie@kernel.org>
> Cc: Jaroslav Kysela <perex@perex.cz>
> Cc: Takashi Iwai <tiwai@suse.de>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
> ALSA SoC folks: please apply this as a fix if you wish, else
> I'd like an ACK so I can merge it in front of the dependent
> patches in the next (v3.14) merge cycle.
Thanks, I applied the patch now.
Takashi
> ---
> sound/atmel/ac97c.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/sound/atmel/ac97c.c b/sound/atmel/ac97c.c
> index ae63d22c0f88..c5f0ddd729b3 100644
> --- a/sound/atmel/ac97c.c
> +++ b/sound/atmel/ac97c.c
> @@ -34,7 +34,6 @@
> #include <linux/dw_dmac.h>
>
> #include <mach/cpu.h>
> -#include <mach/gpio.h>
>
> #ifdef CONFIG_ARCH_AT91
> #include <mach/hardware.h>
> --
> 1.8.3.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-11-05 12:44 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-11-05 9:29 [PATCH 2/4] ALSA: atmel: remove dependency on <mach/gpio.h> Linus Walleij
2013-11-05 9:48 ` Nicolas Ferre
2013-11-05 12:44 ` Takashi Iwai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).