From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Eremin-Solenikov Subject: Re: [PATCH 0/9] ARM: sa1100: Rework IRQ handling Date: Fri, 22 Nov 2013 21:33:32 +0400 Message-ID: <528F956C.5040107@gmail.com> References: <1384505280-25389-1-git-send-email-dbaryshkov@gmail.com> <528B811A.1030501@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from mail-wg0-f53.google.com ([74.125.82.53]:58594 "EHLO mail-wg0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753339Ab3KVRdj (ORCPT ); Fri, 22 Nov 2013 12:33:39 -0500 Received: by mail-wg0-f53.google.com with SMTP id b13so1468565wgh.20 for ; Fri, 22 Nov 2013 09:33:38 -0800 (PST) In-Reply-To: Sender: linux-gpio-owner@vger.kernel.org List-Id: linux-gpio@vger.kernel.org To: Linus Walleij Cc: "linux-arm-kernel@lists.infradead.org" , "linux-gpio@vger.kernel.org" , Russell King , Dmitry Artamonow On 11/20/2013 12:24 AM, Linus Walleij wrote: > On Tue, Nov 19, 2013 at 4:17 PM, Dmitry Eremin-Solenikov > wrote: >> On 11/19/2013 05:00 PM, Linus Walleij wrote: > >>> And that happens before the GPIO driver gets registered -> crash. >> >> That is not the issue. The real issue is h3xxx using those gpio's without >> previously calling gpio_request. > > Really? But that wasn't done before this patch either. > > It is basically OK to use the gpio_* functions before or > without requesting the GPIOs, it won't look nice but it > works. > >> Unfortunately sa1100 driver doesn't have a >> good place to request gpios. When faced this problem during locomo >> refactoring, I ended up with the following piece of code: > (...) >> Russell, Linus, what do you think about the previous solution? > > That looks OK but is that really the problem? I have reworked h3xxx GPIO handling to (hopefully) not to cause the problem. I have sent the patches yesterday. Linus, Could you please check if both series work (and make sense to you)? -- With best wishes Dmitry