[PATCH 7/7] drivers/gpio: don't check resource with devm_ioremap_resource

[PATCH 7/7] drivers/gpio: don't check resource with devm_ioremap_resource

[Wolfram Sang]

devm_ioremap_resource does sanity checks on the given resource. No need to
duplicate this in the driver.

Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
---

Should go via subsystem tree

 drivers/gpio/gpio-davinci.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/drivers/gpio/gpio-davinci.c b/drivers/gpio/gpio-davinci.c
index 84be701..a5e1a56 100644
--- a/drivers/gpio/gpio-davinci.c
+++ b/drivers/gpio/gpio-davinci.c
@@ -172,11 +172,6 @@ static int davinci_gpio_probe(struct platform_device *pdev)
 	}
 
 	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-	if (!res) {
-		dev_err(dev, "Invalid memory resource\n");
-		return -EBUSY;
-	}
-
 	gpio_base = devm_ioremap_resource(dev, res);
 	if (IS_ERR(gpio_base))
 		return PTR_ERR(gpio_base);
-- 
1.8.5.1

Re: [PATCH 7/7] drivers/gpio: don't check resource with devm_ioremap_resource

[Linus Walleij]

On Tue, Jan 14, 2014 at 12:58 PM, Wolfram Sang <wsa@the-dreams.de> wrote:

> devm_ioremap_resource does sanity checks on the given resource. No need to
> duplicate this in the driver.
>
> Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
> ---
>
> Should go via subsystem tree
>
>  drivers/gpio/gpio-davinci.c | 5 -----
>  1 file changed, 5 deletions(-)
>
> diff --git a/drivers/gpio/gpio-davinci.c b/drivers/gpio/gpio-davinci.c
> index 84be701..a5e1a56 100644
> --- a/drivers/gpio/gpio-davinci.c
> +++ b/drivers/gpio/gpio-davinci.c
> @@ -172,11 +172,6 @@ static int davinci_gpio_probe(struct platform_device *pdev)
>         }
>
>         res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -       if (!res) {
> -               dev_err(dev, "Invalid memory resource\n");
> -               return -EBUSY;
> -       }
> -
>         gpio_base = devm_ioremap_resource(dev, res);
>         if (IS_ERR(gpio_base))
>                 return PTR_ERR(gpio_base);

Acked-by: Linus Walleij <linus.walleij@linaro.org>

The DaVinci maintainers are queuing GPIO patches for their driver
for this merge window, so requesting them to apply this patch.

Yours,
Linus Walleij

Re: [PATCH 7/7] drivers/gpio: don't check resource with devm_ioremap_resource

[Sekhar Nori]

On Wednesday 15 January 2014 02:58 PM, Linus Walleij wrote:
> On Tue, Jan 14, 2014 at 12:58 PM, Wolfram Sang <wsa@the-dreams.de> wrote:
> 
>> devm_ioremap_resource does sanity checks on the given resource. No need to
>> duplicate this in the driver.
>>
>> Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
>> ---
>>
>> Should go via subsystem tree
>>
>>  drivers/gpio/gpio-davinci.c | 5 -----
>>  1 file changed, 5 deletions(-)
>>
>> diff --git a/drivers/gpio/gpio-davinci.c b/drivers/gpio/gpio-davinci.c
>> index 84be701..a5e1a56 100644
>> --- a/drivers/gpio/gpio-davinci.c
>> +++ b/drivers/gpio/gpio-davinci.c
>> @@ -172,11 +172,6 @@ static int davinci_gpio_probe(struct platform_device *pdev)
>>         }
>>
>>         res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
>> -       if (!res) {
>> -               dev_err(dev, "Invalid memory resource\n");
>> -               return -EBUSY;
>> -       }
>> -
>>         gpio_base = devm_ioremap_resource(dev, res);
>>         if (IS_ERR(gpio_base))
>>                 return PTR_ERR(gpio_base);
> 
> Acked-by: Linus Walleij <linus.walleij@linaro.org>
> 
> The DaVinci maintainers are queuing GPIO patches for their driver
> for this merge window, so requesting them to apply this patch.

I wont be sending any more pull requests for v3.14. Even if I send, the
ARM-SoC maintainers will not take it anyway. So likely this wont get
into v3.14. For v3.15, Linus should be able to queue it as dependencies
would have made it into the kernel by then.

Thanks,
Sekhar

Re: [PATCH 7/7] drivers/gpio: don't check resource with devm_ioremap_resource

[Linus Walleij]

On Wed, Jan 15, 2014 at 1:54 PM, Sekhar Nori <nsekhar@ti.com> wrote:
> On Wednesday 15 January 2014 02:58 PM, Linus Walleij wrote:

>> Acked-by: Linus Walleij <linus.walleij@linaro.org>
>>
>> The DaVinci maintainers are queuing GPIO patches for their driver
>> for this merge window, so requesting them to apply this patch.
>
> I wont be sending any more pull requests for v3.14. Even if I send, the
> ARM-SoC maintainers will not take it anyway.

But as it is a fix I believe the ARM SoC maintainers will apply it
directly to the davinci branch.

Wolfram: I suggest you send this patch with my ACK directly
to arm@kernel.org and ask it to be applied to the davinci branch
in the ARM SoC tree.

Yours,
Linus Walleij

Re: [PATCH 7/7] drivers/gpio: don't check resource with devm_ioremap_resource

[Sekhar Nori]

On Wednesday 15 January 2014 07:21 PM, Linus Walleij wrote:
> On Wed, Jan 15, 2014 at 1:54 PM, Sekhar Nori <nsekhar@ti.com> wrote:
>> On Wednesday 15 January 2014 02:58 PM, Linus Walleij wrote:
> 
>>> Acked-by: Linus Walleij <linus.walleij@linaro.org>
>>>
>>> The DaVinci maintainers are queuing GPIO patches for their driver
>>> for this merge window, so requesting them to apply this patch.
>>
>> I wont be sending any more pull requests for v3.14. Even if I send, the
>> ARM-SoC maintainers will not take it anyway.
> 
> But as it is a fix I believe the ARM SoC maintainers will apply it
> directly to the davinci branch.

Sorry I did not realize this is a fix.

> 
> Wolfram: I suggest you send this patch with my ACK directly
> to arm@kernel.org and ask it to be applied to the davinci branch
> in the ARM SoC tree.

This would work too, I guess. Wolfram, can you please keep me in CC too
in case questions/actions come up?

Thanks,
Sekhar

Re: [PATCH 7/7] drivers/gpio: don't check resource with devm_ioremap_resource

[Kevin Hilman]

Sekhar Nori <nsekhar@ti.com> writes:

> On Wednesday 15 January 2014 07:21 PM, Linus Walleij wrote:
>> On Wed, Jan 15, 2014 at 1:54 PM, Sekhar Nori <nsekhar@ti.com> wrote:
>>> On Wednesday 15 January 2014 02:58 PM, Linus Walleij wrote:
>> 
>>>> Acked-by: Linus Walleij <linus.walleij@linaro.org>
>>>>
>>>> The DaVinci maintainers are queuing GPIO patches for their driver
>>>> for this merge window, so requesting them to apply this patch.
>>>
>>> I wont be sending any more pull requests for v3.14. Even if I send, the
>>> ARM-SoC maintainers will not take it anyway.
>> 
>> But as it is a fix I believe the ARM SoC maintainers will apply it
>> directly to the davinci branch.
>
> Sorry I did not realize this is a fix.
>
>> 
>> Wolfram: I suggest you send this patch with my ACK directly
>> to arm@kernel.org and ask it to be applied to the davinci branch
>> in the ARM SoC tree.
>
> This would work too, I guess. Wolfram, can you please keep me in CC too
> in case questions/actions come up?

Sekhar, I assume this is an ack from you too?  If so, Wolfram, please
include that in the patch submitted to arm-soc.

Kevin

Re: [PATCH 7/7] drivers/gpio: don't check resource with devm_ioremap_resource

[Sekhar Nori]

On Wednesday 15 January 2014 09:20 PM, Kevin Hilman wrote:
> Sekhar Nori <nsekhar@ti.com> writes:
> 
>> On Wednesday 15 January 2014 07:21 PM, Linus Walleij wrote:
>>> On Wed, Jan 15, 2014 at 1:54 PM, Sekhar Nori <nsekhar@ti.com> wrote:
>>>> On Wednesday 15 January 2014 02:58 PM, Linus Walleij wrote:
>>>
>>>>> Acked-by: Linus Walleij <linus.walleij@linaro.org>
>>>>>
>>>>> The DaVinci maintainers are queuing GPIO patches for their driver
>>>>> for this merge window, so requesting them to apply this patch.
>>>>
>>>> I wont be sending any more pull requests for v3.14. Even if I send, the
>>>> ARM-SoC maintainers will not take it anyway.
>>>
>>> But as it is a fix I believe the ARM SoC maintainers will apply it
>>> directly to the davinci branch.
>>
>> Sorry I did not realize this is a fix.
>>
>>>
>>> Wolfram: I suggest you send this patch with my ACK directly
>>> to arm@kernel.org and ask it to be applied to the davinci branch
>>> in the ARM SoC tree.
>>
>> This would work too, I guess. Wolfram, can you please keep me in CC too
>> in case questions/actions come up?
> 
> Sekhar, I assume this is an ack from you too?  If so, Wolfram, please
> include that in the patch submitted to arm-soc.

Wolfram, if you have not sent it already, please add:

Acked-by: Sekhar Nori <nsekhar@ti.com>

The branch to which the patch will be applied is davinci/gpio on
git://git.kernel.org/pub/scm/linux/kernel/git/arm/arm-soc.git. Please
rebase on this branch so it applies cleanly.

Thanks,
Sekhar

Re: [PATCH 7/7] drivers/gpio: don't check resource with devm_ioremap_resource

[Grygorii Strashko]

Hi Linus, Sekhar,

On 01/16/2014 06:29 AM, Sekhar Nori wrote:
> On Wednesday 15 January 2014 09:20 PM, Kevin Hilman wrote:
>> Sekhar Nori <nsekhar@ti.com> writes:
>>
>>> On Wednesday 15 January 2014 07:21 PM, Linus Walleij wrote:
>>>> On Wed, Jan 15, 2014 at 1:54 PM, Sekhar Nori <nsekhar@ti.com> wrote:
>>>>> On Wednesday 15 January 2014 02:58 PM, Linus Walleij wrote:
>>>>
>>>>>> Acked-by: Linus Walleij <linus.walleij@linaro.org>
>>>>>>
>>>>>> The DaVinci maintainers are queuing GPIO patches for their driver
>>>>>> for this merge window, so requesting them to apply this patch.
>>>>>
>>>>> I wont be sending any more pull requests for v3.14. Even if I send, the
>>>>> ARM-SoC maintainers will not take it anyway.
>>>>
>>>> But as it is a fix I believe the ARM SoC maintainers will apply it
>>>> directly to the davinci branch.
>>>
>>> Sorry I did not realize this is a fix.
>>>
>>>>
>>>> Wolfram: I suggest you send this patch with my ACK directly
>>>> to arm@kernel.org and ask it to be applied to the davinci branch
>>>> in the ARM SoC tree.
>>>
>>> This would work too, I guess. Wolfram, can you please keep me in CC too
>>> in case questions/actions come up?
>>
>> Sekhar, I assume this is an ack from you too?  If so, Wolfram, please
>> include that in the patch submitted to arm-soc.
> 
> Wolfram, if you have not sent it already, please add:
> 
> Acked-by: Sekhar Nori <nsekhar@ti.com>
> 
> The branch to which the patch will be applied is davinci/gpio on
> git://git.kernel.org/pub/scm/linux/kernel/git/arm/arm-soc.git. Please
> rebase on this branch so it applies cleanly.
> 

This patch is not in 3.14 yet. Are there any chances to have it in 3.14, 
as it introduces merge conflicts with future patches?

Regards,
-grygorii