From mboxrd@z Thu Jan 1 00:00:00 1970 From: "xinhui.pan" Subject: [PATCH] gpio-intel-mid: fix the incorrect return of idle callback Date: Tue, 28 Jan 2014 16:50:57 +0800 Message-ID: <52E76F71.4080304@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=GB2312 Content-Transfer-Encoding: 7bit Return-path: Received: from mga11.intel.com ([192.55.52.93]:29797 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754773AbaA1IvC (ORCPT ); Tue, 28 Jan 2014 03:51:02 -0500 Sender: linux-gpio-owner@vger.kernel.org List-Id: linux-gpio@vger.kernel.org To: linux-kernel@vger.kernel.org Cc: linux-gpio@vger.kernel.org, david.a.cohen@linux.intel.com, linus.walleij@linaro.org, gnurou@gmail.com, yanmin_zhang@linux.intel.com From: "xinhui.pan" intel_gpio_runtime_idle should return correct error code if it do fail. make it more correct even though -EBUSY is the most possible return value. Signed-off-by: bo.he Signed-off-by: xinhui.pan --- drivers/gpio/gpio-intel-mid.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpio/gpio-intel-mid.c b/drivers/gpio/gpio-intel-mid.c index d1b50ef..05749a3 100644 --- a/drivers/gpio/gpio-intel-mid.c +++ b/drivers/gpio/gpio-intel-mid.c @@ -394,7 +394,9 @@ static const struct irq_domain_ops intel_gpio_irq_ops = { static int intel_gpio_runtime_idle(struct device *dev) { - pm_schedule_suspend(dev, 500); + int err = pm_schedule_suspend(dev, 500); + if (err) + return err; return -EBUSY; } -- 1.7.9.5