* [patch] gpio: davinci: signedness bug in davinci_gpio_irq_setup()
@ 2014-01-09 5:28 Dan Carpenter
2014-01-15 7:21 ` Linus Walleij
0 siblings, 1 reply; 3+ messages in thread
From: Dan Carpenter @ 2014-01-09 5:28 UTC (permalink / raw)
To: Linus Walleij
Cc: Alexandre Courbot, linux-gpio, kernel-janitors, Grygorii Strashko
"irq" needs to be signed for the error handling to work.
Fixes: 6075a8b2b6c3 ('gpio: davinci: don't create irq_domain in case of unbanked irqs')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/gpio/gpio-davinci.c b/drivers/gpio/gpio-davinci.c
index 7629b4f12b7f..b0e98d379217 100644
--- a/drivers/gpio/gpio-davinci.c
+++ b/drivers/gpio/gpio-davinci.c
@@ -423,7 +423,7 @@ static const struct irq_domain_ops davinci_gpio_irq_ops = {
static int davinci_gpio_irq_setup(struct platform_device *pdev)
{
- unsigned gpio, irq, bank;
+ unsigned gpio, bank;
struct clk *clk;
u32 binten = 0;
unsigned ngpio, bank_irq;
@@ -433,6 +433,7 @@ static int davinci_gpio_irq_setup(struct platform_device *pdev)
struct davinci_gpio_platform_data *pdata = dev->platform_data;
struct davinci_gpio_regs __iomem *g;
struct irq_domain *irq_domain = NULL;
+ int irq;
ngpio = pdata->ngpio;
res = platform_get_resource(pdev, IORESOURCE_IRQ, 0);
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [patch] gpio: davinci: signedness bug in davinci_gpio_irq_setup()
2014-01-09 5:28 [patch] gpio: davinci: signedness bug in davinci_gpio_irq_setup() Dan Carpenter
@ 2014-01-15 7:21 ` Linus Walleij
2014-02-03 11:30 ` Grygorii Strashko
0 siblings, 1 reply; 3+ messages in thread
From: Linus Walleij @ 2014-01-15 7:21 UTC (permalink / raw)
To: Dan Carpenter, Santosh Shilimkar, Sekhar Nori, Kevin Hilman,
davinci-linux-open-source@linux.davincidsp.com
Cc: Alexandre Courbot, linux-gpio@vger.kernel.org, kernel-janitors,
Grygorii Strashko
On Thu, Jan 9, 2014 at 6:28 AM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> "irq" needs to be signed for the error handling to work.
>
> Fixes: 6075a8b2b6c3 ('gpio: davinci: don't create irq_domain in case of unbanked irqs')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/gpio/gpio-davinci.c b/drivers/gpio/gpio-davinci.c
> index 7629b4f12b7f..b0e98d379217 100644
> --- a/drivers/gpio/gpio-davinci.c
> +++ b/drivers/gpio/gpio-davinci.c
> @@ -423,7 +423,7 @@ static const struct irq_domain_ops davinci_gpio_irq_ops = {
>
> static int davinci_gpio_irq_setup(struct platform_device *pdev)
> {
> - unsigned gpio, irq, bank;
> + unsigned gpio, bank;
> struct clk *clk;
> u32 binten = 0;
> unsigned ngpio, bank_irq;
> @@ -433,6 +433,7 @@ static int davinci_gpio_irq_setup(struct platform_device *pdev)
> struct davinci_gpio_platform_data *pdata = dev->platform_data;
> struct davinci_gpio_regs __iomem *g;
> struct irq_domain *irq_domain = NULL;
> + int irq;
>
> ngpio = pdata->ngpio;
> res = platform_get_resource(pdev, IORESOURCE_IRQ, 0);
Acked-by: Linus Walleij <linus.walleij@linaro.org>
This merge window the DaVinci GPIO changes are queued by the DaVinci
maintainers (this patch does not even apply to my tree) so DaVinci guys:
please pick up this patch.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [patch] gpio: davinci: signedness bug in davinci_gpio_irq_setup()
2014-01-15 7:21 ` Linus Walleij
@ 2014-02-03 11:30 ` Grygorii Strashko
0 siblings, 0 replies; 3+ messages in thread
From: Grygorii Strashko @ 2014-02-03 11:30 UTC (permalink / raw)
To: Linus Walleij, Dan Carpenter, Santosh Shilimkar, Kevin Hilman,
davinci-linux-open-source@linux.davincidsp.com
Cc: Alexandre Courbot, linux-gpio@vger.kernel.org, kernel-janitors,
Sekhar Nori
Hi Linus, Sekhar,
On 01/15/2014 09:21 AM, Linus Walleij wrote:
> On Thu, Jan 9, 2014 at 6:28 AM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
>
>> "irq" needs to be signed for the error handling to work.
>>
>> Fixes: 6075a8b2b6c3 ('gpio: davinci: don't create irq_domain in case of unbanked irqs')
>> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>>
>> diff --git a/drivers/gpio/gpio-davinci.c b/drivers/gpio/gpio-davinci.c
>> index 7629b4f12b7f..b0e98d379217 100644
>> --- a/drivers/gpio/gpio-davinci.c
>> +++ b/drivers/gpio/gpio-davinci.c
>> @@ -423,7 +423,7 @@ static const struct irq_domain_ops davinci_gpio_irq_ops = {
>>
>> static int davinci_gpio_irq_setup(struct platform_device *pdev)
>> {
>> - unsigned gpio, irq, bank;
>> + unsigned gpio, bank;
>> struct clk *clk;
>> u32 binten = 0;
>> unsigned ngpio, bank_irq;
>> @@ -433,6 +433,7 @@ static int davinci_gpio_irq_setup(struct platform_device *pdev)
>> struct davinci_gpio_platform_data *pdata = dev->platform_data;
>> struct davinci_gpio_regs __iomem *g;
>> struct irq_domain *irq_domain = NULL;
>> + int irq;
>>
>> ngpio = pdata->ngpio;
>> res = platform_get_resource(pdev, IORESOURCE_IRQ, 0);
>
> Acked-by: Linus Walleij <linus.walleij@linaro.org>
>
> This merge window the DaVinci GPIO changes are queued by the DaVinci
> maintainers (this patch does not even apply to my tree) so DaVinci guys:
> please pick up this patch.
This patch is not in 3.14 yet. Are there any chances to have it in 3.14,
as it introduces merge conflicts with future patches?
Also, this is a fix.
Regards,
-grygorii
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-02-03 10:34 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-01-09 5:28 [patch] gpio: davinci: signedness bug in davinci_gpio_irq_setup() Dan Carpenter
2014-01-15 7:21 ` Linus Walleij
2014-02-03 11:30 ` Grygorii Strashko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).