* [PATCH 1/3] gpio: pca953x: Add devices to Kconfig help [not found] <972232456.119003.1391812066467.JavaMail.zimbra@xes-inc.com> @ 2014-02-07 22:35 ` Aaron Sierra 2014-02-12 15:21 ` Linus Walleij 2014-02-13 12:58 ` Linus Walleij 0 siblings, 2 replies; 5+ messages in thread From: Aaron Sierra @ 2014-02-07 22:35 UTC (permalink / raw) To: linux-gpio; +Cc: Linus Walleij The pca953x driver supports tca6424 (24-bit) and pca9505 (40-bit) devices. They were the only supported devices not mentioned in the Kconfig help. Signed-off-by: Aaron Sierra <asierra@xes-inc.com> --- drivers/gpio/Kconfig | 4 ++++ drivers/gpio/gpio-pca953x.c | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig index 6973387..fd7ad66 100644 --- a/drivers/gpio/Kconfig +++ b/drivers/gpio/Kconfig @@ -476,6 +476,10 @@ config GPIO_PCA953X 16 bits: max7312, max7313, pca9535, pca9539, pca9555, pca9575, tca6416 + 24 bits: tca6424 + + 40 bits: pca9505 + config GPIO_PCA953X_IRQ bool "Interrupt controller support for PCA953x" depends on GPIO_PCA953X=y diff --git a/drivers/gpio/gpio-pca953x.c b/drivers/gpio/gpio-pca953x.c index 019b23b..cede6f6 100644 --- a/drivers/gpio/gpio-pca953x.c +++ b/drivers/gpio/gpio-pca953x.c @@ -1,5 +1,5 @@ /* - * PCA953x 4/8/16 bit I/O ports + * PCA953x 4/8/16/24/40 bit I/O ports * * Copyright (C) 2005 Ben Gardner <bgardner@wabtec.com> * Copyright (C) 2007 Marvell International Ltd. -- 1.7.9.5 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 1/3] gpio: pca953x: Add devices to Kconfig help 2014-02-07 22:35 ` [PATCH 1/3] gpio: pca953x: Add devices to Kconfig help Aaron Sierra @ 2014-02-12 15:21 ` Linus Walleij 2014-02-12 17:06 ` Graeme Smecher 2014-02-13 15:06 ` Gregory CLEMENT 2014-02-13 12:58 ` Linus Walleij 1 sibling, 2 replies; 5+ messages in thread From: Linus Walleij @ 2014-02-12 15:21 UTC (permalink / raw) To: Aaron Sierra, Gregory CLEMENT, Graeme Smecher, Maxime Ripard Cc: linux-gpio@vger.kernel.org On Fri, Feb 7, 2014 at 11:35 PM, Aaron Sierra <asierra@xes-inc.com> wrote: > The pca953x driver supports tca6424 (24-bit) and pca9505 (40-bit) > devices. They were the only supported devices not mentioned in the > Kconfig help. > > Signed-off-by: Aaron Sierra <asierra@xes-inc.com> Can I get some help from the previous pca953x contributors to have a look at these new patches? An ACK or similar would be nice. Yours, Linus Walleij ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/3] gpio: pca953x: Add devices to Kconfig help 2014-02-12 15:21 ` Linus Walleij @ 2014-02-12 17:06 ` Graeme Smecher 2014-02-13 15:06 ` Gregory CLEMENT 1 sibling, 0 replies; 5+ messages in thread From: Graeme Smecher @ 2014-02-12 17:06 UTC (permalink / raw) To: Linus Walleij Cc: Aaron Sierra, Gregory CLEMENT, Maxime Ripard, linux-gpio@vger.kernel.org Hi all, On 12/02/14 07:21 AM, Linus Walleij wrote: > On Fri, Feb 7, 2014 at 11:35 PM, Aaron Sierra <asierra@xes-inc.com> wrote: > >> The pca953x driver supports tca6424 (24-bit) and pca9505 (40-bit) >> devices. They were the only supported devices not mentioned in the >> Kconfig help. >> >> Signed-off-by: Aaron Sierra <asierra@xes-inc.com> > Can I get some help from the previous pca953x contributors > to have a look at these new patches? An ACK or similar > would be nice. I've had a quick glance at the relevant datasheets and don't see any problems. The XRA1202 (added by patch) is explicitly compatible with the PCA9538 (already supported), and the datasheets for the PCA9698 (added by patch) and the PCA9505 (already supported) can be read side-by-side. Acked-by: Graeme Smecher <gsmecher@threespeedlogic.com> cheers, Graeme ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/3] gpio: pca953x: Add devices to Kconfig help 2014-02-12 15:21 ` Linus Walleij 2014-02-12 17:06 ` Graeme Smecher @ 2014-02-13 15:06 ` Gregory CLEMENT 1 sibling, 0 replies; 5+ messages in thread From: Gregory CLEMENT @ 2014-02-13 15:06 UTC (permalink / raw) To: Linus Walleij, Aaron Sierra, Graeme Smecher, Maxime Ripard Cc: linux-gpio@vger.kernel.org On 12/02/2014 16:21, Linus Walleij wrote: > On Fri, Feb 7, 2014 at 11:35 PM, Aaron Sierra <asierra@xes-inc.com> wrote: > >> The pca953x driver supports tca6424 (24-bit) and pca9505 (40-bit) >> devices. They were the only supported devices not mentioned in the >> Kconfig help. >> >> Signed-off-by: Aaron Sierra <asierra@xes-inc.com> > Acked-by: Gregory CLEMENT <gregory.clement@free-electrons.com> > Can I get some help from the previous pca953x contributors > to have a look at these new patches? An ACK or similar > would be nice. > > Yours, > Linus Walleij > -- Gregory Clement, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/3] gpio: pca953x: Add devices to Kconfig help 2014-02-07 22:35 ` [PATCH 1/3] gpio: pca953x: Add devices to Kconfig help Aaron Sierra 2014-02-12 15:21 ` Linus Walleij @ 2014-02-13 12:58 ` Linus Walleij 1 sibling, 0 replies; 5+ messages in thread From: Linus Walleij @ 2014-02-13 12:58 UTC (permalink / raw) To: Aaron Sierra; +Cc: linux-gpio@vger.kernel.org On Fri, Feb 7, 2014 at 11:35 PM, Aaron Sierra <asierra@xes-inc.com> wrote: > The pca953x driver supports tca6424 (24-bit) and pca9505 (40-bit) > devices. They were the only supported devices not mentioned in the > Kconfig help. > > Signed-off-by: Aaron Sierra <asierra@xes-inc.com> Patch applied with Graeme's ACK. Yours, Linus Walleij ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2014-02-13 15:06 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <972232456.119003.1391812066467.JavaMail.zimbra@xes-inc.com>
2014-02-07 22:35 ` [PATCH 1/3] gpio: pca953x: Add devices to Kconfig help Aaron Sierra
2014-02-12 15:21 ` Linus Walleij
2014-02-12 17:06 ` Graeme Smecher
2014-02-13 15:06 ` Gregory CLEMENT
2014-02-13 12:58 ` Linus Walleij
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).