From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: delicious quinoa <delicious.quinoa@gmail.com>
Cc: Alan Tull <atull@altera.com>,
Linus Walleij <linus.walleij@linaro.org>,
Alexandre Courbot <gnurou@gmail.com>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
Dinh Nguyen <dinguyen@altera.com>
Subject: Re: [PATCH 6/7] gpio: dwapb: use a second irq chip
Date: Tue, 25 Mar 2014 20:40:12 +0100 [thread overview]
Message-ID: <5331DB9C.4020208@linutronix.de> (raw)
In-Reply-To: <CANk1AXTUr2MevsXphxicgZEPC2tQBUh6pEXa78Fa6Jt4bPiRdQ@mail.gmail.com>
On 03/25/2014 07:48 PM, delicious quinoa wrote:
> I'm trying to test against recent tag next-20140312. Got a build error.
>
> /home/atull/repos/linux-socfpga/drivers/gpio/gpio-dwapb.c:254:11:
> error: 'struct irq_chip' has no member named 'irq_request_resources'
> /home/atull/repos/linux-socfpga/drivers/gpio/gpio-dwapb.c:254:36:
> error: 'dwapb_irq_reqres' undeclared (first use in this function)
> /home/atull/repos/linux-socfpga/drivers/gpio/gpio-dwapb.c:255:11:
> error: 'struct irq_chip' has no member named 'irq_release_resources'
> /home/atull/repos/linux-socfpga/drivers/gpio/gpio-dwapb.c:255:36:
> error: 'dwapb_irq_relres' undeclared (first use in this function)
> Build failed...
The change in the driver got first introduced in commit 57ef0428
("gpio: switch drivers to use new callback") and it builds for me. You
probably miss the change in the core code c1bacba ("genirq: Provide
irq_request/release_resources chip callbacks").
I pushed to
git://git.breakpoint.cc/bigeasy/linux.git gpio_dw_v3
my gpio-next + my patches + linux-next which is currently at -next-
20140325 btw. With those you should not get the build anymore.
> Alan Tull
> aka
> delicious quinoa
Sebastian
next prev parent reply other threads:[~2014-03-25 19:40 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-22 16:16 dwapb: a bug fix a few cleanups, v2 Sebastian Andrzej Siewior
2014-03-22 16:16 ` [PATCH 1/7] ARM: dts: socfpga: add gpio pieces Sebastian Andrzej Siewior
2014-05-05 22:02 ` Olof Johansson
[not found] ` <CAOesGMi_0fT4UbfGUp9jkrwYMXgfxC5gmXOBviU9PjAutPdHiw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-05-06 15:01 ` Alan Tull
2014-05-13 8:45 ` Linus Walleij
2014-03-22 16:16 ` [PATCH 2/7] gpio: dwapb: correct gpio-cells in binding document Sebastian Andrzej Siewior
2014-03-25 20:49 ` Linus Walleij
2014-03-25 20:57 ` Sebastian Andrzej Siewior
2014-03-25 21:00 ` Linus Walleij
2014-03-22 16:16 ` [PATCH 3/7] gpio: dwapb: drop irq_setup_generic_chip() Sebastian Andrzej Siewior
2014-03-22 16:16 ` [PATCH 4/7] gpio: dwapb: use irq_linear_revmap() for the faster lookup Sebastian Andrzej Siewior
2014-03-22 16:16 ` [PATCH 5/7] gpio: dwapb: use irq_gc_lock() for locking instead bc's lock Sebastian Andrzej Siewior
2014-03-22 16:16 ` [PATCH 6/7] gpio: dwapb: use a second irq chip Sebastian Andrzej Siewior
2014-03-25 18:48 ` delicious quinoa
2014-03-25 19:40 ` Sebastian Andrzej Siewior [this message]
2014-03-25 21:36 ` Sebastian Hesselbarth
2014-04-07 9:59 ` Sebastian Andrzej Siewior
2014-04-08 15:11 ` delicious quinoa
2014-04-30 11:13 ` [PATCH 6/7 v2] " Sebastian Andrzej Siewior
2014-05-09 11:46 ` Linus Walleij
2014-05-13 16:17 ` Alan Tull
2014-05-16 15:01 ` Linus Walleij
2014-05-22 9:42 ` Sebastian Andrzej Siewior
2014-05-22 14:08 ` Alan Tull
2014-05-26 21:02 ` Sebastian Andrzej Siewior
2014-05-26 20:58 ` [PATCH v3] " Sebastian Andrzej Siewior
2014-05-27 9:55 ` Jamie Iles
2014-05-27 14:21 ` Linus Walleij
2014-05-27 16:30 ` Sebastian Andrzej Siewior
2014-05-28 9:01 ` Linus Walleij
2014-05-28 9:26 ` Sebastian Andrzej Siewior
2014-03-22 16:16 ` [PATCH 7/7] gpio: dwapb: use d->mask instead od BIT(bit) Sebastian Andrzej Siewior
2014-03-25 2:17 ` Alexandre Courbot
2014-03-25 7:54 ` Sebastian Andrzej Siewior
2014-03-25 21:18 ` [PATCH 7/7 v2] " Sebastian Andrzej Siewior
2014-03-25 21:25 ` Joe Perches
2014-03-25 20:45 ` dwapb: a bug fix a few cleanups, v2 Linus Walleij
2014-03-25 21:26 ` Sebastian Hesselbarth
2014-03-25 21:39 ` Sebastian Hesselbarth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5331DB9C.4020208@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=atull@altera.com \
--cc=delicious.quinoa@gmail.com \
--cc=dinguyen@altera.com \
--cc=gnurou@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).