From: Alexander Stein <alexander.stein@systec-electronic.com>
To: "Timo Teräs" <timo.teras@iki.fi>
Cc: linux-gpio@vger.kernel.org
Subject: Re: [PATCH] gpio: mcp23s08: support setting pullups from device tree data
Date: Mon, 07 Dec 2015 07:53:08 +0100 [thread overview]
Message-ID: <5332318.fo424NgDVM@ws-stein> (raw)
In-Reply-To: <1449229573-25759-1-git-send-email-timo.teras@iki.fi>
On Friday 04 December 2015 13:46:13, Timo Teräs wrote:
> Make pullup configurable from device tree data.
>
> Signed-off-by: Timo Teräs <timo.teras@iki.fi>
> ---
> I'm not fully certain how the pullup data should be made configurable via OF.
> gpio-twl4030.c uses similar approach as this, but gpio-samsung.c makes the
> pullup configuration seems to be part of the custom data in gpio specifiers.
I think this should be specified for each individual GPIO. e.g.
> gpios = <&gpio-ctrl 0 GPIO_ACTIVE_HIGH GPIO_PULLUP>;
You don't know (yet) which pins might need a internal pull-up when specifying the mcp23s08 node itself.
You might override the controller node in your dts, but so you need to adjust 2 entries, one for the user and one for the pullup, rather than have all options at one place.
Best regards,
Alexander
--
Dipl.-Inf. Alexander Stein
SYS TEC electronic GmbH
alexander.stein@systec-electronic.com
Legal and Commercial Address:
Am Windrad 2
08468 Heinsdorfergrund
Germany
Office: +49 (0) 3765 38600-0
Fax: +49 (0) 3765 38600-4100
Managing Directors:
Director Technology/CEO: Dipl.-Phys. Siegmar Schmidt;
Director Commercial Affairs/COO: Dipl. Ing. (FH) Armin von Collrepp
Commercial Registry:
Amtsgericht Chemnitz, HRB 28082; USt.-Id Nr. DE150534010
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2015-12-07 6:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-04 11:46 [PATCH] gpio: mcp23s08: support setting pullups from device tree data Timo Teräs
2015-12-07 6:53 ` Alexander Stein [this message]
2015-12-07 7:22 ` Timo Teras
2015-12-15 8:09 ` Alexander Stein
2015-12-15 9:23 ` Timo Teras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5332318.fo424NgDVM@ws-stein \
--to=alexander.stein@systec-electronic.com \
--cc=linux-gpio@vger.kernel.org \
--cc=timo.teras@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox