From: Guenter Roeck <linux@roeck-us.net>
To: Axel Lin <axel.lin@ingics.com>, Linus Walleij <linus.walleij@linaro.org>
Cc: Michael Brunner <michael.brunner@kontron.com>,
Alexandre Courbot <gnurou@gmail.com>,
linux-gpio@vger.kernel.org
Subject: Re: [PATCH] gpio: kempld: Fix autoloading of module
Date: Sat, 12 Apr 2014 09:58:03 -0700 [thread overview]
Message-ID: <5349709B.6030004@roeck-us.net> (raw)
In-Reply-To: <1397277918.29335.1.camel@phoenix>
On 04/11/2014 09:45 PM, Axel Lin wrote:
> Make the module alias match the platform device name, so gpio-kempld module
> should now autoload correctly.
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> ---
> drivers/gpio/gpio-kempld.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpio/gpio-kempld.c b/drivers/gpio/gpio-kempld.c
> index c6d8817..ebe1023 100644
> --- a/drivers/gpio/gpio-kempld.c
> +++ b/drivers/gpio/gpio-kempld.c
> @@ -216,4 +216,4 @@ module_platform_driver(kempld_gpio_driver);
> MODULE_DESCRIPTION("KEM PLD GPIO Driver");
> MODULE_AUTHOR("Michael Brunner <michael.brunner@kontron.com>");
> MODULE_LICENSE("GPL");
> -MODULE_ALIAS("platform:gpio-kempld");
> +MODULE_ALIAS("platform:kempld-gpio");
>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Wonder though if the module alias is necessary in the first place,
as the driver is instantiated from the mfd driver.
Guenter
next prev parent reply other threads:[~2014-04-12 16:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-12 4:45 [PATCH] gpio: kempld: Fix autoloading of module Axel Lin
2014-04-12 16:58 ` Guenter Roeck [this message]
2014-04-15 23:46 ` Axel Lin
2014-04-22 21:44 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5349709B.6030004@roeck-us.net \
--to=linux@roeck-us.net \
--cc=axel.lin@ingics.com \
--cc=gnurou@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=michael.brunner@kontron.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox