linux-gpio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Michal Simek <monstr@monstr.eu>
To: Jingoo Han <jg1.han@samsung.com>,
	'Linus Walleij' <linus.walleij@linaro.org>
Cc: 'Alexandre Courbot' <gnurou@gmail.com>, linux-gpio@vger.kernel.org
Subject: Re: [PATCH 6/7] gpio: xilinx: Make of_device_id array const
Date: Wed, 07 May 2014 13:25:05 +0200	[thread overview]
Message-ID: <536A1811.2090404@monstr.eu> (raw)
In-Reply-To: <022c01cf69d3$e43d6b00$acb84100$%han@samsung.com>

[-- Attachment #1: Type: text/plain, Size: 1134 bytes --]

On 05/07/2014 11:08 AM, Jingoo Han wrote:
> Make of_device_id array const, because all OF functions
> handle it as const.
> 
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> ---
>  drivers/gpio/gpio-xilinx.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpio/gpio-xilinx.c b/drivers/gpio/gpio-xilinx.c
> index 792a05a..1248186 100644
> --- a/drivers/gpio/gpio-xilinx.c
> +++ b/drivers/gpio/gpio-xilinx.c
> @@ -289,7 +289,7 @@ static int xgpio_of_probe(struct device_node *np)
>  	return 0;
>  }
>  
> -static struct of_device_id xgpio_of_match[] = {
> +static const struct of_device_id xgpio_of_match[] = {
>  	{ .compatible = "xlnx,xps-gpio-1.00.a", },
>  	{ /* end of list */ },
>  };
> 

Reviewed-by: Michal Simek <monstr@monstr.eu>

Thanks,
Michal


-- 
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/
Maintainer of Linux kernel - Xilinx Zynq ARM architecture
Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 263 bytes --]

  reply	other threads:[~2014-05-07 11:25 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-07  9:03 [PATCH 1/7] gpio: grgpio: Make of_device_id array const Jingoo Han
2014-05-07  9:05 ` [PATCH 2/7] gpio: mcp23s08: " Jingoo Han
2014-05-09  8:59   ` Linus Walleij
2014-05-07  9:06 ` [PATCH 3/7] gpio: mvebu: " Jingoo Han
2014-05-09  9:01   ` Linus Walleij
2014-05-07  9:06 ` [PATCH 4/7] gpio: palmas: " Jingoo Han
2014-05-07  9:07 ` [PATCH 5/7] gpio: tegra: " Jingoo Han
2014-05-09  9:02   ` Linus Walleij
2014-05-07  9:08 ` [PATCH 6/7] gpio: xilinx: " Jingoo Han
2014-05-07 11:25   ` Michal Simek [this message]
2014-05-09  9:03   ` Linus Walleij
2014-05-07  9:09 ` [PATCH 7/7] gpio: zevio: " Jingoo Han
2014-05-09  9:04   ` Linus Walleij
2014-05-07 12:01 ` [PATCH 1/7] gpio: grgpio: " Andreas Larsson
2014-05-09  8:58 ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=536A1811.2090404@monstr.eu \
    --to=monstr@monstr.eu \
    --cc=gnurou@gmail.com \
    --cc=jg1.han@samsung.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).