* [PATCH 1/2] gpio: lpc32xx: Make of_device_id array const
@ 2014-06-03 12:09 Jingoo Han
2014-06-03 12:10 ` [PATCH 2/2] gpio: pxa: " Jingoo Han
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Jingoo Han @ 2014-06-03 12:09 UTC (permalink / raw)
To: 'Linus Walleij'
Cc: 'Alexandre Courbot', linux-gpio, 'Jingoo Han',
'Roland Stigge'
Make of_device_id array const, because all OF functions handle
it as const.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/gpio/gpio-lpc32xx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpio/gpio-lpc32xx.c b/drivers/gpio/gpio-lpc32xx.c
index 225344d..b9b9799 100644
--- a/drivers/gpio/gpio-lpc32xx.c
+++ b/drivers/gpio/gpio-lpc32xx.c
@@ -560,7 +560,7 @@ static int lpc32xx_gpio_probe(struct platform_device *pdev)
}
#ifdef CONFIG_OF
-static struct of_device_id lpc32xx_gpio_of_match[] = {
+static const struct of_device_id lpc32xx_gpio_of_match[] = {
{ .compatible = "nxp,lpc3220-gpio", },
{ },
};
--
1.7.10.4
^ permalink raw reply related [flat|nested] 5+ messages in thread* [PATCH 2/2] gpio: pxa: Make of_device_id array const
2014-06-03 12:09 [PATCH 1/2] gpio: lpc32xx: Make of_device_id array const Jingoo Han
@ 2014-06-03 12:10 ` Jingoo Han
2014-06-04 3:28 ` Neil Zhang
2014-06-03 12:11 ` [PATCH 1/2] gpio: lpc32xx: " Roland Stigge
2014-06-12 7:37 ` Linus Walleij
2 siblings, 1 reply; 5+ messages in thread
From: Jingoo Han @ 2014-06-03 12:10 UTC (permalink / raw)
To: 'Linus Walleij'
Cc: 'Alexandre Courbot', linux-gpio, 'Jingoo Han',
'Neil Zhang', 'Eric Miao'
Make of_device_id array const, because all OF functions handle
it as const.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/gpio/gpio-pxa.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpio/gpio-pxa.c b/drivers/gpio/gpio-pxa.c
index 42e6e64..52bbda0 100644
--- a/drivers/gpio/gpio-pxa.c
+++ b/drivers/gpio/gpio-pxa.c
@@ -498,7 +498,7 @@ static int pxa_gpio_nums(struct platform_device *pdev)
}
#ifdef CONFIG_OF
-static struct of_device_id pxa_gpio_dt_ids[] = {
+static const struct of_device_id pxa_gpio_dt_ids[] = {
{ .compatible = "intel,pxa25x-gpio", .data = &pxa25x_id, },
{ .compatible = "intel,pxa26x-gpio", .data = &pxa26x_id, },
{ .compatible = "intel,pxa27x-gpio", .data = &pxa27x_id, },
--
1.7.10.4
^ permalink raw reply related [flat|nested] 5+ messages in thread* RE: [PATCH 2/2] gpio: pxa: Make of_device_id array const
2014-06-03 12:10 ` [PATCH 2/2] gpio: pxa: " Jingoo Han
@ 2014-06-04 3:28 ` Neil Zhang
0 siblings, 0 replies; 5+ messages in thread
From: Neil Zhang @ 2014-06-04 3:28 UTC (permalink / raw)
To: Jingoo Han, 'Linus Walleij'
Cc: 'Alexandre Courbot', linux-gpio@vger.kernel.org,
'Eric Miao'
> -----Original Message-----
> From: Jingoo Han [mailto:jg1.han@samsung.com]
> Sent: 2014年6月3日 20:10
> To: 'Linus Walleij'
> Cc: 'Alexandre Courbot'; linux-gpio@vger.kernel.org; 'Jingoo Han'; Neil Zhang;
> 'Eric Miao'
> Subject: [PATCH 2/2] gpio: pxa: Make of_device_id array const
>
> Make of_device_id array const, because all OF functions handle it as const.
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> ---
> drivers/gpio/gpio-pxa.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpio/gpio-pxa.c b/drivers/gpio/gpio-pxa.c index
> 42e6e64..52bbda0 100644
> --- a/drivers/gpio/gpio-pxa.c
> +++ b/drivers/gpio/gpio-pxa.c
> @@ -498,7 +498,7 @@ static int pxa_gpio_nums(struct platform_device
> *pdev) }
>
> #ifdef CONFIG_OF
> -static struct of_device_id pxa_gpio_dt_ids[] = {
> +static const struct of_device_id pxa_gpio_dt_ids[] = {
> { .compatible = "intel,pxa25x-gpio", .data = &pxa25x_id, },
> { .compatible = "intel,pxa26x-gpio", .data = &pxa26x_id, },
> { .compatible = "intel,pxa27x-gpio", .data = &pxa27x_id, },
> --
> 1.7.10.4
>
Acked-by: Neil Zhang <zhangwm@marvell.com>
Best Regards,
Neil Zhang
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] gpio: lpc32xx: Make of_device_id array const
2014-06-03 12:09 [PATCH 1/2] gpio: lpc32xx: Make of_device_id array const Jingoo Han
2014-06-03 12:10 ` [PATCH 2/2] gpio: pxa: " Jingoo Han
@ 2014-06-03 12:11 ` Roland Stigge
2014-06-12 7:37 ` Linus Walleij
2 siblings, 0 replies; 5+ messages in thread
From: Roland Stigge @ 2014-06-03 12:11 UTC (permalink / raw)
To: Jingoo Han, 'Linus Walleij'
Cc: 'Alexandre Courbot', linux-gpio
On 06/03/2014 02:09 PM, Jingoo Han wrote:
> Make of_device_id array const, because all OF functions handle
> it as const.
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> ---
> drivers/gpio/gpio-lpc32xx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpio/gpio-lpc32xx.c b/drivers/gpio/gpio-lpc32xx.c
> index 225344d..b9b9799 100644
> --- a/drivers/gpio/gpio-lpc32xx.c
> +++ b/drivers/gpio/gpio-lpc32xx.c
> @@ -560,7 +560,7 @@ static int lpc32xx_gpio_probe(struct platform_device *pdev)
> }
>
> #ifdef CONFIG_OF
> -static struct of_device_id lpc32xx_gpio_of_match[] = {
> +static const struct of_device_id lpc32xx_gpio_of_match[] = {
> { .compatible = "nxp,lpc3220-gpio", },
> { },
> };
>
Acked-By: Roland Stigge <stigge@antcom.de>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH 1/2] gpio: lpc32xx: Make of_device_id array const
2014-06-03 12:09 [PATCH 1/2] gpio: lpc32xx: Make of_device_id array const Jingoo Han
2014-06-03 12:10 ` [PATCH 2/2] gpio: pxa: " Jingoo Han
2014-06-03 12:11 ` [PATCH 1/2] gpio: lpc32xx: " Roland Stigge
@ 2014-06-12 7:37 ` Linus Walleij
2 siblings, 0 replies; 5+ messages in thread
From: Linus Walleij @ 2014-06-12 7:37 UTC (permalink / raw)
To: Jingoo Han; +Cc: Alexandre Courbot, linux-gpio@vger.kernel.org, Roland Stigge
On Tue, Jun 3, 2014 at 2:09 PM, Jingoo Han <jg1.han@samsung.com> wrote:
> Make of_device_id array const, because all OF functions handle
> it as const.
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Patch applied with Roland's ACK.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2014-06-12 7:37 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-06-03 12:09 [PATCH 1/2] gpio: lpc32xx: Make of_device_id array const Jingoo Han
2014-06-03 12:10 ` [PATCH 2/2] gpio: pxa: " Jingoo Han
2014-06-04 3:28 ` Neil Zhang
2014-06-03 12:11 ` [PATCH 1/2] gpio: lpc32xx: " Roland Stigge
2014-06-12 7:37 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).