From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk>,
Sascha Silbe <x-linux@infra-silbe.de>
Cc: Johan Hovold <jhovold@gmail.com>,
Linus Walleij <linus.walleij@linaro.org>,
Alexandre Courbot <gnurou@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, linux-gpio@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] USB: ftdi_sio: add GPIO support
Date: Mon, 09 Jun 2014 22:36:47 +0400 [thread overview]
Message-ID: <5395FEBF.3040608@cogentembedded.com> (raw)
In-Reply-To: <20140609152313.45f353d6@alan.etchedpixels.co.uk>
Hello.
On 06/09/2014 06:23 PM, One Thousand Gnomes wrote:
>> #include <linux/kernel.h>
>> #include <linux/errno.h>
>> +#ifdef CONFIG_GPIOLIB
>> +#include <linux/gpio.h>
>> +#endif
> Please create a new struct, a new file and put all the GPIO stuff in
> there rather than #if bombing the driver.
> You can then declare blank methods for the gpio stuff if GPIO is not
> compiled in - ie in the headers
> #ifdef CONFIG_GPIOLIB
> extern int ftdi_gpio_open(struct ftdi_private *priv);
> etc...
> #else
> extern inline int ftdi_gpio_open(struct ftdi_private *priv) { return 0 };
I guess you meant *static* instead of *extern* here?
> #endif
WBR, Sergei
next prev parent reply other threads:[~2014-06-09 18:36 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-09 13:21 [PATCH] USB: ftdi_sio: add GPIO support Sascha Silbe
2014-06-09 14:23 ` One Thousand Gnomes
2014-06-09 18:36 ` Sergei Shtylyov [this message]
2014-06-10 10:56 ` Johan Hovold
2014-06-16 7:15 ` Philipp Hachtmann
2014-06-13 7:25 ` Linus Walleij
2014-06-13 18:31 ` Greg Kroah-Hartman
2014-07-07 10:44 ` Linus Walleij
2014-07-07 17:31 ` Greg Kroah-Hartman
[not found] ` <20140707173142.GB8693-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2015-05-30 20:29 ` Grant Likely
[not found] ` <CACxGe6uskWcBU0MhO=EupU=2VKmDhX01-_LDJ-n91XAnRYiqbw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-06-02 13:18 ` Linus Walleij
[not found] ` <CACRpkdbDAWq42pkwTfi98invy0ov=XD8WzfX0dwnjeRXVpQ8Ow-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-07-03 22:13 ` Grant Likely
2015-07-16 11:56 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5395FEBF.3040608@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=gnomes@lxorguk.ukuu.org.uk \
--cc=gnurou@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jhovold@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=x-linux@infra-silbe.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).