From: "Heiko Stübner" <heiko@sntech.de>
To: Jonas Gorski <jogo@openwrt.org>
Cc: linux-gpio@vger.kernel.org,
Linus Walleij <linus.walleij@linaro.org>,
Alexandre Courbot <gnurou@gmail.com>,
Joachim Eastwood <manabian@gmail.com>,
Jonas Jensen <jonas.jensen@gmail.com>,
Gregory CLEMENT <gregory.clement@free-electrons.com>,
Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
James Hogan <james.hogan@imgtec.com>,
Stefan Agner <stefan@agner.ch>, Jun Nie <jun.nie@linaro.org>,
Stephen Warren <swarren@wwwdotorg.org>,
Lee Jones <lee@kernel.org>, Eric Anholt <eric@anholt.net>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Alessandro Rubini <rubini@unipv.it>,
Sonic Zhang <sonic.zhang@analog.com>,
Laxman Dewangan <ldewangan@nvidia.com>,
Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>,
Jonas Aaberg <jonas.aberg@stericsson.com>, Baruch Siach <baruch@>
Subject: Re: [PATCH RFT 5/5] pinctrl: replace trivial implementations of gpio_chip request/free
Date: Sun, 13 Sep 2015 21:20:53 +0200 [thread overview]
Message-ID: <5410791.Yv1bkX123z@diego> (raw)
In-Reply-To: <1442150498-31116-6-git-send-email-jogo@openwrt.org>
Hi Jonas,
Am Sonntag, 13. September 2015, 15:21:38 schrieb Jonas Gorski:
> diff --git a/drivers/pinctrl/pinctrl-rockchip.c
> b/drivers/pinctrl/pinctrl-rockchip.c index c5246c0..89a6ad8e 100644
> --- a/drivers/pinctrl/pinctrl-rockchip.c
> +++ b/drivers/pinctrl/pinctrl-rockchip.c
> @@ -1374,16 +1374,6 @@ static int rockchip_pinctrl_register(struct
> platform_device *pdev, * GPIO handling
> */
>
> -static int rockchip_gpio_request(struct gpio_chip *chip, unsigned offset)
> -{
> - return pinctrl_request_gpio(chip->base + offset);
> -}
> -
> -static void rockchip_gpio_free(struct gpio_chip *chip, unsigned offset)
> -{
> - pinctrl_free_gpio(chip->base + offset);
> -}
> -
> static void rockchip_gpio_set(struct gpio_chip *gc, unsigned offset, int
> value) {
> struct rockchip_pin_bank *bank = gc_to_pin_bank(gc);
> @@ -1461,8 +1451,8 @@ static int rockchip_gpio_to_irq(struct gpio_chip *gc,
> unsigned offset) }
>
> static const struct gpio_chip rockchip_gpiolib_chip = {
> - .request = rockchip_gpio_request,
> - .free = rockchip_gpio_free,
> + .request = gpiochip_generic_request,
> + .free = gpiochip_generic_free,
> .set = rockchip_gpio_set,
> .get = rockchip_gpio_get,
> .direction_input = rockchip_gpio_direction_input,
for the Rockchip part
Acked-by: Heiko Stuebner <heiko@sntech.de>
next prev parent reply other threads:[~2015-09-13 19:21 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-13 13:21 [PATCH RFT 0/5] gpiochip: add and use generic request/free Jonas Gorski
2015-09-13 13:21 ` [PATCH RFT 1/5] gpiolib: provide generic request/free implementations Jonas Gorski
2015-10-05 9:17 ` Linus Walleij
2015-09-13 13:21 ` [PATCH RFT 2/5] gpio: replace trivial implementations of request/free with generic one Jonas Gorski
2015-09-14 14:37 ` Thomas Petazzoni
2015-09-14 17:14 ` James Hogan
2015-09-15 3:32 ` Stefan Agner
2015-09-20 13:16 ` Joachim Eastwood
2015-09-13 13:21 ` [PATCH RFT 3/5] gpio: gpio-xz: use the generic request/free implementations Jonas Gorski
2015-09-13 13:21 ` [PATCH RFT 4/5] gpio: gpio-pl061: " Jonas Gorski
2015-10-05 9:19 ` Linus Walleij
2015-10-05 13:12 ` Jonas Gorski
2015-10-06 7:23 ` Linus Walleij
2015-09-13 13:21 ` [PATCH RFT 5/5] pinctrl: replace trivial implementations of gpio_chip request/free Jonas Gorski
2015-09-13 19:07 ` Bjorn Andersson
2015-09-13 19:20 ` Heiko Stübner [this message]
2015-09-14 14:18 ` Eric Anholt
2015-09-14 14:41 ` Mika Westerberg
2015-09-14 16:53 ` Andrew Bresticker
2015-09-16 11:07 ` Baruch Siach
2015-09-20 13:40 ` Matthias Brugger
2015-10-01 12:32 ` Lee Jones
2015-10-05 10:37 ` Laxman Dewangan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5410791.Yv1bkX123z@diego \
--to=heiko@sntech.de \
--cc=eric@anholt.net \
--cc=gnurou@gmail.com \
--cc=gregory.clement@free-electrons.com \
--cc=heikki.krogerus@linux.intel.com \
--cc=james.hogan@imgtec.com \
--cc=jogo@openwrt.org \
--cc=jonas.aberg@stericsson.com \
--cc=jonas.jensen@gmail.com \
--cc=jun.nie@linaro.org \
--cc=ldewangan@nvidia.com \
--cc=lee@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=manabian@gmail.com \
--cc=matthias.bgg@gmail.com \
--cc=mika.westerberg@linux.intel.com \
--cc=plagnioj@jcrosoft.com \
--cc=rubini@unipv.it \
--cc=sonic.zhang@analog.com \
--cc=stefan@agner.ch \
--cc=swarren@wwwdotorg.org \
--cc=thomas.petazzoni@free-electrons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).