From: Varka Bhadram <varkabhadram@gmail.com>
To: Alexandre Courbot <gnurou@gmail.com>
Cc: "linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
Varka Bhadram <varkab@cdac.in>
Subject: Re: [PATCH gpio v1 2/2] gpio: ks8695: fix 'else should follow close brace '}''
Date: Sat, 27 Sep 2014 18:48:18 +0530 [thread overview]
Message-ID: <5426B91A.7080409@gmail.com> (raw)
In-Reply-To: <CAAVeFu+NVmV+MqPXBUD3+3Zio44AZF5-YPV_p4KRzOHLrRFB2Q@mail.gmail.com>
On Monday 22 September 2014 03:18 PM, Alexandre Courbot wrote:
> On Sun, Sep 21, 2014 at 12:14 AM, Varka Bhadram <varkabhadram@gmail.com> wrote:
>> Signed-off-by: Varka Bhadram <varkab@cdac.in>
>> ---
>> drivers/gpio/gpio-ks8695.c | 9 +++------
>> 1 file changed, 3 insertions(+), 6 deletions(-)
>>
>> diff --git a/drivers/gpio/gpio-ks8695.c b/drivers/gpio/gpio-ks8695.c
>> index ba2d2f1..10c7377 100644
>> --- a/drivers/gpio/gpio-ks8695.c
>> +++ b/drivers/gpio/gpio-ks8695.c
>> @@ -276,17 +276,14 @@ static int ks8695_gpio_show(struct seq_file *s, void *unused)
>> case IOPC_TM_EDGE:
>> seq_printf(s, "(Edges)"); break;
>> }
>> - }
>> - else
>> + } else
>> seq_printf(s, "GPIO\t");
> According to the kernel code formatting guidelines, this should actually be
>
> } else {
> seq_printf(s, "GPIO\t");
> }
Ok i will change it . Thanks...
--
Regards,
Varka Bhadram
next prev parent reply other threads:[~2014-09-27 13:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-20 15:14 [PATCH gpio v1 1/2] gpio: ks8695: fix switch case indentation Varka Bhadram
2014-09-20 15:14 ` [PATCH gpio v1 2/2] gpio: ks8695: fix 'else should follow close brace '}'' Varka Bhadram
2014-09-22 9:48 ` Alexandre Courbot
2014-09-27 13:18 ` Varka Bhadram [this message]
2014-09-24 8:57 ` [PATCH gpio v1 1/2] gpio: ks8695: fix switch case indentation Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5426B91A.7080409@gmail.com \
--to=varkabhadram@gmail.com \
--cc=gnurou@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=varkab@cdac.in \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).