From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2CDCDC77B73 for ; Mon, 8 May 2023 06:39:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229757AbjEHGjb (ORCPT ); Mon, 8 May 2023 02:39:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57914 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232313AbjEHGja (ORCPT ); Mon, 8 May 2023 02:39:30 -0400 Received: from mail.3ffe.de (0001.3ffe.de [159.69.201.130]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BCEC1469D; Sun, 7 May 2023 23:39:28 -0700 (PDT) Received: from 3ffe.de (0001.3ffe.de [IPv6:2a01:4f8:c0c:9d57::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.3ffe.de (Postfix) with ESMTPSA id 3EDA112EC; Mon, 8 May 2023 08:39:25 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=walle.cc; s=mail2022082101; t=1683527966; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/6M1Ih63w56e4EHUEuM6ZDRiovFqST9QgQFM0cgHYD4=; b=KmpVUxJXUkzB1QEi9Svp88PLsI4/Akj9QAn7dtiJsUXETU6UnFaiq6uX/BzVLZskBaTJsa 4EqGjyFNekFEGiLVWzL8vRstkFCTh3e2ixO8qkoZofzLEwrqXPWJH6kQ7zSf78/m3BsICU Z9uDbt65auf7giMYCEeOMwaOdVnuLdkGDkdqfvJuGCkS9vQJ4H2Wtn79Q2eLei525ZEXn2 +WaYhHMCyWeI07CV+t6CKgHb0i0TWan0t4axh0yl5rGBTQPjOBe3I60k4b7aHQYnWZy42p vB2+OHnyM1R6pe/jZW9tHZU7CBsGMEYjDjUawuqj7yli9xA2Q3Qy5/1V6Zu95g== MIME-Version: 1.0 Date: Mon, 08 May 2023 08:39:25 +0200 From: Michael Walle To: "Vaibhaav Ram T.L" Cc: gregkh@linuxfoundation.org, arnd@arndb.de, kumaravel.thiagarajan@microchip.com, tharunkumar.pasumarthi@microchip.com, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, UNGLinuxDriver@microchip.com Subject: Re: [PATCH v11 char-misc-next 1/2] misc: microchip: pci1xxxx: Add support to read and write into PCI1XXXX OTP via NVMEM sysfs In-Reply-To: <20230429120209.2232-2-vaibhaavram.tl@microchip.com> References: <20230429120209.2232-1-vaibhaavram.tl@microchip.com> <20230429120209.2232-2-vaibhaavram.tl@microchip.com> User-Agent: Roundcube Webmail/1.4.13 Message-ID: <5445b9ad526aa1f4beaa47a3b0e7d83f@walle.cc> X-Sender: michael@walle.cc Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org Am 2023-04-29 14:02, schrieb Vaibhaav Ram T.L: > From: Kumaravel Thiagarajan > > Microchip's pci1xxxx is an unmanaged PCIe3.1a switch for consumer, > industrial, and automotive applications. This switch integrates OTP > and EEPROM to enable customization of the part in the field. This > patch adds support to read and write into PCI1XXXX OTP via NVMEM sysfs. > > Signed-off-by: Kumaravel Thiagarajan > > Co-developed-by: Tharun Kumar P > Signed-off-by: Tharun Kumar P > Co-developed-by: Vaibhaav Ram T.L > Signed-off-by: Vaibhaav Ram T.L I just had a quick look for obvious errors, couldn't spot any. It's not a extensive review, though. -michael