From: Daniel Baluta <daniel.baluta@intel.com>
To: Axel Lin <axel.lin@ingics.com>,
Linus Walleij <linus.walleij@linaro.org>,
Alexandre Courbot <gnurou@gmail.com>
Cc: "linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
Octavian Purdila <octavian.purdila@intel.com>,
"Palcu, Laurentiu" <laurentiu.palcu@intel.com>
Subject: Re: [PATCH RFT] gpio: dln2: Fix gpio output value in dln2_gpio_direction_output()
Date: Tue, 16 Dec 2014 18:52:45 +0200 [thread overview]
Message-ID: <5490635D.6040305@intel.com> (raw)
In-Reply-To: <1418740800.10278.1.camel@phoenix>
On 12/16/2014 04:40 PM, Axel Lin wrote:
> dln2_gpio_direction_output() ignored the state passed into it. Fix it.
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
Tested-by: Daniel Baluta <daniel.baluta@intel.com>
> ---
> I don't have this hardware handy, so only compile test.
> drivers/gpio/gpio-dln2.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpio/gpio-dln2.c b/drivers/gpio/gpio-dln2.c
> index 978b51e..1434844 100644
> --- a/drivers/gpio/gpio-dln2.c
> +++ b/drivers/gpio/gpio-dln2.c
> @@ -267,6 +267,7 @@ static int dln2_gpio_direction_input(struct gpio_chip *chip, unsigned offset)
> static int dln2_gpio_direction_output(struct gpio_chip *chip, unsigned offset,
> int value)
> {
> + dln2_gpio_set(chip, offset, value);
> return dln2_gpio_set_direction(chip, offset, DLN2_GPIO_DIRECTION_OUT);
> }
>
>
next prev parent reply other threads:[~2014-12-16 16:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-16 14:40 [PATCH RFT] gpio: dln2: Fix gpio output value in dln2_gpio_direction_output() Axel Lin
2014-12-16 16:52 ` Daniel Baluta [this message]
2014-12-17 8:50 ` Alexandre Courbot
2014-12-17 8:57 ` Octavian Purdila
2014-12-17 8:59 ` Alexandre Courbot
2014-12-17 9:10 ` Octavian Purdila
2014-12-17 9:13 ` Alexandre Courbot
2014-12-17 9:32 ` Octavian Purdila
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5490635D.6040305@intel.com \
--to=daniel.baluta@intel.com \
--cc=axel.lin@ingics.com \
--cc=gnurou@gmail.com \
--cc=laurentiu.palcu@intel.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=octavian.purdila@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).