From: Stephen Boyd <sboyd@codeaurora.org>
To: Stanimir Varbanov <svarbanov@mm-sol.com>,
Linus Walleij <linus.walleij@linaro.org>
Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-gpio@vger.kernel.org,
Bjorn Andersson <bjorn.andersson@sonymobile.com>
Subject: Re: [PATCH] pinctrl: qcom: enable generic support and input-enable pinctrl conf
Date: Mon, 26 Jan 2015 17:23:42 -0800 [thread overview]
Message-ID: <54C6E89E.2050701@codeaurora.org> (raw)
In-Reply-To: <54C6E753.606@codeaurora.org>
On 01/26/15 17:18, Stephen Boyd wrote:
> On 01/26/15 08:24, Stanimir Varbanov wrote:
>
>> return -ENOTSUPP;
>> }
>>
>> @@ -208,14 +208,12 @@ static int msm_config_get(struct pinctrl_dev *pctldev,
>> unsigned int pin,
>> unsigned long *config)
>> {
>> - dev_err(pctldev->dev, "pin_config_set op not supported\n");
> Same for here.
>
>> return -ENOTSUPP;
>> }
>>
>> static int msm_config_set(struct pinctrl_dev *pctldev, unsigned int pin,
>> unsigned long *configs, unsigned num_configs)
>> {
>> - dev_err(pctldev->dev, "pin_config_set op not supported\n");
> And here.
Actually it looks like we can just remove these two functions and the
core does the right thing and prints errors. That would be a good patch.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2015-01-27 1:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-26 16:24 [PATCH] pinctrl: qcom: enable generic support and input-enable pinctrl conf Stanimir Varbanov
2015-01-27 1:18 ` Stephen Boyd
2015-01-27 1:23 ` Stephen Boyd [this message]
2015-01-27 13:28 ` Stanimir Varbanov
2015-01-27 17:44 ` Bjorn
2015-01-27 13:28 ` Stanimir Varbanov
2015-01-27 18:05 ` Bjorn
2015-01-28 20:48 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54C6E89E.2050701@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=bjorn.andersson@sonymobile.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=svarbanov@mm-sol.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).