[PATCH v6 0/2] ARM: hip04: add GPIO support

[PATCH v6 0/2] ARM: hip04: add GPIO support

[Zhou Wang]

This series add the support for the GPIOs of Hisilicon Soc hip04. Hip04 uses
synopsis' GPIO IP, and we use the dwapb GPIO driver here. This series add the
corresponding dts. The default value of ARCH_NR_GPIOS is used to find gpio
base here.

I resend this patchset with new E-mail address in signed-off-by.

Change in v6:
- Change E-mail address in signed-off-by to "wangzhou1@hisilicon.com"
Change in v5:
- Base on v3.19-rc1
- Just use default value of ARCH_NR_GPIOS to find gpio base. Remove the new
  added patch(3/4) in v4.
Change in v4:
- Delete "default 128 if ARCH_HIP04" in arch/arm/Kconfig
- add a new patch to support find GPIO base number in increasing order
- add gpio-number-forward property in snps gpio binding doc
Change in v3:
- Move CONFIG_GPIO_DWAPB to hisi_defconfig
- Add CONFIG_GPIOLIB, CONFIG_GPIO_SYSFS in hisi_defconfig
Change in v2:
- Add select GPIO_DWAPB in arch/arm/mach-hisi/Kconfig

Link for v4:
- http://www.spinics.net/lists/arm-kernel/msg383883.html
Link for v3:
- http://www.spinics.net/lists/devicetree/msg60324.html

Zhou Wang (2):
  ARM: hip04: add GPIO configure in hisi_defconfig
  ARM: dts: hip04: add GPIO pieces

 arch/arm/boot/dts/hip04.dtsi    | 75 +++++++++++++++++++++++++++++++++++++++++
 arch/arm/configs/hisi_defconfig |  1 +
 2 files changed, 76 insertions(+)

-- 
1.9.1

[PATCH v6 1/2] ARM: hip04: add GPIO configure in hisi_defconfig

[Zhou Wang]

The GPIO controller of Hisilicon hip04 Soc uses the IP from Sysnopsis,
gpio-dwapb.c can be reused to support this GPIO controller. This patch
adds related configure item in hisi_defconfig.

Signed-off-by: Zhou Wang <wangzhou1@hisilicon.com>
---
 arch/arm/configs/hisi_defconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/configs/hisi_defconfig b/arch/arm/configs/hisi_defconfig
index 1125436..4a50862 100644
--- a/arch/arm/configs/hisi_defconfig
+++ b/arch/arm/configs/hisi_defconfig
@@ -50,6 +50,7 @@ CONFIG_GPIO_SYSFS=y
 CONFIG_GPIOLIB=y
 CONFIG_GPIO_GENERIC_PLATFORM=y
 CONFIG_REGULATOR_GPIO=y
+CONFIG_GPIO_DWAPB=y
 CONFIG_MFD_SYSCON=y
 CONFIG_POWER_RESET_SYSCON=y
 CONFIG_DRM=y
-- 
1.9.1

[PATCH v6 2/2] ARM: dts: hip04: add GPIO pieces

[Zhou Wang]

Hisilicon Soc hip04 has four GPIO controllers, each one has 32
GPIOs and can be configured to be an interrupt controller.The GPIO
controllers are compatible with the snps,dw-apb-gpio driver.
This patch add the corresponding device tree nodes.

Signed-off-by: Zhou Wang <wangzhou1@hisilicon.com>
---
 arch/arm/boot/dts/hip04.dtsi | 75 ++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 75 insertions(+)

diff --git a/arch/arm/boot/dts/hip04.dtsi b/arch/arm/boot/dts/hip04.dtsi
index 2388145..267942a 100644
--- a/arch/arm/boot/dts/hip04.dtsi
+++ b/arch/arm/boot/dts/hip04.dtsi
@@ -269,6 +269,81 @@
 			interrupts = <0 372 4>;
 		};
 
+		gpio@4003000 {
+			#address-cells = <1>;
+			#size-cells = <0>;
+			compatible = "snps,dw-apb-gpio";
+			reg = <0x4003000 0x1000>;
+
+			gpio3: gpio-controller@0 {
+				compatible = "snps,dw-apb-gpio-port";
+				gpio-controller;
+				#gpio-cells = <2>;
+				snps,nr-gpios = <32>;
+				reg = <0>;
+				interrupt-parent = <&gic>;
+				interrupt-controller;
+				#interrupt-cells = <2>;
+				interrupts = <0 392 4>;
+			};
+		};
+
+		gpio@4002000 {
+			#address-cells = <1>;
+			#size-cells = <0>;
+			compatible = "snps,dw-apb-gpio";
+			reg = <0x4002000 0x1000>;
+
+			gpio2: gpio-controller@0 {
+			compatible = "snps,dw-apb-gpio-port";
+				gpio-controller;
+				#gpio-cells = <2>;
+				snps,nr-gpios = <32>;
+				reg = <0>;
+				interrupt-parent = <&gic>;
+				interrupt-controller;
+				#interrupt-cells = <2>;
+				interrupts = <0 391 4>;
+			};
+		};
+
+		gpio@4001000 {
+			#address-cells = <1>;
+			#size-cells = <0>;
+			compatible = "snps,dw-apb-gpio";
+			reg = <0x4001000 0x1000>;
+
+			gpio1: gpio-controller@0 {
+				compatible = "snps,dw-apb-gpio-port";
+				gpio-controller;
+				#gpio-cells = <2>;
+				snps,nr-gpios = <32>;
+				reg = <0>;
+				interrupt-parent = <&gic>;
+				interrupt-controller;
+				#interrupt-cells = <2>;
+				interrupts = <0 390 4>;
+			};
+		};
+
+		gpio@4000000 {
+			#address-cells = <1>;
+			#size-cells = <0>;
+			compatible = "snps,dw-apb-gpio";
+			reg = <0x4000000 0x1000>;
+
+			gpio0: gpio-controller@0 {
+				compatible = "snps,dw-apb-gpio-port";
+				gpio-controller;
+				#gpio-cells = <2>;
+				snps,nr-gpios = <32>;
+				reg = <0>;
+				interrupt-parent = <&gic>;
+				interrupt-controller;
+				#interrupt-cells = <2>;
+				interrupts = <0 389 4>;
+			};
+		};
 	};
 
 	etb@0,e3c42000 {
-- 
1.9.1

Re: [PATCH v6 0/2] ARM: hip04: add GPIO support

[Zhou Wang]

Hi Linus, Hi Haojian,

Any comments about this patch?

Best regards,
Zhou Wang

On 2015/1/12 15:05, Zhou Wang wrote:
> This series add the support for the GPIOs of Hisilicon Soc hip04. Hip04 uses
> synopsis' GPIO IP, and we use the dwapb GPIO driver here. This series add the
> corresponding dts. The default value of ARCH_NR_GPIOS is used to find gpio
> base here.
> 
> I resend this patchset with new E-mail address in signed-off-by.
> 
> Change in v6:
> - Change E-mail address in signed-off-by to "wangzhou1@hisilicon.com"
> Change in v5:
> - Base on v3.19-rc1
> - Just use default value of ARCH_NR_GPIOS to find gpio base. Remove the new
>   added patch(3/4) in v4.
> Change in v4:
> - Delete "default 128 if ARCH_HIP04" in arch/arm/Kconfig
> - add a new patch to support find GPIO base number in increasing order
> - add gpio-number-forward property in snps gpio binding doc
> Change in v3:
> - Move CONFIG_GPIO_DWAPB to hisi_defconfig
> - Add CONFIG_GPIOLIB, CONFIG_GPIO_SYSFS in hisi_defconfig
> Change in v2:
> - Add select GPIO_DWAPB in arch/arm/mach-hisi/Kconfig
> 
> Link for v4:
> - http://www.spinics.net/lists/arm-kernel/msg383883.html
> Link for v3:
> - http://www.spinics.net/lists/devicetree/msg60324.html
> 
> Zhou Wang (2):
>   ARM: hip04: add GPIO configure in hisi_defconfig
>   ARM: dts: hip04: add GPIO pieces
> 
>  arch/arm/boot/dts/hip04.dtsi    | 75 +++++++++++++++++++++++++++++++++++++++++
>  arch/arm/configs/hisi_defconfig |  1 +
>  2 files changed, 76 insertions(+)
> 

Re: [PATCH v6 0/2] ARM: hip04: add GPIO support

[Linus Walleij]

On Thu, Jan 29, 2015 at 4:17 AM, Zhou Wang <wangzhou1@hisilicon.com> wrote:

> Hi Linus, Hi Haojian,
>
> Any comments about this patch?

As it only patches arch/arm it's really an ARM SoC business,
but for what it's worth:

Acked-by: Linus Walleij <linus.walleij@linaro.org>

Yours,
Linus Walleij

Re: [PATCH v6 0/2] ARM: hip04: add GPIO support

[Zhou Wang]

On 2015/2/4 16:47, Linus Walleij wrote:
> On Thu, Jan 29, 2015 at 4:17 AM, Zhou Wang <wangzhou1-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org> wrote:
> 
>> Hi Linus, Hi Haojian,
>>
>> Any comments about this patch?
> 
> As it only patches arch/arm it's really an ARM SoC business,
> but for what it's worth:
> 
> Acked-by: Linus Walleij <linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
> 
> Yours,
> Linus Walleij

Thanks Linus, I will resend after v3.20-rc1

Yours,
Zhou Wang
> --
> To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
> 


--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html