From: Stephen Warren <swarren@wwwdotorg.org>
To: Stefan Agner <stefan@agner.ch>, linus.walleij@linaro.org
Cc: thierry.reding@gmail.com, gnurou@gmail.com,
linux-gpio@vger.kernel.org, linux-tegra@vger.kernel.org,
linux-kernel@vger.kernel.org,
Paul Walmsley <pwalmsley@nvidia.com>
Subject: Re: [PATCH v2] pinctrl: tegra: use signed bitfields for optional fields
Date: Mon, 16 Mar 2015 16:28:17 -0600 [thread overview]
Message-ID: <55075901.1010100@wwwdotorg.org> (raw)
In-Reply-To: <1426542154-31072-1-git-send-email-stefan@agner.ch>
On 03/16/2015 03:42 PM, Stefan Agner wrote:
> Optional fields are set to -1 by various preprocessor macros. Make
> sure the fields can actually store them.
This seems fine to me. I suppose there is a small risk that the old code
let some invalid configurations pass whereas this new code will reject
them and hence not program any later pinmux configurations in the "list"
in DT. However, I suspect the risk is quite small and won't be an issue.
Acked-by: Stephen Warren <swarren@nvidia.com>
I also tested this on Beaver, Dalmore, and Jetson TK1 using Paul
Walmsley's automated test system, and saw no issues, so:
Tested-by: Stephen Warren <swarren@nvidia.com>
next prev parent reply other threads:[~2015-03-16 22:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-16 21:42 [PATCH v2] pinctrl: tegra: use signed bitfields for optional fields Stefan Agner
2015-03-16 22:28 ` Stephen Warren [this message]
2015-03-19 8:21 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55075901.1010100@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=gnurou@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=pwalmsley@nvidia.com \
--cc=stefan@agner.ch \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).