From: Maxime Coquelin <maxime.coquelin@st.com>
To: Lee Jones <lee.jones@linaro.org>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linus.walleij@linaro.org,
linux-gpio@vger.kernel.org
Cc: kernel@stlinux.com
Subject: Re: [STLinux Kernel] [PATCH 5/6] pinctrl: st: Show correct pin direction -- even when in GPIO mode
Date: Wed, 18 Mar 2015 17:45:08 +0100 [thread overview]
Message-ID: <5509AB94.8040100@st.com> (raw)
In-Reply-To: <1426675899-19882-6-git-send-email-lee.jones@linaro.org>
On 03/18/2015 11:51 AM, Lee Jones wrote:
> Until now ST's pinconf_dbg_show() call-back has displayed the PIO
> alternate function direction, which is only relevant if a pin is
> operating in an alternate function mode i.e not GPIO mode. If a
> pin is in GPIO mode its direction is both set and status is
> obtained by a completely different/unrelated bunch of registers.
>
> This change ensures that the correct pin direction is shown, even
> if a pin is operating in GPIO mode.
>
> Reported-by: Olivier Clergeaud <olivier.clergeaud@st.com>
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
> ---
> drivers/pinctrl/pinctrl-st.c | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
>
Acked-by: Maxime Coquelin <maxime.coquelin@st.com>
Thanks,
Maxime
next prev parent reply other threads:[~2015-03-18 16:45 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-18 10:51 [PATCH 0/6] pinctrl: st: Fix disparity between Pinctrl & GPIO in /sysfs Lee Jones
2015-03-18 10:51 ` [PATCH 1/6] ARM: STi: DT: STiH407: Fix retime pin mask for PIO5 and PIO35 Lee Jones
2015-03-18 16:36 ` [STLinux Kernel] " Maxime Coquelin
2015-03-18 10:51 ` [PATCH 2/6] pinctrl: st: Introduce a 'get pin function' call Lee Jones
2015-03-18 16:41 ` [STLinux Kernel] " Maxime Coquelin
2015-03-18 16:51 ` Lee Jones
2015-03-18 17:00 ` Maxime Coquelin
2015-03-18 10:51 ` [PATCH 3/6] pinctrl: st: Move st_get_pio_control() further up the source file Lee Jones
2015-03-18 16:41 ` [STLinux Kernel] " Maxime Coquelin
2015-03-18 10:51 ` [PATCH 4/6] pinctrl: st: Supply a GPIO get_direction() call-back Lee Jones
2015-03-18 16:43 ` [STLinux Kernel] " Maxime Coquelin
2015-03-18 10:51 ` [PATCH 5/6] pinctrl: st: Show correct pin direction -- even when in GPIO mode Lee Jones
2015-03-18 16:45 ` Maxime Coquelin [this message]
2015-03-18 10:51 ` [PATCH 6/6] pinctrl: st: Display pin's function when printing pinctrl debug information Lee Jones
2015-03-18 16:35 ` [STLinux Kernel] " Maxime Coquelin
2015-03-18 16:54 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5509AB94.8040100@st.com \
--to=maxime.coquelin@st.com \
--cc=kernel@stlinux.com \
--cc=lee.jones@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).