From: "Grygorii.Strashko@linaro.org" <grygorii.strashko@linaro.org>
To: Tony Lindgren <tony@atomide.com>
Cc: Javier Martinez Canillas <javier@dowhile0.org>,
Linus Walleij <linus.walleij@linaro.org>,
Alexandre Courbot <gnurou@gmail.com>,
ssantosh@kernel.org, Kevin Hilman <khilman@deeprootsystems.com>,
linux-omap@vger.kernel.org, linux-gpio@vger.kernel.org,
linux-kernel@vger.kernel.org,
Aaro Koskinen <aaro.koskinen@iki.fi>
Subject: Re: [PATCH 0/8] gpio: omap: cleanup: get rid of system GPIO <-> GPIO offset converseations
Date: Fri, 20 Mar 2015 17:11:23 +0200 [thread overview]
Message-ID: <550C389B.2020506@linaro.org> (raw)
In-Reply-To: <20150319230025.GO31346@atomide.com>
On 03/20/2015 01:00 AM, Tony Lindgren wrote:
> * grygorii.strashko@linaro.org <grygorii.strashko@linaro.org> [150319 10:26]:
>> From: Grygorii Strashko <grygorii.strashko@linaro.org>
>>
>> Now in TI OMAP GPIO driver there are a lot of places where
>> System GPIO number calculated and then converted to GPIO offset.
>> What is worse is that in many place such conversation performed twice
>> or even three times. But actually, we don't need to do that at all, because
>> - gpiolib always passes GPIO offset to GPIO controller
>> - OMAP GPIO driver converted to use IRQ domain, so
>> struct irq_data->hwirq contains GPIO offset
>>
>> Hence, it is safe to convert all GPIO OMAP functions to use GPIO
>> offset instead of system GPIO numbers. Also, this allows to remove
>> unneeded conversations routines
>> #define GPIO_INDEX(bank, gpio)
>> #define GPIO_BIT(bank, gpio)
>> int omap_irq_to_gpio()
>
> Right on! This is excellent news. I've tested this set on top of -rc4
> plus the patch mentioned below, and I'm not seeing regressions on
> the platforms I tested with. Wake up to smsc911x ping with off-idle
> still works on omap3.
>
> I only briefly tested on omap1 (osk5912), so I'like to wait for
> Aaro's ack before this gets merged.
>
> I found one build error, other than that, for the whole series
> please feel free to add:
>
> Tested-by: Tony Lindgren <tony@atomide.com>
Thanks Tony.
Yep. I'll wait for news from Aaro then will re-send if ok.
--
regards,
-grygorii
next prev parent reply other threads:[~2015-03-20 15:11 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-19 17:25 [PATCH 0/8] gpio: omap: cleanup: get rid of system GPIO <-> GPIO offset converseations grygorii.strashko
2015-03-19 17:25 ` [PATCH 1/8] gpio: omap: convert omap_gpio_is_input() to use gpio offset grygorii.strashko
2015-03-20 16:42 ` santosh.shilimkar
2015-03-20 18:37 ` Javier Martinez Canillas
2015-03-19 17:25 ` [PATCH 2/8] gpio: omap: simplify omap_set_gpio_dataout_x() grygorii.strashko
2015-03-20 16:45 ` santosh.shilimkar
2015-03-20 18:40 ` Javier Martinez Canillas
2015-03-19 17:25 ` [PATCH 3/8] gpio: omap: convert debounce functions switch to use gpio offset grygorii.strashko
2015-03-20 18:44 ` Javier Martinez Canillas
2015-03-19 17:25 ` [PATCH 4/8] gpio: omap: drop 'gpio' param from omap_gpio_init_irq() grygorii.strashko
2015-03-20 18:46 ` Javier Martinez Canillas
2015-03-19 17:25 ` [PATCH 5/8] gpio: omap: convert gpio irq functions to use GPIO offset grygorii.strashko
2015-03-19 23:03 ` Tony Lindgren
2015-03-20 15:06 ` Grygorii.Strashko@linaro.org
2015-03-20 16:49 ` santosh.shilimkar
2015-03-20 18:47 ` Javier Martinez Canillas
2015-03-19 17:25 ` [PATCH 6/8] gpio: omap: get rid of GPIO_BIT() macro grygorii.strashko
2015-03-20 16:50 ` santosh.shilimkar
2015-03-20 18:48 ` Javier Martinez Canillas
2015-03-19 17:25 ` [RFT OMAP1 PATCH 7/8] gpio: omap: get rid of omap_irq_to_gpio() grygorii.strashko
2015-03-20 18:56 ` Javier Martinez Canillas
2015-03-20 20:39 ` Grygorii.Strashko@linaro.org
2015-03-20 23:44 ` Javier Martinez Canillas
2015-03-19 17:25 ` [RFT OMAP1 PATCH 8/8] gpio: omap: get rid of GPIO_INDEX() macro grygorii.strashko
2015-03-20 18:56 ` Javier Martinez Canillas
2015-03-19 23:00 ` [PATCH 0/8] gpio: omap: cleanup: get rid of system GPIO <-> GPIO offset converseations Tony Lindgren
2015-03-20 15:11 ` Grygorii.Strashko@linaro.org [this message]
2015-03-22 17:32 ` Aaro Koskinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=550C389B.2020506@linaro.org \
--to=grygorii.strashko@linaro.org \
--cc=aaro.koskinen@iki.fi \
--cc=gnurou@gmail.com \
--cc=javier@dowhile0.org \
--cc=khilman@deeprootsystems.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=ssantosh@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).