* Re: [PATCH] gpio: syscon: reduce message level when direction reg offset not in dt
2015-03-24 18:42 ` [PATCH] gpio: syscon: reduce message level when direction reg offset not in dt grygorii.strashko
@ 2015-03-24 20:00 ` Murali Karicheri
2015-03-24 20:52 ` santosh shilimkar
2015-03-27 10:18 ` Linus Walleij
2 siblings, 0 replies; 4+ messages in thread
From: Murali Karicheri @ 2015-03-24 20:00 UTC (permalink / raw)
To: grygorii.strashko
Cc: linux, Linus Walleij, Alexandre Courbot, ssantosh, linux-gpio,
linux-kernel
On 03/24/2015 02:42 PM, grygorii.strashko@linaro.org wrote:
> From: Grygorii Strashko<grygorii.strashko@linaro.org>
>
> Now GPIO syscon driver produces bunch of warnings during the
> boot of Kesytone 2 SoCs:
> gpio-syscon soc:keystone_dsp_gpio@02620240: can't read the dir register offset!
> gpio-syscon soc:keystone_dsp_gpio@2620244: can't read the dir register offset!
>
> This message unintentionally was added using dev_err(), but its
> actual log level is debug, because third cell of "ti,syscon-dev" is
> optional.
>
> Hence change it to dev_dbg() as it should be.
>
> This patch fixes commit:
> 5a3e3f8 ("gpio: syscon: retriave syscon node and regs offsets from dt")
>
> Reported-by: Russell King<linux@arm.linux.org.uk>
> Signed-off-by: Grygorii Strashko<grygorii.strashko@linaro.org>
> ---
> drivers/gpio/gpio-syscon.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpio/gpio-syscon.c b/drivers/gpio/gpio-syscon.c
> index 257e298..045a952 100644
> --- a/drivers/gpio/gpio-syscon.c
> +++ b/drivers/gpio/gpio-syscon.c
> @@ -219,7 +219,7 @@ static int syscon_gpio_probe(struct platform_device *pdev)
> ret = of_property_read_u32_index(np, "gpio,syscon-dev", 2,
> &priv->dir_reg_offset);
> if (ret)
> - dev_err(dev, "can't read the dir register offset!\n");
> + dev_dbg(dev, "can't read the dir register offset!\n");
>
> priv->dir_reg_offset<<= 3;
> }
Tested this on K2HK EVM and found the error log is not appearing any more.
Tested-by: Murali Karicheri <m-karicheri2@ti.com>
--
Murali Karicheri
Linux Kernel, Texas Instruments
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] gpio: syscon: reduce message level when direction reg offset not in dt
2015-03-24 18:42 ` [PATCH] gpio: syscon: reduce message level when direction reg offset not in dt grygorii.strashko
2015-03-24 20:00 ` Murali Karicheri
@ 2015-03-24 20:52 ` santosh shilimkar
2015-03-27 10:18 ` Linus Walleij
2 siblings, 0 replies; 4+ messages in thread
From: santosh shilimkar @ 2015-03-24 20:52 UTC (permalink / raw)
To: grygorii.strashko, linux, Linus Walleij, Alexandre Courbot
Cc: m-karicheri2, ssantosh, linux-gpio, linux-kernel
On 3/24/2015 11:42 AM, grygorii.strashko@linaro.org wrote:
> From: Grygorii Strashko <grygorii.strashko@linaro.org>
>
> Now GPIO syscon driver produces bunch of warnings during the
> boot of Kesytone 2 SoCs:
> gpio-syscon soc:keystone_dsp_gpio@02620240: can't read the dir register offset!
> gpio-syscon soc:keystone_dsp_gpio@2620244: can't read the dir register offset!
>
> This message unintentionally was added using dev_err(), but its
> actual log level is debug, because third cell of "ti,syscon-dev" is
> optional.
>
> Hence change it to dev_dbg() as it should be.
>
> This patch fixes commit:
> 5a3e3f8 ("gpio: syscon: retriave syscon node and regs offsets from dt")
>
> Reported-by: Russell King <linux@arm.linux.org.uk>
> Signed-off-by: Grygorii Strashko <grygorii.strashko@linaro.org>
> ---
Acked-by: Santosh Shilimkar <ssantosh@kernel.org>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] gpio: syscon: reduce message level when direction reg offset not in dt
2015-03-24 18:42 ` [PATCH] gpio: syscon: reduce message level when direction reg offset not in dt grygorii.strashko
2015-03-24 20:00 ` Murali Karicheri
2015-03-24 20:52 ` santosh shilimkar
@ 2015-03-27 10:18 ` Linus Walleij
2 siblings, 0 replies; 4+ messages in thread
From: Linus Walleij @ 2015-03-27 10:18 UTC (permalink / raw)
To: Grygorii Strashko
Cc: Russell King - ARM Linux, Alexandre Courbot,
Muralidharan Karicheri, Santosh Shilimkar,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org
On Tue, Mar 24, 2015 at 7:42 PM, <grygorii.strashko@linaro.org> wrote:
> From: Grygorii Strashko <grygorii.strashko@linaro.org>
>
> Now GPIO syscon driver produces bunch of warnings during the
> boot of Kesytone 2 SoCs:
> gpio-syscon soc:keystone_dsp_gpio@02620240: can't read the dir register offset!
> gpio-syscon soc:keystone_dsp_gpio@2620244: can't read the dir register offset!
>
> This message unintentionally was added using dev_err(), but its
> actual log level is debug, because third cell of "ti,syscon-dev" is
> optional.
>
> Hence change it to dev_dbg() as it should be.
>
> This patch fixes commit:
> 5a3e3f8 ("gpio: syscon: retriave syscon node and regs offsets from dt")
>
> Reported-by: Russell King <linux@arm.linux.org.uk>
> Signed-off-by: Grygorii Strashko <grygorii.strashko@linaro.org>
OK sorry for missing this when asking about the strange messages.
Patch applied for fixes with these test tags and ack.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 4+ messages in thread