* [PATCH] gpio: zynq: add missing module_exit function
@ 2015-06-17 8:51 Masahiro Yamada
2015-06-18 11:24 ` Michal Simek
2015-07-14 13:38 ` Linus Walleij
0 siblings, 2 replies; 3+ messages in thread
From: Masahiro Yamada @ 2015-06-17 8:51 UTC (permalink / raw)
To: linux-gpio
Cc: Masahiro Yamada, Sören Brinkmann, Michal Simek,
Linus Walleij, linux-kernel, Alexandre Courbot, linux-arm-kernel
This driver is tristate, so it should be cleanable.
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---
drivers/gpio/gpio-zynq.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/drivers/gpio/gpio-zynq.c b/drivers/gpio/gpio-zynq.c
index 184c4b1..1d38da7 100644
--- a/drivers/gpio/gpio-zynq.c
+++ b/drivers/gpio/gpio-zynq.c
@@ -722,6 +722,12 @@ static int __init zynq_gpio_init(void)
}
postcore_initcall(zynq_gpio_init);
+static void __exit zynq_gpio_exit(void)
+{
+ platform_driver_unregister(&zynq_gpio_driver);
+}
+module_exit(zynq_gpio_exit);
+
MODULE_AUTHOR("Xilinx Inc.");
MODULE_DESCRIPTION("Zynq GPIO driver");
MODULE_LICENSE("GPL");
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] gpio: zynq: add missing module_exit function
2015-06-17 8:51 [PATCH] gpio: zynq: add missing module_exit function Masahiro Yamada
@ 2015-06-18 11:24 ` Michal Simek
2015-07-14 13:38 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Michal Simek @ 2015-06-18 11:24 UTC (permalink / raw)
To: Masahiro Yamada, linux-gpio
Cc: Sören Brinkmann, Michal Simek, Linus Walleij, linux-kernel,
Alexandre Courbot, linux-arm-kernel
On 06/17/2015 10:51 AM, Masahiro Yamada wrote:
> This driver is tristate, so it should be cleanable.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> ---
>
> drivers/gpio/gpio-zynq.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/drivers/gpio/gpio-zynq.c b/drivers/gpio/gpio-zynq.c
> index 184c4b1..1d38da7 100644
> --- a/drivers/gpio/gpio-zynq.c
> +++ b/drivers/gpio/gpio-zynq.c
> @@ -722,6 +722,12 @@ static int __init zynq_gpio_init(void)
> }
> postcore_initcall(zynq_gpio_init);
>
> +static void __exit zynq_gpio_exit(void)
> +{
> + platform_driver_unregister(&zynq_gpio_driver);
> +}
> +module_exit(zynq_gpio_exit);
> +
> MODULE_AUTHOR("Xilinx Inc.");
> MODULE_DESCRIPTION("Zynq GPIO driver");
> MODULE_LICENSE("GPL");
>
Looks reasonable to me.
Tested-by: Michal Simek <michal.simek@xilinx.com>
Thanks,
Michal
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] gpio: zynq: add missing module_exit function
2015-06-17 8:51 [PATCH] gpio: zynq: add missing module_exit function Masahiro Yamada
2015-06-18 11:24 ` Michal Simek
@ 2015-07-14 13:38 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Linus Walleij @ 2015-07-14 13:38 UTC (permalink / raw)
To: Masahiro Yamada
Cc: linux-gpio@vger.kernel.org, Sören Brinkmann, Michal Simek,
linux-kernel@vger.kernel.org, Alexandre Courbot,
linux-arm-kernel@lists.infradead.org
On Wed, Jun 17, 2015 at 10:51 AM, Masahiro Yamada
<yamada.masahiro@socionext.com> wrote:
> This driver is tristate, so it should be cleanable.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Patch applied with Michal's test tag.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-07-14 13:38 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-06-17 8:51 [PATCH] gpio: zynq: add missing module_exit function Masahiro Yamada
2015-06-18 11:24 ` Michal Simek
2015-07-14 13:38 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).