* [PATCH] gpio: msm: Remove empty msm_gpio_{request,free}()
@ 2015-07-01 12:27 Geert Uytterhoeven
2015-07-01 17:40 ` Stephen Boyd
0 siblings, 1 reply; 2+ messages in thread
From: Geert Uytterhoeven @ 2015-07-01 12:27 UTC (permalink / raw)
To: Linus Walleij, Alexandre Courbot
Cc: linux-gpio, linux-arm-msm, linux-arm-kernel, Geert Uytterhoeven
gpio_chip.request() and gpio_chip.free() are optional, and can just be
left unimplemented.
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
Untested due to lack of hardware.
---
drivers/gpio/gpio-msm-v2.c | 12 ------------
1 file changed, 12 deletions(-)
diff --git a/drivers/gpio/gpio-msm-v2.c b/drivers/gpio/gpio-msm-v2.c
index 52ff18229fdc874a..d9ea0c8e5f0aa82d 100644
--- a/drivers/gpio/gpio-msm-v2.c
+++ b/drivers/gpio/gpio-msm-v2.c
@@ -169,16 +169,6 @@ static int msm_gpio_direction_output(struct gpio_chip *chip,
return 0;
}
-static int msm_gpio_request(struct gpio_chip *chip, unsigned offset)
-{
- return 0;
-}
-
-static void msm_gpio_free(struct gpio_chip *chip, unsigned offset)
-{
- return;
-}
-
static int msm_gpio_to_irq(struct gpio_chip *chip, unsigned offset)
{
struct msm_gpio_dev *g_dev = to_msm_gpio_dev(chip);
@@ -404,8 +394,6 @@ static int msm_gpio_probe(struct platform_device *pdev)
msm_gpio.gpio_chip.get = msm_gpio_get;
msm_gpio.gpio_chip.set = msm_gpio_set;
msm_gpio.gpio_chip.to_irq = msm_gpio_to_irq;
- msm_gpio.gpio_chip.request = msm_gpio_request;
- msm_gpio.gpio_chip.free = msm_gpio_free;
ret = gpiochip_add(&msm_gpio.gpio_chip);
if (ret < 0) {
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] gpio: msm: Remove empty msm_gpio_{request,free}()
2015-07-01 12:27 [PATCH] gpio: msm: Remove empty msm_gpio_{request,free}() Geert Uytterhoeven
@ 2015-07-01 17:40 ` Stephen Boyd
0 siblings, 0 replies; 2+ messages in thread
From: Stephen Boyd @ 2015-07-01 17:40 UTC (permalink / raw)
To: Geert Uytterhoeven, Linus Walleij, Alexandre Courbot
Cc: linux-gpio, linux-arm-msm, linux-arm-kernel
On 07/01/2015 05:27 AM, Geert Uytterhoeven wrote:
> gpio_chip.request() and gpio_chip.free() are optional, and can just be
> left unimplemented.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> Untested due to lack of hardware.
Actually we should just delete this driver now that we have an msm8660
pinctrl implementation.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-07-01 17:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-07-01 12:27 [PATCH] gpio: msm: Remove empty msm_gpio_{request,free}() Geert Uytterhoeven
2015-07-01 17:40 ` Stephen Boyd
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).