* [Resend PATCH] gpio/davinci: add interrupt support for GPIOs 16-31
@ 2015-07-01 17:41 Vitaly Andrianov
2015-07-02 10:13 ` Grygorii Strashko
0 siblings, 1 reply; 3+ messages in thread
From: Vitaly Andrianov @ 2015-07-01 17:41 UTC (permalink / raw)
To: linus.walleij, gnurou, linux-gpio, linux-kernel; +Cc: Vitaly Andrianov
Interrupts for GPIOs 16 through 31 are enabled by bit 1 in the
"binten" register (offset 8). Previous versions of GPIO only
used bit 0, which enables GPIO 0-15 interrupts.
Signed-off-by: Vitaly Andrianov <vitalya@ti.com>
---
I posted this patch on 06/18/15 and didn't get any response.
Please, could you review the patch.
drivers/gpio/gpio-davinci.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpio/gpio-davinci.c b/drivers/gpio/gpio-davinci.c
index c5e05c8..c90629f 100644
--- a/drivers/gpio/gpio-davinci.c
+++ b/drivers/gpio/gpio-davinci.c
@@ -546,6 +546,8 @@ static int davinci_gpio_irq_setup(struct platform_device *pdev)
chips[0].gpio_irq = bank_irq;
chips[0].gpio_unbanked = pdata->gpio_unbanked;
binten = BIT(0);
+ if (pdata->gpio_unbanked > 16)
+ binten |= BIT(1);
/* AINTC handles mask/unmask; GPIO handles triggering */
irq = bank_irq;
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Resend PATCH] gpio/davinci: add interrupt support for GPIOs 16-31
2015-07-01 17:41 [Resend PATCH] gpio/davinci: add interrupt support for GPIOs 16-31 Vitaly Andrianov
@ 2015-07-02 10:13 ` Grygorii Strashko
2015-07-02 10:33 ` Sekhar Nori
0 siblings, 1 reply; 3+ messages in thread
From: Grygorii Strashko @ 2015-07-02 10:13 UTC (permalink / raw)
To: Vitaly Andrianov, linus.walleij, gnurou, linux-gpio, linux-kernel,
Sekhar Nori
On 07/01/2015 08:41 PM, Vitaly Andrianov wrote:
> Interrupts for GPIOs 16 through 31 are enabled by bit 1 in the
> "binten" register (offset 8). Previous versions of GPIO only
> used bit 0, which enables GPIO 0-15 interrupts.
Cc: Sekhar Nori
>
> Signed-off-by: Vitaly Andrianov <vitalya@ti.com>
Reviewed-by: Grygorii Strashko <grygorii.strashko@ti.com>
> ---
> I posted this patch on 06/18/15 and didn't get any response.
> Please, could you review the patch.
>
> drivers/gpio/gpio-davinci.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpio/gpio-davinci.c b/drivers/gpio/gpio-davinci.c
> index c5e05c8..c90629f 100644
> --- a/drivers/gpio/gpio-davinci.c
> +++ b/drivers/gpio/gpio-davinci.c
> @@ -546,6 +546,8 @@ static int davinci_gpio_irq_setup(struct platform_device *pdev)
> chips[0].gpio_irq = bank_irq;
> chips[0].gpio_unbanked = pdata->gpio_unbanked;
> binten = BIT(0);
> + if (pdata->gpio_unbanked > 16)
> + binten |= BIT(1);
>
> /* AINTC handles mask/unmask; GPIO handles triggering */
> irq = bank_irq;
>
--
regards,
-grygorii
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Resend PATCH] gpio/davinci: add interrupt support for GPIOs 16-31
2015-07-02 10:13 ` Grygorii Strashko
@ 2015-07-02 10:33 ` Sekhar Nori
0 siblings, 0 replies; 3+ messages in thread
From: Sekhar Nori @ 2015-07-02 10:33 UTC (permalink / raw)
To: Grygorii Strashko, Vitaly Andrianov, linus.walleij, gnurou,
linux-gpio, linux-kernel
On Thursday 02 July 2015 03:43 PM, Grygorii Strashko wrote:
> On 07/01/2015 08:41 PM, Vitaly Andrianov wrote:
>> Interrupts for GPIOs 16 through 31 are enabled by bit 1 in the
>> "binten" register (offset 8). Previous versions of GPIO only
>> used bit 0, which enables GPIO 0-15 interrupts.
>
> Cc: Sekhar Nori
>
>>
>> Signed-off-by: Vitaly Andrianov <vitalya@ti.com>
>
> Reviewed-by: Grygorii Strashko <grygorii.strashko@ti.com>
>
>> ---
>> I posted this patch on 06/18/15 and didn't get any response.
>> Please, could you review the patch.
>>
>> drivers/gpio/gpio-davinci.c | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/gpio/gpio-davinci.c b/drivers/gpio/gpio-davinci.c
>> index c5e05c8..c90629f 100644
>> --- a/drivers/gpio/gpio-davinci.c
>> +++ b/drivers/gpio/gpio-davinci.c
>> @@ -546,6 +546,8 @@ static int davinci_gpio_irq_setup(struct
>> platform_device *pdev)
>> chips[0].gpio_irq = bank_irq;
>> chips[0].gpio_unbanked = pdata->gpio_unbanked;
>> binten = BIT(0);
>> + if (pdata->gpio_unbanked > 16)
>> + binten |= BIT(1);
Or
binten = GENMASK(pdata->gpio_unbanked / 16, 0);
?
Thanks,
Sekhar
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-07-02 10:33 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-07-01 17:41 [Resend PATCH] gpio/davinci: add interrupt support for GPIOs 16-31 Vitaly Andrianov
2015-07-02 10:13 ` Grygorii Strashko
2015-07-02 10:33 ` Sekhar Nori
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).