* [PATCH v2] gpio/davinci: add interrupt support for GPIOs 16-31
@ 2015-07-02 18:31 Vitaly Andrianov
2015-07-16 9:04 ` Sekhar Nori
2015-07-17 12:16 ` Linus Walleij
0 siblings, 2 replies; 4+ messages in thread
From: Vitaly Andrianov @ 2015-07-02 18:31 UTC (permalink / raw)
To: linux-gpio, linux-kernel, gnurou, linus.walleij, nsekhar,
grygorii.strashko, m-karicheri2
Cc: Vitaly Andrianov
Interrupts for GPIOs 16 through 31 are enabled by bit 1 in the
"binten" register (offset 8). Previous versions of GPIO only
used bit 0, which enables GPIO 0-15 interrupts.
Signed-off-by: Vitaly Andrianov <vitalya@ti.com>
Reviewed-by: Grygorii Strashko <grygorii.strashko@ti.com>
---
History
v2.
- use GENMASK to set binten. Thanks to Nori Sekhar's.
drivers/gpio/gpio-davinci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpio/gpio-davinci.c b/drivers/gpio/gpio-davinci.c
index c5e05c8..86cfe18 100644
--- a/drivers/gpio/gpio-davinci.c
+++ b/drivers/gpio/gpio-davinci.c
@@ -545,7 +545,7 @@ static int davinci_gpio_irq_setup(struct platform_device *pdev)
chips[0].chip.to_irq = gpio_to_irq_unbanked;
chips[0].gpio_irq = bank_irq;
chips[0].gpio_unbanked = pdata->gpio_unbanked;
- binten = BIT(0);
+ binten = GENMASK(pdata->gpio_unbanked / 16, 0);
/* AINTC handles mask/unmask; GPIO handles triggering */
irq = bank_irq;
--
1.8.3.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v2] gpio/davinci: add interrupt support for GPIOs 16-31
2015-07-02 18:31 [PATCH v2] gpio/davinci: add interrupt support for GPIOs 16-31 Vitaly Andrianov
@ 2015-07-16 9:04 ` Sekhar Nori
2015-07-17 12:16 ` Linus Walleij
1 sibling, 0 replies; 4+ messages in thread
From: Sekhar Nori @ 2015-07-16 9:04 UTC (permalink / raw)
To: Vitaly Andrianov, linux-gpio, linux-kernel, gnurou, linus.walleij,
grygorii.strashko, m-karicheri2
On Friday 03 July 2015 12:01 AM, Vitaly Andrianov wrote:
> Interrupts for GPIOs 16 through 31 are enabled by bit 1 in the
> "binten" register (offset 8). Previous versions of GPIO only
> used bit 0, which enables GPIO 0-15 interrupts.
>
> Signed-off-by: Vitaly Andrianov <vitalya@ti.com>
> Reviewed-by: Grygorii Strashko <grygorii.strashko@ti.com>
Reviewed-by: Sekhar Nori <nsekhar@ti.com>
Thanks,
Sekhar
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] gpio/davinci: add interrupt support for GPIOs 16-31
2015-07-02 18:31 [PATCH v2] gpio/davinci: add interrupt support for GPIOs 16-31 Vitaly Andrianov
2015-07-16 9:04 ` Sekhar Nori
@ 2015-07-17 12:16 ` Linus Walleij
2015-07-17 14:51 ` Vitaly Andrianov
1 sibling, 1 reply; 4+ messages in thread
From: Linus Walleij @ 2015-07-17 12:16 UTC (permalink / raw)
To: Vitaly Andrianov
Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
Alexandre Courbot, Sekhar Nori, Grygorii Strashko,
Muralidharan Karicheri
On Thu, Jul 2, 2015 at 8:31 PM, Vitaly Andrianov <vitalya@ti.com> wrote:
> Interrupts for GPIOs 16 through 31 are enabled by bit 1 in the
> "binten" register (offset 8). Previous versions of GPIO only
> used bit 0, which enables GPIO 0-15 interrupts.
>
> Signed-off-by: Vitaly Andrianov <vitalya@ti.com>
> Reviewed-by: Grygorii Strashko <grygorii.strashko@ti.com>
> ---
> History
>
> v2.
> - use GENMASK to set binten. Thanks to Nori Sekhar's.
This version applied for v4.3 with Sekhar's review tag.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] gpio/davinci: add interrupt support for GPIOs 16-31
2015-07-17 12:16 ` Linus Walleij
@ 2015-07-17 14:51 ` Vitaly Andrianov
0 siblings, 0 replies; 4+ messages in thread
From: Vitaly Andrianov @ 2015-07-17 14:51 UTC (permalink / raw)
To: Linus Walleij
Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
Alexandre Courbot, Sekhar Nori, Grygorii Strashko,
Muralidharan Karicheri
On 07/17/2015 08:16 AM, Linus Walleij wrote:
> On Thu, Jul 2, 2015 at 8:31 PM, Vitaly Andrianov <vitalya@ti.com> wrote:
>
>> Interrupts for GPIOs 16 through 31 are enabled by bit 1 in the
>> "binten" register (offset 8). Previous versions of GPIO only
>> used bit 0, which enables GPIO 0-15 interrupts.
>>
>> Signed-off-by: Vitaly Andrianov <vitalya@ti.com>
>> Reviewed-by: Grygorii Strashko <grygorii.strashko@ti.com>
>> ---
>> History
>>
>> v2.
>> - use GENMASK to set binten. Thanks to Nori Sekhar's.
>
> This version applied for v4.3 with Sekhar's review tag.
>
> Yours,
> Linus Walleij
>
Thank you.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-07-17 14:46 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-07-02 18:31 [PATCH v2] gpio/davinci: add interrupt support for GPIOs 16-31 Vitaly Andrianov
2015-07-16 9:04 ` Sekhar Nori
2015-07-17 12:16 ` Linus Walleij
2015-07-17 14:51 ` Vitaly Andrianov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).