linux-gpio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Olliver Schinagl <oliver@schinagl.nl>
To: Alexandre Courbot <gnurou@gmail.com>,
	Olliver Schinagl <oliver+list@schinagl.nl>
Cc: Linus Walleij <linus.walleij@linaro.org>,
	Mika Westerberg <mika.westerberg@linux.intel.com>,
	"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/1] gpio: gpiolib: fix identation
Date: Thu, 24 Sep 2015 09:39:51 +0200	[thread overview]
Message-ID: <5603A8C7.9050104@schinagl.nl> (raw)
In-Reply-To: <CAAVeFuKYcNFpRMMUQG9OeXGt6cPG68e8FvmvefXocU-b_6eY8g@mail.gmail.com>

Appologies! I should not do this early in the morning. It is indeed a 
copy/paste fail (and not noticing the missing minus) from the section 
above i was working on.

I'm sorry for the noise!

Olliver

On 24-09-15 09:17, Alexandre Courbot wrote:
> On Thu, Sep 24, 2015 at 4:14 PM, Olliver Schinagl
> <oliver+list@schinagl.nl> wrote:
>> From: Olliver Schinagl <oliver@schinagl.nl>
>>
>> Just a very small cosmetical indentation fix, no code changes
> You are adding two lines and not removing any, so it is not just a
> cosmetic fix and actually adds code.
>
>> Signed-off-by: Olliver Schinagl <oliver@schinagl.nl>
>> ---
>>   drivers/gpio/gpiolib.c | 2 ++
>>   1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
>> index 980c1f8..5ef9ac2 100644
>> --- a/drivers/gpio/gpiolib.c
>> +++ b/drivers/gpio/gpiolib.c
>> @@ -1746,6 +1746,8 @@ static struct gpio_desc *acpi_find_gpio(struct device *dev, const char *con_id,
>>                  if (con_id && strcmp(con_id, "gpios")) {
>>                          snprintf(propname, sizeof(propname), "%s-%s",
>>                                   con_id, gpio_suffixes[i]);
>> +                       if (!IS_ERR(desc) || (PTR_ERR(desc) == -EPROBE_DEFER))
>> +                               break;
>>                  } else {
>>                          snprintf(propname, sizeof(propname), "%s",
>>                                   gpio_suffixes[i]);
>> --
>> 2.5.1
>>

      reply	other threads:[~2015-09-24  7:39 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-24  7:14 [PATCH 1/1] gpio: gpiolib: fix identation Olliver Schinagl
2015-09-24  7:17 ` Alexandre Courbot
2015-09-24  7:39   ` Olliver Schinagl [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5603A8C7.9050104@schinagl.nl \
    --to=oliver@schinagl.nl \
    --cc=gnurou@gmail.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mika.westerberg@linux.intel.com \
    --cc=oliver+list@schinagl.nl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).